Title: [196763] trunk/Source/WebCore
Revision
196763
Author
[email protected]
Date
2016-02-18 10:13:32 -0800 (Thu, 18 Feb 2016)

Log Message

Remove redundant ASSERT_WITH_MESSAGE_UNUSED() from SOFT_LINK_FRAMEWORK_FOR_SOURCE() macro

Follow-up fix noted by Andy Estes for:

    [Cocoa] Always check the return value of dlopen() and dlsym() in Release builds
    <http://webkit.org/b/154364>

* platform/mac/SoftLinking.h:
(SOFT_LINK_FRAMEWORK_FOR_SOURCE): Remove redundant
ASSERT_WITH_MESSAGE_UNUSED().

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (196762 => 196763)


--- trunk/Source/WebCore/ChangeLog	2016-02-18 17:53:33 UTC (rev 196762)
+++ trunk/Source/WebCore/ChangeLog	2016-02-18 18:13:32 UTC (rev 196763)
@@ -1,3 +1,16 @@
+2016-02-18  David Kilzer  <[email protected]>
+
+        Remove redundant ASSERT_WITH_MESSAGE_UNUSED() from SOFT_LINK_FRAMEWORK_FOR_SOURCE() macro
+
+        Follow-up fix noted by Andy Estes for:
+
+            [Cocoa] Always check the return value of dlopen() and dlsym() in Release builds
+            <http://webkit.org/b/154364>
+
+        * platform/mac/SoftLinking.h:
+        (SOFT_LINK_FRAMEWORK_FOR_SOURCE): Remove redundant
+        ASSERT_WITH_MESSAGE_UNUSED().
+
 2016-02-18  Andreas Kling  <[email protected]>
 
         Reduce tiling coverage immediately when memory pressure hits.

Modified: trunk/Source/WebCore/platform/mac/SoftLinking.h (196762 => 196763)


--- trunk/Source/WebCore/platform/mac/SoftLinking.h	2016-02-18 17:53:33 UTC (rev 196762)
+++ trunk/Source/WebCore/platform/mac/SoftLinking.h	2016-02-18 18:13:32 UTC (rev 196763)
@@ -321,7 +321,6 @@
             if (!isOptional) \
                 RELEASE_ASSERT_WITH_MESSAGE(frameworkLibrary, "%s", dlerror()); \
         }); \
-        ASSERT_WITH_MESSAGE_UNUSED(isOptional, isOptional || frameworkLibrary, "%s", dlerror()); \
         return frameworkLibrary; \
     } \
     }
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to