Diff
Modified: trunk/LayoutTests/imported/w3c/ChangeLog (196792 => 196793)
--- trunk/LayoutTests/imported/w3c/ChangeLog 2016-02-19 02:44:34 UTC (rev 196792)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2016-02-19 02:45:50 UTC (rev 196793)
@@ -1,5 +1,17 @@
2016-02-18 Chris Dumez <[email protected]>
+ HTMLTableHeaderCellElement.scope should only return known values
+ https://bugs.webkit.org/show_bug.cgi?id=154423
+ <rdar://problem/24731018>
+
+ Reviewed by Ryosuke Niwa.
+
+ Rebaseline now that more checks are passing.
+
+ * web-platform-tests/html/dom/reflection-tabular-expected.txt:
+
+2016-02-18 Chris Dumez <[email protected]>
+
[Unforgeable] operations should not be writable as per Web IDL
https://bugs.webkit.org/show_bug.cgi?id=154396
<rdar://problem/24721063>
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/reflection-tabular-expected.txt (196792 => 196793)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/reflection-tabular-expected.txt 2016-02-19 02:44:34 UTC (rev 196792)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/reflection-tabular-expected.txt 2016-02-19 02:45:50 UTC (rev 196793)
@@ -12610,177 +12610,177 @@
PASS th.scope: setAttribute() to "" followed by getAttribute()
PASS th.scope: setAttribute() to "" followed by IDL get
PASS th.scope: setAttribute() to " \0\x01\x02\x03\x04\x05\x06\x07 \b\t\n\v\f\r\x0e\x0f \x10\x11\x12\x13\x14\x15\x16\x17 \x18\x19\x1a\x1b\x1c\x1d\x1e\x1f foo " followed by getAttribute()
-FAIL th.scope: setAttribute() to " \0\x01\x02\x03\x04\x05\x06\x07 \b\t\n\v\f\r\x0e\x0f \x10\x11\x12\x13\x14\x15\x16\x17 \x18\x19\x1a\x1b\x1c\x1d\x1e\x1f foo " followed by IDL get assert_equals: expected "" but got " \0\x01\x02\x03\x04\x05\x06\x07 \b\t\n\v\f\r\x0e\x0f \x10\x11\x12\x13\x14\x15\x16\x17 \x18\x19\x1a\x1b\x1c\x1d\x1e\x1f foo "
+PASS th.scope: setAttribute() to " \0\x01\x02\x03\x04\x05\x06\x07 \b\t\n\v\f\r\x0e\x0f \x10\x11\x12\x13\x14\x15\x16\x17 \x18\x19\x1a\x1b\x1c\x1d\x1e\x1f foo " followed by IDL get
PASS th.scope: setAttribute() to undefined followed by getAttribute()
-FAIL th.scope: setAttribute() to undefined followed by IDL get assert_equals: expected "" but got "undefined"
+PASS th.scope: setAttribute() to undefined followed by IDL get
PASS th.scope: setAttribute() to 7 followed by getAttribute()
-FAIL th.scope: setAttribute() to 7 followed by IDL get assert_equals: expected "" but got "7"
+PASS th.scope: setAttribute() to 7 followed by IDL get
PASS th.scope: setAttribute() to 1.5 followed by getAttribute()
-FAIL th.scope: setAttribute() to 1.5 followed by IDL get assert_equals: expected "" but got "1.5"
+PASS th.scope: setAttribute() to 1.5 followed by IDL get
PASS th.scope: setAttribute() to true followed by getAttribute()
-FAIL th.scope: setAttribute() to true followed by IDL get assert_equals: expected "" but got "true"
+PASS th.scope: setAttribute() to true followed by IDL get
PASS th.scope: setAttribute() to false followed by getAttribute()
-FAIL th.scope: setAttribute() to false followed by IDL get assert_equals: expected "" but got "false"
+PASS th.scope: setAttribute() to false followed by IDL get
PASS th.scope: setAttribute() to object "[object Object]" followed by getAttribute()
-FAIL th.scope: setAttribute() to object "[object Object]" followed by IDL get assert_equals: expected "" but got "[object Object]"
+PASS th.scope: setAttribute() to object "[object Object]" followed by IDL get
PASS th.scope: setAttribute() to NaN followed by getAttribute()
-FAIL th.scope: setAttribute() to NaN followed by IDL get assert_equals: expected "" but got "NaN"
+PASS th.scope: setAttribute() to NaN followed by IDL get
PASS th.scope: setAttribute() to Infinity followed by getAttribute()
-FAIL th.scope: setAttribute() to Infinity followed by IDL get assert_equals: expected "" but got "Infinity"
+PASS th.scope: setAttribute() to Infinity followed by IDL get
PASS th.scope: setAttribute() to -Infinity followed by getAttribute()
-FAIL th.scope: setAttribute() to -Infinity followed by IDL get assert_equals: expected "" but got "-Infinity"
+PASS th.scope: setAttribute() to -Infinity followed by IDL get
PASS th.scope: setAttribute() to "\0" followed by getAttribute()
-FAIL th.scope: setAttribute() to "\0" followed by IDL get assert_equals: expected "" but got "\0"
+PASS th.scope: setAttribute() to "\0" followed by IDL get
PASS th.scope: setAttribute() to null followed by getAttribute()
-FAIL th.scope: setAttribute() to null followed by IDL get assert_equals: expected "" but got "null"
+PASS th.scope: setAttribute() to null followed by IDL get
PASS th.scope: setAttribute() to object "test-toString" followed by getAttribute()
-FAIL th.scope: setAttribute() to object "test-toString" followed by IDL get assert_equals: expected "" but got "test-toString"
+PASS th.scope: setAttribute() to object "test-toString" followed by IDL get
PASS th.scope: setAttribute() to object "test-valueOf" followed by getAttribute()
-FAIL th.scope: setAttribute() to object "test-valueOf" followed by IDL get assert_equals: expected "" but got "test-valueOf"
+PASS th.scope: setAttribute() to object "test-valueOf" followed by IDL get
PASS th.scope: setAttribute() to "row" followed by getAttribute()
PASS th.scope: setAttribute() to "row" followed by IDL get
PASS th.scope: setAttribute() to "xrow" followed by getAttribute()
-FAIL th.scope: setAttribute() to "xrow" followed by IDL get assert_equals: expected "" but got "xrow"
+PASS th.scope: setAttribute() to "xrow" followed by IDL get
PASS th.scope: setAttribute() to "row\0" followed by getAttribute()
-FAIL th.scope: setAttribute() to "row\0" followed by IDL get assert_equals: expected "" but got "row\0"
+PASS th.scope: setAttribute() to "row\0" followed by IDL get
PASS th.scope: setAttribute() to "ow" followed by getAttribute()
-FAIL th.scope: setAttribute() to "ow" followed by IDL get assert_equals: expected "" but got "ow"
+PASS th.scope: setAttribute() to "ow" followed by IDL get
PASS th.scope: setAttribute() to "ROW" followed by getAttribute()
-FAIL th.scope: setAttribute() to "ROW" followed by IDL get assert_equals: expected "row" but got "ROW"
+PASS th.scope: setAttribute() to "ROW" followed by IDL get
PASS th.scope: setAttribute() to "col" followed by getAttribute()
PASS th.scope: setAttribute() to "col" followed by IDL get
PASS th.scope: setAttribute() to "xcol" followed by getAttribute()
-FAIL th.scope: setAttribute() to "xcol" followed by IDL get assert_equals: expected "" but got "xcol"
+PASS th.scope: setAttribute() to "xcol" followed by IDL get
PASS th.scope: setAttribute() to "col\0" followed by getAttribute()
-FAIL th.scope: setAttribute() to "col\0" followed by IDL get assert_equals: expected "" but got "col\0"
+PASS th.scope: setAttribute() to "col\0" followed by IDL get
PASS th.scope: setAttribute() to "ol" followed by getAttribute()
-FAIL th.scope: setAttribute() to "ol" followed by IDL get assert_equals: expected "" but got "ol"
+PASS th.scope: setAttribute() to "ol" followed by IDL get
PASS th.scope: setAttribute() to "COL" followed by getAttribute()
-FAIL th.scope: setAttribute() to "COL" followed by IDL get assert_equals: expected "col" but got "COL"
+PASS th.scope: setAttribute() to "COL" followed by IDL get
PASS th.scope: setAttribute() to "rowgroup" followed by getAttribute()
PASS th.scope: setAttribute() to "rowgroup" followed by IDL get
PASS th.scope: setAttribute() to "xrowgroup" followed by getAttribute()
-FAIL th.scope: setAttribute() to "xrowgroup" followed by IDL get assert_equals: expected "" but got "xrowgroup"
+PASS th.scope: setAttribute() to "xrowgroup" followed by IDL get
PASS th.scope: setAttribute() to "rowgroup\0" followed by getAttribute()
-FAIL th.scope: setAttribute() to "rowgroup\0" followed by IDL get assert_equals: expected "" but got "rowgroup\0"
+PASS th.scope: setAttribute() to "rowgroup\0" followed by IDL get
PASS th.scope: setAttribute() to "owgroup" followed by getAttribute()
-FAIL th.scope: setAttribute() to "owgroup" followed by IDL get assert_equals: expected "" but got "owgroup"
+PASS th.scope: setAttribute() to "owgroup" followed by IDL get
PASS th.scope: setAttribute() to "ROWGROUP" followed by getAttribute()
-FAIL th.scope: setAttribute() to "ROWGROUP" followed by IDL get assert_equals: expected "rowgroup" but got "ROWGROUP"
+PASS th.scope: setAttribute() to "ROWGROUP" followed by IDL get
PASS th.scope: setAttribute() to "colgroup" followed by getAttribute()
PASS th.scope: setAttribute() to "colgroup" followed by IDL get
PASS th.scope: setAttribute() to "xcolgroup" followed by getAttribute()
-FAIL th.scope: setAttribute() to "xcolgroup" followed by IDL get assert_equals: expected "" but got "xcolgroup"
+PASS th.scope: setAttribute() to "xcolgroup" followed by IDL get
PASS th.scope: setAttribute() to "colgroup\0" followed by getAttribute()
-FAIL th.scope: setAttribute() to "colgroup\0" followed by IDL get assert_equals: expected "" but got "colgroup\0"
+PASS th.scope: setAttribute() to "colgroup\0" followed by IDL get
PASS th.scope: setAttribute() to "olgroup" followed by getAttribute()
-FAIL th.scope: setAttribute() to "olgroup" followed by IDL get assert_equals: expected "" but got "olgroup"
+PASS th.scope: setAttribute() to "olgroup" followed by IDL get
PASS th.scope: setAttribute() to "COLGROUP" followed by getAttribute()
-FAIL th.scope: setAttribute() to "COLGROUP" followed by IDL get assert_equals: expected "colgroup" but got "COLGROUP"
+PASS th.scope: setAttribute() to "COLGROUP" followed by IDL get
PASS th.scope: IDL set to "" should not throw
PASS th.scope: IDL set to "" followed by getAttribute()
PASS th.scope: IDL set to "" followed by IDL get
PASS th.scope: IDL set to " \0\x01\x02\x03\x04\x05\x06\x07 \b\t\n\v\f\r\x0e\x0f \x10\x11\x12\x13\x14\x15\x16\x17 \x18\x19\x1a\x1b\x1c\x1d\x1e\x1f foo " should not throw
PASS th.scope: IDL set to " \0\x01\x02\x03\x04\x05\x06\x07 \b\t\n\v\f\r\x0e\x0f \x10\x11\x12\x13\x14\x15\x16\x17 \x18\x19\x1a\x1b\x1c\x1d\x1e\x1f foo " followed by getAttribute()
-FAIL th.scope: IDL set to " \0\x01\x02\x03\x04\x05\x06\x07 \b\t\n\v\f\r\x0e\x0f \x10\x11\x12\x13\x14\x15\x16\x17 \x18\x19\x1a\x1b\x1c\x1d\x1e\x1f foo " followed by IDL get assert_equals: expected "" but got " \0\x01\x02\x03\x04\x05\x06\x07 \b\t\n\v\f\r\x0e\x0f \x10\x11\x12\x13\x14\x15\x16\x17 \x18\x19\x1a\x1b\x1c\x1d\x1e\x1f foo "
+PASS th.scope: IDL set to " \0\x01\x02\x03\x04\x05\x06\x07 \b\t\n\v\f\r\x0e\x0f \x10\x11\x12\x13\x14\x15\x16\x17 \x18\x19\x1a\x1b\x1c\x1d\x1e\x1f foo " followed by IDL get
PASS th.scope: IDL set to undefined should not throw
PASS th.scope: IDL set to undefined followed by getAttribute()
-FAIL th.scope: IDL set to undefined followed by IDL get assert_equals: expected "" but got "undefined"
+PASS th.scope: IDL set to undefined followed by IDL get
PASS th.scope: IDL set to 7 should not throw
PASS th.scope: IDL set to 7 followed by getAttribute()
-FAIL th.scope: IDL set to 7 followed by IDL get assert_equals: expected "" but got "7"
+PASS th.scope: IDL set to 7 followed by IDL get
PASS th.scope: IDL set to 1.5 should not throw
PASS th.scope: IDL set to 1.5 followed by getAttribute()
-FAIL th.scope: IDL set to 1.5 followed by IDL get assert_equals: expected "" but got "1.5"
+PASS th.scope: IDL set to 1.5 followed by IDL get
PASS th.scope: IDL set to true should not throw
PASS th.scope: IDL set to true followed by getAttribute()
-FAIL th.scope: IDL set to true followed by IDL get assert_equals: expected "" but got "true"
+PASS th.scope: IDL set to true followed by IDL get
PASS th.scope: IDL set to false should not throw
PASS th.scope: IDL set to false followed by getAttribute()
-FAIL th.scope: IDL set to false followed by IDL get assert_equals: expected "" but got "false"
+PASS th.scope: IDL set to false followed by IDL get
PASS th.scope: IDL set to object "[object Object]" should not throw
PASS th.scope: IDL set to object "[object Object]" followed by getAttribute()
-FAIL th.scope: IDL set to object "[object Object]" followed by IDL get assert_equals: expected "" but got "[object Object]"
+PASS th.scope: IDL set to object "[object Object]" followed by IDL get
PASS th.scope: IDL set to NaN should not throw
PASS th.scope: IDL set to NaN followed by getAttribute()
-FAIL th.scope: IDL set to NaN followed by IDL get assert_equals: expected "" but got "NaN"
+PASS th.scope: IDL set to NaN followed by IDL get
PASS th.scope: IDL set to Infinity should not throw
PASS th.scope: IDL set to Infinity followed by getAttribute()
-FAIL th.scope: IDL set to Infinity followed by IDL get assert_equals: expected "" but got "Infinity"
+PASS th.scope: IDL set to Infinity followed by IDL get
PASS th.scope: IDL set to -Infinity should not throw
PASS th.scope: IDL set to -Infinity followed by getAttribute()
-FAIL th.scope: IDL set to -Infinity followed by IDL get assert_equals: expected "" but got "-Infinity"
+PASS th.scope: IDL set to -Infinity followed by IDL get
PASS th.scope: IDL set to "\0" should not throw
PASS th.scope: IDL set to "\0" followed by getAttribute()
-FAIL th.scope: IDL set to "\0" followed by IDL get assert_equals: expected "" but got "\0"
+PASS th.scope: IDL set to "\0" followed by IDL get
PASS th.scope: IDL set to null should not throw
-FAIL th.scope: IDL set to null followed by IDL get assert_equals: expected "" but got "null"
+PASS th.scope: IDL set to null followed by IDL get
PASS th.scope: IDL set to object "test-toString" should not throw
PASS th.scope: IDL set to object "test-toString" followed by getAttribute()
-FAIL th.scope: IDL set to object "test-toString" followed by IDL get assert_equals: expected "" but got "test-toString"
+PASS th.scope: IDL set to object "test-toString" followed by IDL get
PASS th.scope: IDL set to object "test-valueOf" should not throw
PASS th.scope: IDL set to object "test-valueOf" followed by getAttribute()
-FAIL th.scope: IDL set to object "test-valueOf" followed by IDL get assert_equals: expected "" but got "test-valueOf"
+PASS th.scope: IDL set to object "test-valueOf" followed by IDL get
PASS th.scope: IDL set to "row" should not throw
PASS th.scope: IDL set to "row" followed by getAttribute()
PASS th.scope: IDL set to "row" followed by IDL get
PASS th.scope: IDL set to "xrow" should not throw
PASS th.scope: IDL set to "xrow" followed by getAttribute()
-FAIL th.scope: IDL set to "xrow" followed by IDL get assert_equals: expected "" but got "xrow"
+PASS th.scope: IDL set to "xrow" followed by IDL get
PASS th.scope: IDL set to "row\0" should not throw
PASS th.scope: IDL set to "row\0" followed by getAttribute()
-FAIL th.scope: IDL set to "row\0" followed by IDL get assert_equals: expected "" but got "row\0"
+PASS th.scope: IDL set to "row\0" followed by IDL get
PASS th.scope: IDL set to "ow" should not throw
PASS th.scope: IDL set to "ow" followed by getAttribute()
-FAIL th.scope: IDL set to "ow" followed by IDL get assert_equals: expected "" but got "ow"
+PASS th.scope: IDL set to "ow" followed by IDL get
PASS th.scope: IDL set to "ROW" should not throw
PASS th.scope: IDL set to "ROW" followed by getAttribute()
-FAIL th.scope: IDL set to "ROW" followed by IDL get assert_equals: expected "row" but got "ROW"
+PASS th.scope: IDL set to "ROW" followed by IDL get
PASS th.scope: IDL set to "col" should not throw
PASS th.scope: IDL set to "col" followed by getAttribute()
PASS th.scope: IDL set to "col" followed by IDL get
PASS th.scope: IDL set to "xcol" should not throw
PASS th.scope: IDL set to "xcol" followed by getAttribute()
-FAIL th.scope: IDL set to "xcol" followed by IDL get assert_equals: expected "" but got "xcol"
+PASS th.scope: IDL set to "xcol" followed by IDL get
PASS th.scope: IDL set to "col\0" should not throw
PASS th.scope: IDL set to "col\0" followed by getAttribute()
-FAIL th.scope: IDL set to "col\0" followed by IDL get assert_equals: expected "" but got "col\0"
+PASS th.scope: IDL set to "col\0" followed by IDL get
PASS th.scope: IDL set to "ol" should not throw
PASS th.scope: IDL set to "ol" followed by getAttribute()
-FAIL th.scope: IDL set to "ol" followed by IDL get assert_equals: expected "" but got "ol"
+PASS th.scope: IDL set to "ol" followed by IDL get
PASS th.scope: IDL set to "COL" should not throw
PASS th.scope: IDL set to "COL" followed by getAttribute()
-FAIL th.scope: IDL set to "COL" followed by IDL get assert_equals: expected "col" but got "COL"
+PASS th.scope: IDL set to "COL" followed by IDL get
PASS th.scope: IDL set to "rowgroup" should not throw
PASS th.scope: IDL set to "rowgroup" followed by getAttribute()
PASS th.scope: IDL set to "rowgroup" followed by IDL get
PASS th.scope: IDL set to "xrowgroup" should not throw
PASS th.scope: IDL set to "xrowgroup" followed by getAttribute()
-FAIL th.scope: IDL set to "xrowgroup" followed by IDL get assert_equals: expected "" but got "xrowgroup"
+PASS th.scope: IDL set to "xrowgroup" followed by IDL get
PASS th.scope: IDL set to "rowgroup\0" should not throw
PASS th.scope: IDL set to "rowgroup\0" followed by getAttribute()
-FAIL th.scope: IDL set to "rowgroup\0" followed by IDL get assert_equals: expected "" but got "rowgroup\0"
+PASS th.scope: IDL set to "rowgroup\0" followed by IDL get
PASS th.scope: IDL set to "owgroup" should not throw
PASS th.scope: IDL set to "owgroup" followed by getAttribute()
-FAIL th.scope: IDL set to "owgroup" followed by IDL get assert_equals: expected "" but got "owgroup"
+PASS th.scope: IDL set to "owgroup" followed by IDL get
PASS th.scope: IDL set to "ROWGROUP" should not throw
PASS th.scope: IDL set to "ROWGROUP" followed by getAttribute()
-FAIL th.scope: IDL set to "ROWGROUP" followed by IDL get assert_equals: expected "rowgroup" but got "ROWGROUP"
+PASS th.scope: IDL set to "ROWGROUP" followed by IDL get
PASS th.scope: IDL set to "colgroup" should not throw
PASS th.scope: IDL set to "colgroup" followed by getAttribute()
PASS th.scope: IDL set to "colgroup" followed by IDL get
PASS th.scope: IDL set to "xcolgroup" should not throw
PASS th.scope: IDL set to "xcolgroup" followed by getAttribute()
-FAIL th.scope: IDL set to "xcolgroup" followed by IDL get assert_equals: expected "" but got "xcolgroup"
+PASS th.scope: IDL set to "xcolgroup" followed by IDL get
PASS th.scope: IDL set to "colgroup\0" should not throw
PASS th.scope: IDL set to "colgroup\0" followed by getAttribute()
-FAIL th.scope: IDL set to "colgroup\0" followed by IDL get assert_equals: expected "" but got "colgroup\0"
+PASS th.scope: IDL set to "colgroup\0" followed by IDL get
PASS th.scope: IDL set to "olgroup" should not throw
PASS th.scope: IDL set to "olgroup" followed by getAttribute()
-FAIL th.scope: IDL set to "olgroup" followed by IDL get assert_equals: expected "" but got "olgroup"
+PASS th.scope: IDL set to "olgroup" followed by IDL get
PASS th.scope: IDL set to "COLGROUP" should not throw
PASS th.scope: IDL set to "COLGROUP" followed by getAttribute()
-FAIL th.scope: IDL set to "COLGROUP" followed by IDL get assert_equals: expected "colgroup" but got "COLGROUP"
+PASS th.scope: IDL set to "COLGROUP" followed by IDL get
PASS th.abbr: typeof IDL attribute
PASS th.abbr: IDL get with DOM attribute unset
PASS th.abbr: setAttribute() to "" followed by getAttribute()
Modified: trunk/Source/WebCore/CMakeLists.txt (196792 => 196793)
--- trunk/Source/WebCore/CMakeLists.txt 2016-02-19 02:44:34 UTC (rev 196792)
+++ trunk/Source/WebCore/CMakeLists.txt 2016-02-19 02:45:50 UTC (rev 196793)
@@ -1729,6 +1729,7 @@
html/HTMLTableCellElement.cpp
html/HTMLTableColElement.cpp
html/HTMLTableElement.cpp
+ html/HTMLTableHeaderCellElement.cpp
html/HTMLTablePartElement.cpp
html/HTMLTableRowElement.cpp
html/HTMLTableRowsCollection.cpp
Modified: trunk/Source/WebCore/ChangeLog (196792 => 196793)
--- trunk/Source/WebCore/ChangeLog 2016-02-19 02:44:34 UTC (rev 196792)
+++ trunk/Source/WebCore/ChangeLog 2016-02-19 02:45:50 UTC (rev 196793)
@@ -1,3 +1,30 @@
+2016-02-18 Chris Dumez <[email protected]>
+
+ HTMLTableHeaderCellElement.scope should only return known values
+ https://bugs.webkit.org/show_bug.cgi?id=154423
+ <rdar://problem/24731018>
+
+ Reviewed by Ryosuke Niwa.
+
+ HTMLTableHeaderCellElement.scope should only return known values as per:
+ - https://html.spec.whatwg.org/multipage/tables.html#dom-th-scope
+
+ Known values are document here:
+ - https://html.spec.whatwg.org/multipage/tables.html#attr-th-scope
+
+ No new tests, already covered by existing test.
+
+ * CMakeLists.txt:
+ * WebCore.vcxproj/WebCore.vcxproj:
+ * WebCore.vcxproj/WebCore.vcxproj.filters:
+ * WebCore.xcodeproj/project.pbxproj:
+ * html/HTMLElementsAllInOne.cpp:
+ * html/HTMLTableHeaderCellElement.cpp: Copied from Source/WebCore/html/HTMLTableHeaderCellElement.h.
+ (WebCore::HTMLTableHeaderCellElement::scope):
+ (WebCore::HTMLTableHeaderCellElement::setScope):
+ * html/HTMLTableHeaderCellElement.h:
+ * html/HTMLTableHeaderCellElement.idl:
+
2016-02-18 Brent Fulgham <[email protected]>
Extend HashCountedSet with a method to efficiently set the count of an entry
Modified: trunk/Source/WebCore/WebCore.vcxproj/WebCore.vcxproj (196792 => 196793)
--- trunk/Source/WebCore/WebCore.vcxproj/WebCore.vcxproj 2016-02-19 02:44:34 UTC (rev 196792)
+++ trunk/Source/WebCore/WebCore.vcxproj/WebCore.vcxproj 2016-02-19 02:45:50 UTC (rev 196793)
@@ -17329,6 +17329,20 @@
<ExcludedFromBuild Condition="'$(Configuration)|$(Platform)'=='Production|Win32'">true</ExcludedFromBuild>
<ExcludedFromBuild Condition="'$(Configuration)|$(Platform)'=='Production|x64'">true</ExcludedFromBuild>
</ClCompile>
+ <ClCompile Include="..\html\HTMLTableHeaderCellElement.cpp">
+ <ExcludedFromBuild Condition="'$(Configuration)|$(Platform)'=='Debug|Win32'">true</ExcludedFromBuild>
+ <ExcludedFromBuild Condition="'$(Configuration)|$(Platform)'=='Debug|x64'">true</ExcludedFromBuild>
+ <ExcludedFromBuild Condition="'$(Configuration)|$(Platform)'=='Debug_WinCairo|Win32'">true</ExcludedFromBuild>
+ <ExcludedFromBuild Condition="'$(Configuration)|$(Platform)'=='Debug_WinCairo|x64'">true</ExcludedFromBuild>
+ <ExcludedFromBuild Condition="'$(Configuration)|$(Platform)'=='DebugSuffix|Win32'">true</ExcludedFromBuild>
+ <ExcludedFromBuild Condition="'$(Configuration)|$(Platform)'=='DebugSuffix|x64'">true</ExcludedFromBuild>
+ <ExcludedFromBuild Condition="'$(Configuration)|$(Platform)'=='Release|Win32'">true</ExcludedFromBuild>
+ <ExcludedFromBuild Condition="'$(Configuration)|$(Platform)'=='Release|x64'">true</ExcludedFromBuild>
+ <ExcludedFromBuild Condition="'$(Configuration)|$(Platform)'=='Release_WinCairo|Win32'">true</ExcludedFromBuild>
+ <ExcludedFromBuild Condition="'$(Configuration)|$(Platform)'=='Release_WinCairo|x64'">true</ExcludedFromBuild>
+ <ExcludedFromBuild Condition="'$(Configuration)|$(Platform)'=='Production|Win32'">true</ExcludedFromBuild>
+ <ExcludedFromBuild Condition="'$(Configuration)|$(Platform)'=='Production|x64'">true</ExcludedFromBuild>
+ </ClCompile>
<ClCompile Include="..\html\HTMLTablePartElement.cpp">
<ExcludedFromBuild Condition="'$(Configuration)|$(Platform)'=='Debug|Win32'">true</ExcludedFromBuild>
<ExcludedFromBuild Condition="'$(Configuration)|$(Platform)'=='Debug|x64'">true</ExcludedFromBuild>
Modified: trunk/Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters (196792 => 196793)
--- trunk/Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters 2016-02-19 02:44:34 UTC (rev 196792)
+++ trunk/Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters 2016-02-19 02:45:50 UTC (rev 196793)
@@ -3926,6 +3926,9 @@
<ClCompile Include="..\html\HTMLTableElement.cpp">
<Filter>html</Filter>
</ClCompile>
+ <ClCompile Include="..\html\HTMLTableHeaderCellElement.cpp">
+ <Filter>html</Filter>
+ </ClCompile>
<ClCompile Include="..\html\HTMLTablePartElement.cpp">
<Filter>html</Filter>
</ClCompile>
Modified: trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj (196792 => 196793)
--- trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj 2016-02-19 02:44:34 UTC (rev 196792)
+++ trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj 2016-02-19 02:45:50 UTC (rev 196793)
@@ -1719,6 +1719,7 @@
46C83EFE1A9BBE2900A79A41 /* GeoNotifier.h in Headers */ = {isa = PBXBuildFile; fileRef = 46C83EFC1A9BBE2900A79A41 /* GeoNotifier.h */; settings = {ATTRIBUTES = (Private, ); }; };
46DB7D571B20FE46005651B2 /* VNodeTrackerCocoa.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 46DB7D561B20FE3C005651B2 /* VNodeTrackerCocoa.cpp */; };
46DBB6501AB8C96F00D9A813 /* PowerObserverMac.h in Headers */ = {isa = PBXBuildFile; fileRef = 46DBB64E1AB8C96F00D9A813 /* PowerObserverMac.h */; };
+ 46DCFDC01C768A150025B868 /* HTMLTableHeaderCellElement.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 46DCFDBF1C768A150025B868 /* HTMLTableHeaderCellElement.cpp */; };
46EBEA021B7D4D6500BE4941 /* CollectionTraversal.h in Headers */ = {isa = PBXBuildFile; fileRef = 46EBEA011B7D4D5D00BE4941 /* CollectionTraversal.h */; };
46F3E3F91B2109000087ED13 /* VNodeTracker.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 46DB7D581B20FE58005651B2 /* VNodeTracker.cpp */; };
46F3E3FA1B2109100087ED13 /* VNodeTracker.h in Headers */ = {isa = PBXBuildFile; fileRef = 46DB7D591B20FE58005651B2 /* VNodeTracker.h */; settings = {ATTRIBUTES = (Private, ); }; };
@@ -9232,6 +9233,7 @@
46DB7D581B20FE58005651B2 /* VNodeTracker.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = VNodeTracker.cpp; sourceTree = "<group>"; };
46DB7D591B20FE58005651B2 /* VNodeTracker.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = VNodeTracker.h; sourceTree = "<group>"; };
46DBB64E1AB8C96F00D9A813 /* PowerObserverMac.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = PowerObserverMac.h; sourceTree = "<group>"; };
+ 46DCFDBF1C768A150025B868 /* HTMLTableHeaderCellElement.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = HTMLTableHeaderCellElement.cpp; sourceTree = "<group>"; };
46EBEA011B7D4D5D00BE4941 /* CollectionTraversal.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = CollectionTraversal.h; sourceTree = "<group>"; };
46F2768E1B85297F005C2556 /* JSDOMNamedFlowCollectionCustom.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = JSDOMNamedFlowCollectionCustom.cpp; sourceTree = "<group>"; };
490707E41219C04300D90E51 /* ANGLEWebKitBridge.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = ANGLEWebKitBridge.cpp; sourceTree = "<group>"; };
@@ -19316,6 +19318,7 @@
A871DB1A0A150BD600B12A68 /* HTMLTableElement.cpp */,
A871DB190A150BD600B12A68 /* HTMLTableElement.h */,
8555425A0AA48B1E00BA89F2 /* HTMLTableElement.idl */,
+ 46DCFDBF1C768A150025B868 /* HTMLTableHeaderCellElement.cpp */,
836BAD1F1BD1CA670037356A /* HTMLTableHeaderCellElement.h */,
83FE5F1F1BD1C55E0038BEEC /* HTMLTableHeaderCellElement.idl */,
A871DB1F0A150BD600B12A68 /* HTMLTablePartElement.cpp */,
@@ -29432,6 +29435,7 @@
85ECBEEC0AA7626900544F0B /* DOMHTMLAreaElement.mm in Sources */,
859A9C480AA5E3BD00B694B2 /* DOMHTMLBaseElement.mm in Sources */,
85ECBEEE0AA7626900544F0B /* DOMHTMLBaseFontElement.mm in Sources */,
+ 46DCFDC01C768A150025B868 /* HTMLTableHeaderCellElement.cpp in Sources */,
859A9C4A0AA5E3BD00B694B2 /* DOMHTMLBodyElement.mm in Sources */,
85183B430AA6926100F19FA3 /* DOMHTMLBRElement.mm in Sources */,
85BA4CDE0AA6861B0088052D /* DOMHTMLButtonElement.mm in Sources */,
Modified: trunk/Source/WebCore/html/HTMLElementsAllInOne.cpp (196792 => 196793)
--- trunk/Source/WebCore/html/HTMLElementsAllInOne.cpp 2016-02-19 02:44:34 UTC (rev 196792)
+++ trunk/Source/WebCore/html/HTMLElementsAllInOne.cpp 2016-02-19 02:45:50 UTC (rev 196793)
@@ -103,6 +103,7 @@
#include "HTMLTableCellElement.cpp"
#include "HTMLTableColElement.cpp"
#include "HTMLTableElement.cpp"
+#include "HTMLTableHeaderCellElement.cpp"
#include "HTMLTablePartElement.cpp"
#include "HTMLTableRowElement.cpp"
#include "HTMLTableSectionElement.cpp"
Copied: trunk/Source/WebCore/html/HTMLTableHeaderCellElement.cpp (from rev 196792, trunk/Source/WebCore/html/HTMLTableHeaderCellElement.h) (0 => 196793)
--- trunk/Source/WebCore/html/HTMLTableHeaderCellElement.cpp (rev 0)
+++ trunk/Source/WebCore/html/HTMLTableHeaderCellElement.cpp 2016-02-19 02:45:50 UTC (rev 196793)
@@ -0,0 +1,59 @@
+/*
+ * Copyright (C) 2016 Apple Inc. All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ * 1. Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ * notice, this list of conditions and the following disclaimer in the
+ * documentation and/or other materials provided with the distribution.
+ *
+ * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS''
+ * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
+ * THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
+ * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS
+ * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
+ * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
+ * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
+ * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
+ * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
+ * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF
+ * THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+#include "config.h"
+#include "HTMLTableHeaderCellElement.h"
+
+#include "HTMLNames.h"
+#include <wtf/text/AtomicString.h>
+
+namespace WebCore {
+
+const AtomicString& HTMLTableHeaderCellElement::scope() const
+{
+ // https://html.spec.whatwg.org/multipage/tables.html#attr-th-scope
+ static NeverDestroyed<const AtomicString> row("row", AtomicString::ConstructFromLiteral);
+ static NeverDestroyed<const AtomicString> col("col", AtomicString::ConstructFromLiteral);
+ static NeverDestroyed<const AtomicString> rowgroup("rowgroup", AtomicString::ConstructFromLiteral);
+ static NeverDestroyed<const AtomicString> colgroup("colgroup", AtomicString::ConstructFromLiteral);
+
+ const AtomicString& value = fastGetAttribute(HTMLNames::scopeAttr);
+ if (equalIgnoringASCIICase(value, row))
+ return row;
+ if (equalIgnoringASCIICase(value, col))
+ return col;
+ if (equalIgnoringASCIICase(value, rowgroup))
+ return rowgroup;
+ if (equalIgnoringASCIICase(value, colgroup))
+ return colgroup;
+ return emptyAtom;
+}
+
+void HTMLTableHeaderCellElement::setScope(const AtomicString& scope)
+{
+ setAttributeWithoutSynchronization(HTMLNames::scopeAttr, scope);
+}
+
+} // namespace WebCore
Modified: trunk/Source/WebCore/html/HTMLTableHeaderCellElement.h (196792 => 196793)
--- trunk/Source/WebCore/html/HTMLTableHeaderCellElement.h 2016-02-19 02:44:34 UTC (rev 196792)
+++ trunk/Source/WebCore/html/HTMLTableHeaderCellElement.h 2016-02-19 02:45:50 UTC (rev 196793)
@@ -44,6 +44,9 @@
return adoptRef(*new HTMLTableHeaderCellElement(tagName, document));
}
+ const AtomicString& scope() const;
+ void setScope(const AtomicString&);
+
private:
using HTMLTableCellElement::HTMLTableCellElement;
};
Modified: trunk/Source/WebCore/html/HTMLTableHeaderCellElement.idl (196792 => 196793)
--- trunk/Source/WebCore/html/HTMLTableHeaderCellElement.idl 2016-02-19 02:44:34 UTC (rev 196792)
+++ trunk/Source/WebCore/html/HTMLTableHeaderCellElement.idl 2016-02-19 02:45:50 UTC (rev 196793)
@@ -25,5 +25,5 @@
interface HTMLTableHeaderCellElement : HTMLTableCellElement {
[Reflect] attribute DOMString abbr;
- [Reflect] attribute DOMString scope;
+ attribute DOMString scope;
};
