Title: [196905] releases/WebKitGTK/webkit-2.10/Source/WebCore
Revision
196905
Author
[email protected]
Date
2016-02-22 01:00:12 -0800 (Mon, 22 Feb 2016)

Log Message

Merge r196039 - WEBGL_debug_shaders should be disabled for OpenGLES backend also
https://bugs.webkit.org/show_bug.cgi?id=153788

Reviewed by Darin Adler.

WEBGL_debug_shaders extension is disabled for OpenGL backed platform
because the implementation is not fully compliant to the spec yet.
Because this is not an OpenGL-specific problem, WEBGL_debug_shaders extension
should be disabled for OpenGLES backed platforms also.

No new tests, already covered by existing tests.

* platform/graphics/opengl/Extensions3DOpenGL.cpp:
(WebCore::Extensions3DOpenGL::supportsExtension): Deleted.
* platform/graphics/opengl/Extensions3DOpenGLCommon.cpp:
(WebCore::Extensions3DOpenGLCommon::supports):

Modified Paths

Diff

Modified: releases/WebKitGTK/webkit-2.10/Source/WebCore/ChangeLog (196904 => 196905)


--- releases/WebKitGTK/webkit-2.10/Source/WebCore/ChangeLog	2016-02-22 08:55:27 UTC (rev 196904)
+++ releases/WebKitGTK/webkit-2.10/Source/WebCore/ChangeLog	2016-02-22 09:00:12 UTC (rev 196905)
@@ -1,3 +1,22 @@
+2016-02-02  Jinyoung Hur  <[email protected]>
+
+        WEBGL_debug_shaders should be disabled for OpenGLES backend also
+        https://bugs.webkit.org/show_bug.cgi?id=153788
+
+        Reviewed by Darin Adler.
+
+        WEBGL_debug_shaders extension is disabled for OpenGL backed platform
+        because the implementation is not fully compliant to the spec yet.
+        Because this is not an OpenGL-specific problem, WEBGL_debug_shaders extension
+        should be disabled for OpenGLES backed platforms also.
+
+        No new tests, already covered by existing tests.
+
+        * platform/graphics/opengl/Extensions3DOpenGL.cpp:
+        (WebCore::Extensions3DOpenGL::supportsExtension): Deleted.
+        * platform/graphics/opengl/Extensions3DOpenGLCommon.cpp:
+        (WebCore::Extensions3DOpenGLCommon::supports):
+
 2016-02-01  Jer Noble  <[email protected]>
 
         REGRESSION(r195770): Use-after-free in ResourceLoaderOptions::cachingPolicy

Modified: releases/WebKitGTK/webkit-2.10/Source/WebCore/platform/graphics/opengl/Extensions3DOpenGLCommon.cpp (196904 => 196905)


--- releases/WebKitGTK/webkit-2.10/Source/WebCore/platform/graphics/opengl/Extensions3DOpenGLCommon.cpp	2016-02-22 08:55:27 UTC (rev 196904)
+++ releases/WebKitGTK/webkit-2.10/Source/WebCore/platform/graphics/opengl/Extensions3DOpenGLCommon.cpp	2016-02-22 09:00:12 UTC (rev 196905)
@@ -103,6 +103,12 @@
     if (!m_initializedAvailableExtensions)
         initializeAvailableExtensions();
 
+    // We explicitly do not support this extension until
+    // we fix the following bug:
+    // https://bugs.webkit.org/show_bug.cgi?id=149734
+    if (name == "GL_ANGLE_translated_shader_source")
+        return false;
+
     return supportsExtension(name);
 }
 
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to