Title: [196918] releases/WebKitGTK/webkit-2.10/Source/WebKit2
- Revision
- 196918
- Author
- [email protected]
- Date
- 2016-02-22 01:31:43 -0800 (Mon, 22 Feb 2016)
Log Message
Merge r196264 - Infinite loop when processing mouse events synchronously
https://bugs.webkit.org/show_bug.cgi?id=153995
Reviewed by Darin Adler.
This happened with WTR in the GTK+ port after landing patch in bug
to be synchronous. When a drag and drop operation is in progress,
the web process ignores mouse move events and replies with
DidReceiveEvent signal. The DidReceiveEvent message handler in
WebPageProxy checks if we have a m_nextMouseMoveEvent and handles
it, but when all this happens synchronously the
m_nextMouseMoveEvent is the current one because we haven't
returned yet from handleMouseEvent(). We need to invalidate the
m_nextMouseMoveEvent before calling handleMouseEvent().
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didReceiveEvent):
Modified Paths
Diff
Modified: releases/WebKitGTK/webkit-2.10/Source/WebKit2/ChangeLog (196917 => 196918)
--- releases/WebKitGTK/webkit-2.10/Source/WebKit2/ChangeLog 2016-02-22 09:30:51 UTC (rev 196917)
+++ releases/WebKitGTK/webkit-2.10/Source/WebKit2/ChangeLog 2016-02-22 09:31:43 UTC (rev 196918)
@@ -1,3 +1,24 @@
+2016-02-08 Carlos Garcia Campos <[email protected]>
+
+ Infinite loop when processing mouse events synchronously
+ https://bugs.webkit.org/show_bug.cgi?id=153995
+
+ Reviewed by Darin Adler.
+
+ This happened with WTR in the GTK+ port after landing patch in bug
+ #153740. The thing is that WTR forces events handling IPC messages
+ to be synchronous. When a drag and drop operation is in progress,
+ the web process ignores mouse move events and replies with
+ DidReceiveEvent signal. The DidReceiveEvent message handler in
+ WebPageProxy checks if we have a m_nextMouseMoveEvent and handles
+ it, but when all this happens synchronously the
+ m_nextMouseMoveEvent is the current one because we haven't
+ returned yet from handleMouseEvent(). We need to invalidate the
+ m_nextMouseMoveEvent before calling handleMouseEvent().
+
+ * UIProcess/WebPageProxy.cpp:
+ (WebKit::WebPageProxy::didReceiveEvent):
+
2016-02-08 Danilo Cesar Lemes de Paula <[email protected]>
[GTK] Fix crash when creating webview with g_object_new
Modified: releases/WebKitGTK/webkit-2.10/Source/WebKit2/UIProcess/WebPageProxy.cpp (196917 => 196918)
--- releases/WebKitGTK/webkit-2.10/Source/WebKit2/UIProcess/WebPageProxy.cpp 2016-02-22 09:30:51 UTC (rev 196917)
+++ releases/WebKitGTK/webkit-2.10/Source/WebKit2/UIProcess/WebPageProxy.cpp 2016-02-22 09:31:43 UTC (rev 196918)
@@ -4628,10 +4628,8 @@
break;
case WebEvent::MouseMove:
m_processingMouseMoveEvent = false;
- if (m_nextMouseMoveEvent) {
- handleMouseEvent(*m_nextMouseMoveEvent);
- m_nextMouseMoveEvent = nullptr;
- }
+ if (m_nextMouseMoveEvent)
+ handleMouseEvent(*std::exchange(m_nextMouseMoveEvent, nullptr));
break;
case WebEvent::MouseDown:
break;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes