Title: [197095] releases/WebKitGTK/webkit-2.12
Revision
197095
Author
carlo...@webkit.org
Date
2016-02-25 03:40:45 -0800 (Thu, 25 Feb 2016)

Log Message

Revert "Merge r196948 - [JSC shell] Don't put empty arguments array to VM."

This reverts commit 634b8dad527aaab26af7e3baaea9d1289b443b37.

Modified Paths

Diff

Modified: releases/WebKitGTK/webkit-2.12/LayoutTests/ChangeLog (197094 => 197095)


--- releases/WebKitGTK/webkit-2.12/LayoutTests/ChangeLog	2016-02-25 11:08:42 UTC (rev 197094)
+++ releases/WebKitGTK/webkit-2.12/LayoutTests/ChangeLog	2016-02-25 11:40:45 UTC (rev 197095)
@@ -1,16 +1,3 @@
-2016-02-22  Konstantin Tokarev  <annu...@yandex.ru>
-
-        [JSC shell] Don't put empty arguments array to VM.
-        https://bugs.webkit.org/show_bug.cgi?id=154516
-
-        Reviewed by Geoffrey Garen.
-
-        This allows arrowfunction-lexical-bind-arguments-top-level test to pass
-        in jsc as well as in browser.
-
-        * js/script-tests/arrowfunction-lexical-bind-arguments-top-level.js:
-        Removed @ skip annotation.
-
 2016-02-21  Chris Dumez  <cdu...@apple.com>
 
         iframe/frame/object.contentDocument should be on the prototype

Modified: releases/WebKitGTK/webkit-2.12/LayoutTests/js/script-tests/arrowfunction-lexical-bind-arguments-top-level.js (197094 => 197095)


--- releases/WebKitGTK/webkit-2.12/LayoutTests/js/script-tests/arrowfunction-lexical-bind-arguments-top-level.js	2016-02-25 11:08:42 UTC (rev 197094)
+++ releases/WebKitGTK/webkit-2.12/LayoutTests/js/script-tests/arrowfunction-lexical-bind-arguments-top-level.js	2016-02-25 11:40:45 UTC (rev 197095)
@@ -1,3 +1,7 @@
+// jsc always has arguments, but in browser we do not have arguments, so
+// ignore this test in run-jsc-stress-tests, but run in run-webkit-tests.
+//@ skip
+
 description('Tests for ES6 arrow function lexical bind of arguments on top level');
 
 let foo = () => arguments;

Modified: releases/WebKitGTK/webkit-2.12/Source/_javascript_Core/ChangeLog (197094 => 197095)


--- releases/WebKitGTK/webkit-2.12/Source/_javascript_Core/ChangeLog	2016-02-25 11:08:42 UTC (rev 197094)
+++ releases/WebKitGTK/webkit-2.12/Source/_javascript_Core/ChangeLog	2016-02-25 11:40:45 UTC (rev 197095)
@@ -1,16 +1,3 @@
-2016-02-22  Konstantin Tokarev  <annu...@yandex.ru>
-
-        [JSC shell] Don't put empty arguments array to VM.
-        https://bugs.webkit.org/show_bug.cgi?id=154516
-
-        Reviewed by Geoffrey Garen.
-
-        This allows arrowfunction-lexical-bind-arguments-top-level test to pass
-        in jsc as well as in browser.
-
-        * jsc.cpp:
-        (GlobalObject::finishCreation):
-
 2016-02-21  Joseph Pecoraro  <pecor...@apple.com>
 
         CodeBlock always visits its unlinked code twice

Modified: releases/WebKitGTK/webkit-2.12/Source/_javascript_Core/jsc.cpp (197094 => 197095)


--- releases/WebKitGTK/webkit-2.12/Source/_javascript_Core/jsc.cpp	2016-02-25 11:08:42 UTC (rev 197094)
+++ releases/WebKitGTK/webkit-2.12/Source/_javascript_Core/jsc.cpp	2016-02-25 11:40:45 UTC (rev 197095)
@@ -752,13 +752,11 @@
         addFunction(vm, "samplingProfilerStackTraces", functionSamplingProfilerStackTraces, 0);
 #endif
 
-        if (!arguments.isEmpty()) {
-            JSArray* array = constructEmptyArray(globalExec(), 0);
-            for (size_t i = 0; i < arguments.size(); ++i)
-                array->putDirectIndex(globalExec(), i, jsString(globalExec(), arguments[i]));
-            putDirect(vm, Identifier::fromString(globalExec(), "arguments"), array);
-        }
-
+        JSArray* array = constructEmptyArray(globalExec(), 0);
+        for (size_t i = 0; i < arguments.size(); ++i)
+            array->putDirectIndex(globalExec(), i, jsString(globalExec(), arguments[i]));
+        putDirect(vm, Identifier::fromString(globalExec(), "arguments"), array);
+        
         putDirect(vm, Identifier::fromString(globalExec(), "console"), jsUndefined());
     }
 
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to