Log Message
Don't clear the weak JSString cache on memory pressure. <https://webkit.org/b/154693>
Reviewed by Antti Koivisto. This was stupid. The cache is a WeakGCMap, so all the JSStrings pointed to are still alive anyway. This way we keep the ability to deduplicate common strings. * platform/MemoryPressureHandler.cpp: (WebCore::MemoryPressureHandler::releaseNoncriticalMemory): Deleted.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (197140 => 197141)
--- trunk/Source/WebCore/ChangeLog 2016-02-25 23:24:28 UTC (rev 197140)
+++ trunk/Source/WebCore/ChangeLog 2016-02-25 23:24:41 UTC (rev 197141)
@@ -1,3 +1,16 @@
+2016-02-25 Andreas Kling <[email protected]>
+
+ Don't clear the weak JSString cache on memory pressure.
+ <https://webkit.org/b/154693>
+
+ Reviewed by Antti Koivisto.
+
+ This was stupid. The cache is a WeakGCMap, so all the JSStrings pointed to are
+ still alive anyway. This way we keep the ability to deduplicate common strings.
+
+ * platform/MemoryPressureHandler.cpp:
+ (WebCore::MemoryPressureHandler::releaseNoncriticalMemory): Deleted.
+
2016-02-25 Chris Dumez <[email protected]>
Drop [TreatReturnedNullStringAs=Undefined] WebKit-specific IDL attribute
Modified: trunk/Source/WebCore/platform/MemoryPressureHandler.cpp (197140 => 197141)
--- trunk/Source/WebCore/platform/MemoryPressureHandler.cpp 2016-02-25 23:24:28 UTC (rev 197140)
+++ trunk/Source/WebCore/platform/MemoryPressureHandler.cpp 2016-02-25 23:24:41 UTC (rev 197141)
@@ -96,11 +96,6 @@
}
{
- ReliefLogger log("Clearing JS string cache");
- JSDOMWindow::commonVM().stringCache.clear();
- }
-
- {
ReliefLogger log("Prune MemoryCache dead resources");
MemoryCache::singleton().pruneDeadResourcesToSize(0);
}
_______________________________________________ webkit-changes mailing list [email protected] https://lists.webkit.org/mailman/listinfo/webkit-changes
