Title: [197149] trunk/Source/WebCore
Revision
197149
Author
[email protected]
Date
2016-02-25 17:00:24 -0800 (Thu, 25 Feb 2016)

Log Message

Change ASSERT to RELEASE_ASSERT in SOFT_LINK_CLASS() macro

Follow-up fix noted by Andy Estes for:

    [Cocoa] Always check the return value of dlopen() and dlsym() in Release builds
    <http://webkit.org/b/154364>

* platform/mac/SoftLinking.h:
(SOFT_LINK_CLASS): Change ASSERT to RELEASE_ASSERT to check the
return value of objc_getClass().  This matches what we do for
SOFT_LINK_CLASS_FOR_SOURCE().

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (197148 => 197149)


--- trunk/Source/WebCore/ChangeLog	2016-02-26 00:58:11 UTC (rev 197148)
+++ trunk/Source/WebCore/ChangeLog	2016-02-26 01:00:24 UTC (rev 197149)
@@ -1,3 +1,17 @@
+2016-02-25  David Kilzer  <[email protected]>
+
+        Change ASSERT to RELEASE_ASSERT in SOFT_LINK_CLASS() macro
+
+        Follow-up fix noted by Andy Estes for:
+
+            [Cocoa] Always check the return value of dlopen() and dlsym() in Release builds
+            <http://webkit.org/b/154364>
+
+        * platform/mac/SoftLinking.h:
+        (SOFT_LINK_CLASS): Change ASSERT to RELEASE_ASSERT to check the
+        return value of objc_getClass().  This matches what we do for
+        SOFT_LINK_CLASS_FOR_SOURCE().
+
 2016-02-25  Daniel Bates  <[email protected]>
 
         CSP: Remove SecurityPolicy script interface

Modified: trunk/Source/WebCore/platform/mac/SoftLinking.h (197148 => 197149)


--- trunk/Source/WebCore/platform/mac/SoftLinking.h	2016-02-26 00:58:11 UTC (rev 197148)
+++ trunk/Source/WebCore/platform/mac/SoftLinking.h	2016-02-26 01:00:24 UTC (rev 197149)
@@ -174,7 +174,7 @@
     { \
         framework##Library(); \
         class##className = objc_getClass(#className); \
-        ASSERT(class##className); \
+        RELEASE_ASSERT(class##className); \
         get##className##Class = className##Function; \
         return class##className; \
     } \
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to