Title: [197232] trunk/PerformanceTests
Revision
197232
Author
[email protected]
Date
2016-02-26 20:43:57 -0800 (Fri, 26 Feb 2016)

Log Message

Address Dean's comments in 154673.

* Animometer/developer.html:
* Animometer/resources/debug-runner/animometer.js:
* Animometer/resources/debug-runner/graph.js:

Modified Paths

Diff

Modified: trunk/PerformanceTests/Animometer/developer.html (197231 => 197232)


--- trunk/PerformanceTests/Animometer/developer.html	2016-02-27 04:39:05 UTC (rev 197231)
+++ trunk/PerformanceTests/Animometer/developer.html	2016-02-27 04:43:57 UTC (rev 197232)
@@ -13,7 +13,7 @@
     <script src=""
     <script src="" charset="utf-8"></script>
     <script src=""
-    <script src=""
+    <script src="" charset="utf-8"></script>
 
     <script src=""
     <script src=""

Modified: trunk/PerformanceTests/Animometer/resources/debug-runner/animometer.js (197231 => 197232)


--- trunk/PerformanceTests/Animometer/resources/debug-runner/animometer.js	2016-02-27 04:39:05 UTC (rev 197231)
+++ trunk/PerformanceTests/Animometer/resources/debug-runner/animometer.js	2016-02-27 04:43:57 UTC (rev 197232)
@@ -28,7 +28,7 @@
     _addGraphButton: function(td, testName, testResult, testData)
     {
         var button = Utilities.createElement("button", { class: "small-button" }, td);
-        button.textContent = Strings.text.graph + "...";
+        button.textContent = Strings.text.graph + "…";
         button.testName = testName;
         button.testResult = testResult;
         button.testData = testData;
@@ -495,9 +495,9 @@
         }
 
         var dashboard = benchmarkRunnerClient.results;
-        if (dashboard.options["adjustment"] == "ramp") {
+        if (dashboard.options["adjustment"] == "ramp")
             Headers.details[3].disabled = true;
-        } else {
+        else {
             Headers.details[1].disabled = true;
             Headers.details[4].disabled = true;
         }

Modified: trunk/PerformanceTests/Animometer/resources/debug-runner/graph.js (197231 => 197232)


--- trunk/PerformanceTests/Animometer/resources/debug-runner/graph.js	2016-02-27 04:39:05 UTC (rev 197231)
+++ trunk/PerformanceTests/Animometer/resources/debug-runner/graph.js	2016-02-27 04:43:57 UTC (rev 197232)
@@ -5,9 +5,9 @@
     {
         var element = document.getElementById("test-graph-data");
         element.innerHTML = "";
-        element.testResult = testResult;
-        element.testData = testData;
-        element.options = options;
+        element._testResult = testResult;
+        element._testData = testData;
+        element._options = options;
         document.querySelector("hr").style.width = this.layoutCounter++ + "px";
 
         var margins = new Insets(30, 30, 30, 40);
@@ -561,7 +561,7 @@
 
     onGraphTypeChanged: function() {
         var form = document.forms["graph-type"].elements;
-        var testResult = document.getElementById("test-graph-data").testResult;
+        var testResult = document.getElementById("test-graph-data")._testResult;
         var isTimeSelected = form["graph-type"].value == "time";
 
         benchmarkController._showOrHideNodes(isTimeSelected, "#time-graph");

Modified: trunk/PerformanceTests/ChangeLog (197231 => 197232)


--- trunk/PerformanceTests/ChangeLog	2016-02-27 04:39:05 UTC (rev 197231)
+++ trunk/PerformanceTests/ChangeLog	2016-02-27 04:43:57 UTC (rev 197232)
@@ -1,3 +1,11 @@
+2016-02-26  Jon Lee  <[email protected]>
+
+        Address Dean's comments in 154673.
+
+        * Animometer/developer.html:
+        * Animometer/resources/debug-runner/animometer.js:
+        * Animometer/resources/debug-runner/graph.js:
+
 2016-02-25  Jon Lee  <[email protected]>
 
         Update animation benchmark and tests
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to