Title: [197235] trunk/Source/WebInspectorUI
- Revision
- 197235
- Author
- [email protected]
- Date
- 2016-02-26 21:40:51 -0800 (Fri, 26 Feb 2016)
Log Message
Web Inspector: Custom transition bezier curve editor preview should loop when not editing curve
https://bugs.webkit.org/show_bug.cgi?id=154738
<rdar://problem/24861563>
Patch by Devin Rousso <[email protected]> on 2016-02-26
Reviewed by Timothy Hatcher.
Added extra frames to bezier preview animation to allow it to infinitely
repeat without being jarring to watch.
* UserInterface/Views/BezierEditor.css:
(.bezier-editor > .bezier-preview-timing.animate):
(@keyframes bezierPreview):
* UserInterface/Views/BezierEditor.js:
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (197234 => 197235)
--- trunk/Source/WebInspectorUI/ChangeLog 2016-02-27 05:11:09 UTC (rev 197234)
+++ trunk/Source/WebInspectorUI/ChangeLog 2016-02-27 05:40:51 UTC (rev 197235)
@@ -1,5 +1,21 @@
2016-02-26 Devin Rousso <[email protected]>
+ Web Inspector: Custom transition bezier curve editor preview should loop when not editing curve
+ https://bugs.webkit.org/show_bug.cgi?id=154738
+ <rdar://problem/24861563>
+
+ Reviewed by Timothy Hatcher.
+
+ Added extra frames to bezier preview animation to allow it to infinitely
+ repeat without being jarring to watch.
+
+ * UserInterface/Views/BezierEditor.css:
+ (.bezier-editor > .bezier-preview-timing.animate):
+ (@keyframes bezierPreview):
+ * UserInterface/Views/BezierEditor.js:
+
+2016-02-26 Devin Rousso <[email protected]>
+
Web Inspector: Keyboard controls to nudge control points in custom transition bezier curve editor would be nice
https://bugs.webkit.org/show_bug.cgi?id=154739
<rdar://problem/24861498>
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/BezierEditor.css (197234 => 197235)
--- trunk/Source/WebInspectorUI/UserInterface/Views/BezierEditor.css 2016-02-27 05:11:09 UTC (rev 197234)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/BezierEditor.css 2016-02-27 05:40:51 UTC (rev 197235)
@@ -52,11 +52,13 @@
}
.bezier-editor > .bezier-preview-timing.animate {
- animation: bezierPreview 2s linear 250ms forwards;
+ animation: bezierPreview 2.5s linear 250ms infinite;
}
@keyframes bezierPreview {
from { transform: translate(0, 0); }
+ 10% { transform: translate(0, 0); }
+ 90% { transform: translate(170px, 0); }
to { transform: translate(170px, 0); }
}
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/BezierEditor.js (197234 => 197235)
--- trunk/Source/WebInspectorUI/UserInterface/Views/BezierEditor.js 2016-02-27 05:11:09 UTC (rev 197234)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/BezierEditor.js 2016-02-27 05:40:51 UTC (rev 197235)
@@ -38,7 +38,7 @@
this._controlHandleRadius = 7;
this._bezierWidth = editorWidth - (this._controlHandleRadius * 2);
this._bezierHeight = editorHeight - (this._controlHandleRadius * 2) - (this._padding * 2);
- this._bezierPreviewAnimationStyleText = "bezierPreview 2s 250ms forwards ";
+ this._bezierPreviewAnimationStyleText = "bezierPreview 2.5s 250ms infinite ";
var bezierPreviewContainer = document.createElement("div");
bezierPreviewContainer.id = "bezierPreview";
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
