Title: [197321] releases/WebKitGTK/webkit-2.12/Source/WebCore
Revision
197321
Author
[email protected]
Date
2016-02-29 01:27:54 -0800 (Mon, 29 Feb 2016)

Log Message

Merge r197141 - Don't clear the weak JSString cache on memory pressure.
<https://webkit.org/b/154693>

Reviewed by Antti Koivisto.

This was stupid. The cache is a WeakGCMap, so all the JSStrings pointed to are
still alive anyway. This way we keep the ability to deduplicate common strings.

* platform/MemoryPressureHandler.cpp:
(WebCore::MemoryPressureHandler::releaseNoncriticalMemory): Deleted.

Modified Paths

Diff

Modified: releases/WebKitGTK/webkit-2.12/Source/WebCore/ChangeLog (197320 => 197321)


--- releases/WebKitGTK/webkit-2.12/Source/WebCore/ChangeLog	2016-02-29 09:25:53 UTC (rev 197320)
+++ releases/WebKitGTK/webkit-2.12/Source/WebCore/ChangeLog	2016-02-29 09:27:54 UTC (rev 197321)
@@ -1,3 +1,16 @@
+2016-02-25  Andreas Kling  <[email protected]>
+
+        Don't clear the weak JSString cache on memory pressure.
+        <https://webkit.org/b/154693>
+
+        Reviewed by Antti Koivisto.
+
+        This was stupid. The cache is a WeakGCMap, so all the JSStrings pointed to are
+        still alive anyway. This way we keep the ability to deduplicate common strings.
+
+        * platform/MemoryPressureHandler.cpp:
+        (WebCore::MemoryPressureHandler::releaseNoncriticalMemory): Deleted.
+
 2016-02-25  Said Abou-Hallawa  <[email protected]>
 
         REGRESSION (r196268): Many assertion failures and crashes on SVG path animation tests when JS garbage collection happens quickly

Modified: releases/WebKitGTK/webkit-2.12/Source/WebCore/platform/MemoryPressureHandler.cpp (197320 => 197321)


--- releases/WebKitGTK/webkit-2.12/Source/WebCore/platform/MemoryPressureHandler.cpp	2016-02-29 09:25:53 UTC (rev 197320)
+++ releases/WebKitGTK/webkit-2.12/Source/WebCore/platform/MemoryPressureHandler.cpp	2016-02-29 09:27:54 UTC (rev 197321)
@@ -96,11 +96,6 @@
     }
 
     {
-        ReliefLogger log("Clearing JS string cache");
-        JSDOMWindow::commonVM().stringCache.clear();
-    }
-
-    {
         ReliefLogger log("Prune MemoryCache dead resources");
         MemoryCache::singleton().pruneDeadResourcesToSize(0);
     }
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to