Title: [197326] releases/WebKitGTK/webkit-2.12/Source/WebInspectorUI
Revision
197326
Author
[email protected]
Date
2016-02-29 02:03:14 -0800 (Mon, 29 Feb 2016)

Log Message

Merge r197169 - Web Inspector: Option-clicking on the a CSS property sometimes doesn't work
https://bugs.webkit.org/show_bug.cgi?id=154384
<rdar://problem/24714755>

Patch by Devin Rousso <[email protected]> on 2016-02-26
Reviewed by Timothy Hatcher.

It seems as though there were race conditions between CodeMirror's event
and the native mousemove such that if CodeMirror fired second, the current
candidate was cleared, and would not reset itself until the cursor was
moved, at which point the same issue could happen. To fix this, the current
candidate is no longer cleared by CodeMirror's event and is instead only
modified by the native mouse-events.

* UserInterface/Controllers/CodeMirrorTokenTrackingController.js:
(WebInspector.CodeMirrorTokenTrackingController.prototype._hidePopover):

Modified Paths

Diff

Modified: releases/WebKitGTK/webkit-2.12/Source/WebInspectorUI/ChangeLog (197325 => 197326)


--- releases/WebKitGTK/webkit-2.12/Source/WebInspectorUI/ChangeLog	2016-02-29 10:02:27 UTC (rev 197325)
+++ releases/WebKitGTK/webkit-2.12/Source/WebInspectorUI/ChangeLog	2016-02-29 10:03:14 UTC (rev 197326)
@@ -1,3 +1,21 @@
+2016-02-26  Devin Rousso  <[email protected]>
+
+        Web Inspector: Option-clicking on the a CSS property sometimes doesn't work
+        https://bugs.webkit.org/show_bug.cgi?id=154384
+        <rdar://problem/24714755>
+
+        Reviewed by Timothy Hatcher.
+
+        It seems as though there were race conditions between CodeMirror's event
+        and the native mousemove such that if CodeMirror fired second, the current
+        candidate was cleared, and would not reset itself until the cursor was
+        moved, at which point the same issue could happen. To fix this, the current
+        candidate is no longer cleared by CodeMirror's event and is instead only
+        modified by the native mouse-events.
+
+        * UserInterface/Controllers/CodeMirrorTokenTrackingController.js:
+        (WebInspector.CodeMirrorTokenTrackingController.prototype._hidePopover):
+
 2016-02-22  Matt Baker  <[email protected]>
 
         Web Inspector: Timelines sidebar and overview attempt to access undefined properties when FPS instrument is absent

Modified: releases/WebKitGTK/webkit-2.12/Source/WebInspectorUI/UserInterface/Controllers/CodeMirrorTokenTrackingController.js (197325 => 197326)


--- releases/WebKitGTK/webkit-2.12/Source/WebInspectorUI/UserInterface/Controllers/CodeMirrorTokenTrackingController.js	2016-02-29 10:02:27 UTC (rev 197325)
+++ releases/WebKitGTK/webkit-2.12/Source/WebInspectorUI/UserInterface/Controllers/CodeMirrorTokenTrackingController.js	2016-02-29 10:03:14 UTC (rev 197326)
@@ -276,8 +276,6 @@
             const forceHidePopover = true;
             this._delegate.tokenTrackingControllerHighlightedRangeReleased(this, forceHidePopover);
         }
-
-        this._candidate = null;
     }
 
     _mouseEntered(event)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to