Title: [197494] trunk
- Revision
- 197494
- Author
- [email protected]
- Date
- 2016-03-02 22:31:37 -0800 (Wed, 02 Mar 2016)
Log Message
Drop [TreatNullAs=LegacyNullString] from HTMLBaseElement.href
https://bugs.webkit.org/show_bug.cgi?id=154952
Reviewed by Ryosuke Niwa.
Source/WebCore:
Drop [TreatNullAs=LegacyNullString] from HTMLBaseElement.href as this
does not match the specification:
- https://html.spec.whatwg.org/multipage/semantics.html#the-base-element
Firefox and Chrome both convert null to the string "null".
No new tests, updated the following existing test:
fast/dom/HTMLBaseElement/href-attribute-resolves-with-respect-to-document.html
* html/HTMLBaseElement.idl:
LayoutTests:
Update existing layout test now that HTMLBaseElement.href setter no
longer treats null as the empty string.
* fast/dom/HTMLBaseElement/href-attribute-resolves-with-respect-to-document-expected.txt:
* fast/dom/HTMLBaseElement/href-attribute-resolves-with-respect-to-document.html:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (197493 => 197494)
--- trunk/LayoutTests/ChangeLog 2016-03-03 06:26:59 UTC (rev 197493)
+++ trunk/LayoutTests/ChangeLog 2016-03-03 06:31:37 UTC (rev 197494)
@@ -1,3 +1,16 @@
+2016-03-02 Chris Dumez <[email protected]>
+
+ Drop [TreatNullAs=LegacyNullString] from HTMLBaseElement.href
+ https://bugs.webkit.org/show_bug.cgi?id=154952
+
+ Reviewed by Ryosuke Niwa.
+
+ Update existing layout test now that HTMLBaseElement.href setter no
+ longer treats null as the empty string.
+
+ * fast/dom/HTMLBaseElement/href-attribute-resolves-with-respect-to-document-expected.txt:
+ * fast/dom/HTMLBaseElement/href-attribute-resolves-with-respect-to-document.html:
+
2016-03-02 Zalan Bujtas <[email protected]>
Paint table borders on empty cells even in quirks mode.
Modified: trunk/LayoutTests/fast/dom/HTMLBaseElement/href-attribute-resolves-with-respect-to-document-expected.txt (197493 => 197494)
--- trunk/LayoutTests/fast/dom/HTMLBaseElement/href-attribute-resolves-with-respect-to-document-expected.txt 2016-03-03 06:26:59 UTC (rev 197493)
+++ trunk/LayoutTests/fast/dom/HTMLBaseElement/href-attribute-resolves-with-respect-to-document-expected.txt 2016-03-03 06:31:37 UTC (rev 197494)
@@ -1,5 +1,7 @@
PASS endsWith(document.querySelector('base').href, 'foo/bar/') is true
PASS endsWith(document.querySelector('base').href, 'foo/bar/foo/bar/') is false
+PASS document.querySelector('base').hasAttribute('href') is true
+PASS endsWith(document.querySelector('base').href, '/null') is true
PASS document.querySelector('base').hasAttribute('href') is false
PASS endsWith(document.querySelector('base').href, '/href-attribute-resolves-with-respect-to-document.html') is true
PASS documentWithoutAView.querySelector('base').href is ""
Modified: trunk/LayoutTests/fast/dom/HTMLBaseElement/href-attribute-resolves-with-respect-to-document.html (197493 => 197494)
--- trunk/LayoutTests/fast/dom/HTMLBaseElement/href-attribute-resolves-with-respect-to-document.html 2016-03-03 06:26:59 UTC (rev 197493)
+++ trunk/LayoutTests/fast/dom/HTMLBaseElement/href-attribute-resolves-with-respect-to-document.html 2016-03-03 06:31:37 UTC (rev 197494)
@@ -23,6 +23,10 @@
shouldBeFalse("endsWith(document.querySelector('base').href, 'foo/bar/foo/bar/')");
base.href = ""
+shouldBeTrue("document.querySelector('base').hasAttribute('href')");
+shouldBeTrue("endsWith(document.querySelector('base').href, '/null')");
+
+base.removeAttribute('href');
shouldBeFalse("document.querySelector('base').hasAttribute('href')");
shouldBeTrue("endsWith(document.querySelector('base').href, '/href-attribute-resolves-with-respect-to-document.html')");
@@ -55,4 +59,4 @@
finishJSTest();
-</script>
\ No newline at end of file
+</script>
Modified: trunk/Source/WebCore/ChangeLog (197493 => 197494)
--- trunk/Source/WebCore/ChangeLog 2016-03-03 06:26:59 UTC (rev 197493)
+++ trunk/Source/WebCore/ChangeLog 2016-03-03 06:31:37 UTC (rev 197494)
@@ -1,3 +1,21 @@
+2016-03-02 Chris Dumez <[email protected]>
+
+ Drop [TreatNullAs=LegacyNullString] from HTMLBaseElement.href
+ https://bugs.webkit.org/show_bug.cgi?id=154952
+
+ Reviewed by Ryosuke Niwa.
+
+ Drop [TreatNullAs=LegacyNullString] from HTMLBaseElement.href as this
+ does not match the specification:
+ - https://html.spec.whatwg.org/multipage/semantics.html#the-base-element
+
+ Firefox and Chrome both convert null to the string "null".
+
+ No new tests, updated the following existing test:
+ fast/dom/HTMLBaseElement/href-attribute-resolves-with-respect-to-document.html
+
+ * html/HTMLBaseElement.idl:
+
2016-03-02 Zalan Bujtas <[email protected]>
Paint table borders on empty cells even in quirks mode.
Modified: trunk/Source/WebCore/html/HTMLBaseElement.idl (197493 => 197494)
--- trunk/Source/WebCore/html/HTMLBaseElement.idl 2016-03-03 06:26:59 UTC (rev 197493)
+++ trunk/Source/WebCore/html/HTMLBaseElement.idl 2016-03-03 06:31:37 UTC (rev 197494)
@@ -18,8 +18,7 @@
*/
interface HTMLBaseElement : HTMLElement {
- // FIXME: This should not have [TreatNullAs=LegacyNullString].
- [TreatNullAs=LegacyNullString] attribute DOMString href;
+ attribute DOMString href;
[Reflect] attribute DOMString target;
};
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
