Title: [197513] trunk/LayoutTests
- Revision
- 197513
- Author
- beid...@apple.com
- Date
- 2016-03-03 11:46:25 -0800 (Thu, 03 Mar 2016)
Log Message
storage/indexeddb/delete-in-upgradeneeded-close-in-open-success.html flaky on mac-wk2.
https://bugs.webkit.org/show_bug.cgi?id=154747
Reviewed by Alex Christensen.
This callback coming out of order like this is okay, so the test should just allow it.
It makes sense that the flake is WK2-only, since WK1 has a much more well defined order
with thread-hopping versus process-hopping.
* storage/indexeddb/delete-in-upgradeneeded-close-in-open-success-expected.txt:
* storage/indexeddb/delete-in-upgradeneeded-close-in-open-success-private-expected.txt:
* storage/indexeddb/resources/delete-in-upgradeneeded-close-in-open-success.js:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (197512 => 197513)
--- trunk/LayoutTests/ChangeLog 2016-03-03 19:18:35 UTC (rev 197512)
+++ trunk/LayoutTests/ChangeLog 2016-03-03 19:46:25 UTC (rev 197513)
@@ -1,5 +1,21 @@
2016-03-03 Brady Eidson <beid...@apple.com>
+ storage/indexeddb/delete-in-upgradeneeded-close-in-open-success.html flaky on mac-wk2.
+ https://bugs.webkit.org/show_bug.cgi?id=154747
+
+ Reviewed by Alex Christensen.
+
+ This callback coming out of order like this is okay, so the test should just allow it.
+
+ It makes sense that the flake is WK2-only, since WK1 has a much more well defined order
+ with thread-hopping versus process-hopping.
+
+ * storage/indexeddb/delete-in-upgradeneeded-close-in-open-success-expected.txt:
+ * storage/indexeddb/delete-in-upgradeneeded-close-in-open-success-private-expected.txt:
+ * storage/indexeddb/resources/delete-in-upgradeneeded-close-in-open-success.js:
+
+2016-03-03 Brady Eidson <beid...@apple.com>
+
storage/indexeddb/intversion-open-in-upgradeneeded.html is flaky on mac-wk2 debug.
https://bugs.webkit.org/show_bug.cgi?id=154706
Modified: trunk/LayoutTests/storage/indexeddb/delete-in-upgradeneeded-close-in-open-success-expected.txt (197512 => 197513)
--- trunk/LayoutTests/storage/indexeddb/delete-in-upgradeneeded-close-in-open-success-expected.txt 2016-03-03 19:18:35 UTC (rev 197512)
+++ trunk/LayoutTests/storage/indexeddb/delete-in-upgradeneeded-close-in-open-success-expected.txt 2016-03-03 19:46:25 UTC (rev 197513)
@@ -24,10 +24,6 @@
PASS event.newVersion is null
sawVersionChange = true
-deleteBlockedCallback():
-PASS sawVersionChange is true
-sawDeleteBlocked = true
-
openSuccess():
PASS sawUpgradeNeeded is true
db = event.target.result
Modified: trunk/LayoutTests/storage/indexeddb/delete-in-upgradeneeded-close-in-open-success-private-expected.txt (197512 => 197513)
--- trunk/LayoutTests/storage/indexeddb/delete-in-upgradeneeded-close-in-open-success-private-expected.txt 2016-03-03 19:18:35 UTC (rev 197512)
+++ trunk/LayoutTests/storage/indexeddb/delete-in-upgradeneeded-close-in-open-success-private-expected.txt 2016-03-03 19:46:25 UTC (rev 197513)
@@ -24,10 +24,6 @@
PASS event.newVersion is null
sawVersionChange = true
-deleteBlockedCallback():
-PASS sawVersionChange is true
-sawDeleteBlocked = true
-
openSuccess():
PASS sawUpgradeNeeded is true
db = event.target.result
Modified: trunk/LayoutTests/storage/indexeddb/resources/delete-in-upgradeneeded-close-in-open-success.js (197512 => 197513)
--- trunk/LayoutTests/storage/indexeddb/resources/delete-in-upgradeneeded-close-in-open-success.js 2016-03-03 19:18:35 UTC (rev 197512)
+++ trunk/LayoutTests/storage/indexeddb/resources/delete-in-upgradeneeded-close-in-open-success.js 2016-03-03 19:46:25 UTC (rev 197513)
@@ -62,9 +62,9 @@
function deleteBlockedCallback(evt)
{
- preamble(evt);
- shouldBeTrue("sawVersionChange");
- evalAndLog("sawDeleteBlocked = true");
+ if (!sawVersionChange)
+ debug("deleteBlockedCallback was called *before* versionChangeCallback, which is wrong");
+ eval("sawDeleteBlocked = true");
}
function deleteSuccessCallback(evt)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
