Title: [197530] trunk/Source/WebInspectorUI
- Revision
- 197530
- Author
- [email protected]
- Date
- 2016-03-03 16:39:41 -0800 (Thu, 03 Mar 2016)
Log Message
Web Inspector: Selected range path component should be zero time corrected
https://bugs.webkit.org/show_bug.cgi?id=154950
<rdar://problem/24947022>
Reviewed by Timothy Hatcher.
Subtracts zero time from TimelineRange start and end values, and corrects
a cosmetic issue in TimelineRuler which showed selection handle tooltips
that weren't adjusted for the ruler's zero time.
* UserInterface/Views/TimelineRecordingContentView.js:
(WebInspector.TimelineRecordingContentView.prototype._timeRangeSelectionChanged):
* UserInterface/Views/TimelineRuler.js:
(WebInspector.TimelineRuler.prototype._updateSelection):
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (197529 => 197530)
--- trunk/Source/WebInspectorUI/ChangeLog 2016-03-04 00:33:15 UTC (rev 197529)
+++ trunk/Source/WebInspectorUI/ChangeLog 2016-03-04 00:39:41 UTC (rev 197530)
@@ -1,5 +1,23 @@
2016-03-03 Matt Baker <[email protected]>
+ Web Inspector: Selected range path component should be zero time corrected
+ https://bugs.webkit.org/show_bug.cgi?id=154950
+ <rdar://problem/24947022>
+
+ Reviewed by Timothy Hatcher.
+
+ Subtracts zero time from TimelineRange start and end values, and corrects
+ a cosmetic issue in TimelineRuler which showed selection handle tooltips
+ that weren't adjusted for the ruler's zero time.
+
+ * UserInterface/Views/TimelineRecordingContentView.js:
+ (WebInspector.TimelineRecordingContentView.prototype._timeRangeSelectionChanged):
+
+ * UserInterface/Views/TimelineRuler.js:
+ (WebInspector.TimelineRuler.prototype._updateSelection):
+
+2016-03-03 Matt Baker <[email protected]>
+
Web Inspector: Events and Frames mode switch does not fully switch until first zoom
https://bugs.webkit.org/show_bug.cgi?id=154971
<rdar://problem/24955871>
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/TimelineRecordingContentView.js (197529 => 197530)
--- trunk/Source/WebInspectorUI/UserInterface/Views/TimelineRecordingContentView.js 2016-03-04 00:33:15 UTC (rev 197529)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/TimelineRecordingContentView.js 2016-03-04 00:39:41 UTC (rev 197530)
@@ -693,8 +693,8 @@
selectedPathComponent = this._entireRecordingPathComponent;
else {
let timelineRange = this._timelineSelectionPathComponent.representedObject;
- timelineRange.startValue = this.currentTimelineView.startTime;
- timelineRange.endValue = this.currentTimelineView.endTime;
+ timelineRange.startValue = this.currentTimelineView.startTime - this.currentTimelineView.zeroTime;
+ timelineRange.endValue = this.currentTimelineView.endTime - this.currentTimelineView.zeroTime;
this._updateTimeRangePathComponents();
selectedPathComponent = this._timelineSelectionPathComponent;
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/TimelineRuler.js (197529 => 197530)
--- trunk/Source/WebInspectorUI/UserInterface/Views/TimelineRuler.js 2016-03-04 00:33:15 UTC (rev 197529)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/TimelineRuler.js 2016-03-04 00:39:41 UTC (rev 197530)
@@ -631,8 +631,8 @@
this.element.classList.toggle("both-handles-clamped", startTimeClamped && endTimeClamped);
- let formattedStartTimeText = this._formatDividerLabelText(this._selectionStartTime);
- let formattedEndTimeText = this._formatDividerLabelText(this._selectionEndTime);
+ let formattedStartTimeText = this._formatDividerLabelText(this._selectionStartTime - this._zeroTime);
+ let formattedEndTimeText = this._formatDividerLabelText(this._selectionEndTime - this._zeroTime);
let newLeftPosition = Number.constrain((this._selectionStartTime - this._startTime) / duration, 0, 1);
this._updatePositionOfElement(this._leftShadedAreaElement, newLeftPosition, visibleWidth, "width");
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
