Title: [197547] trunk/LayoutTests
- Revision
- 197547
- Author
- [email protected]
- Date
- 2016-03-03 21:49:23 -0800 (Thu, 03 Mar 2016)
Log Message
Unreviewed, remove test with flaky timeout that doesn't test anything anymore. This test
was relevant back when arguments got torn off; something that we don't do anymore. It
uses a loop that waits for the top-tier compiler to compile it. We don't write tests
like that anymore.
* js/dfg-osr-exit-between-create-and-tearoff-arguments-expected.txt: Removed.
* js/dfg-osr-exit-between-create-and-tearoff-arguments.html: Removed.
* js/script-tests/dfg-osr-exit-between-create-and-tearoff-arguments.js: Removed.
Modified Paths
Removed Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (197546 => 197547)
--- trunk/LayoutTests/ChangeLog 2016-03-04 04:40:17 UTC (rev 197546)
+++ trunk/LayoutTests/ChangeLog 2016-03-04 05:49:23 UTC (rev 197547)
@@ -1,3 +1,14 @@
+2016-03-03 Filip Pizlo <[email protected]>
+
+ Unreviewed, remove test with flaky timeout that doesn't test anything anymore. This test
+ was relevant back when arguments got torn off; something that we don't do anymore. It
+ uses a loop that waits for the top-tier compiler to compile it. We don't write tests
+ like that anymore.
+
+ * js/dfg-osr-exit-between-create-and-tearoff-arguments-expected.txt: Removed.
+ * js/dfg-osr-exit-between-create-and-tearoff-arguments.html: Removed.
+ * js/script-tests/dfg-osr-exit-between-create-and-tearoff-arguments.js: Removed.
+
2016-03-03 Keith Miller <[email protected]>
JSArrayBuffers should be collected less aggressively
Deleted: trunk/LayoutTests/js/dfg-osr-exit-between-create-and-tearoff-arguments-expected.txt (197546 => 197547)
--- trunk/LayoutTests/js/dfg-osr-exit-between-create-and-tearoff-arguments-expected.txt 2016-03-04 04:40:17 UTC (rev 197546)
+++ trunk/LayoutTests/js/dfg-osr-exit-between-create-and-tearoff-arguments-expected.txt 2016-03-04 05:49:23 UTC (rev 197547)
@@ -1,9 +0,0 @@
-Tests that an OSR exit between CreateArguments and TearOffArguments does not cause a crash.
-
-On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
-
-
-PASS successfullyParsed is true
-
-TEST COMPLETE
-
Deleted: trunk/LayoutTests/js/dfg-osr-exit-between-create-and-tearoff-arguments.html (197546 => 197547)
--- trunk/LayoutTests/js/dfg-osr-exit-between-create-and-tearoff-arguments.html 2016-03-04 04:40:17 UTC (rev 197546)
+++ trunk/LayoutTests/js/dfg-osr-exit-between-create-and-tearoff-arguments.html 2016-03-04 05:49:23 UTC (rev 197547)
@@ -1,10 +0,0 @@
-<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN">
-<html>
-<head>
-<script src=""
-</head>
-<body>
-<script src=""
-<script src=""
-</body>
-</html>
Deleted: trunk/LayoutTests/js/script-tests/dfg-osr-exit-between-create-and-tearoff-arguments.js (197546 => 197547)
--- trunk/LayoutTests/js/script-tests/dfg-osr-exit-between-create-and-tearoff-arguments.js 2016-03-04 04:40:17 UTC (rev 197546)
+++ trunk/LayoutTests/js/script-tests/dfg-osr-exit-between-create-and-tearoff-arguments.js 2016-03-04 05:49:23 UTC (rev 197547)
@@ -1,22 +0,0 @@
-description(
-"Tests that an OSR exit between CreateArguments and TearOffArguments does not cause a crash."
-);
-
-var foo = function(x) {
- function goo(reenter) {
- var captured = x;
- return x + 5;
- }
-
- // Loop here to get this function to DFG compile. Because we have captured vars,
- // there will be a forced OSR exit on entry should we call this function again.
- // We need this OSR exit to occur between the DFG generated code for
- // CreateArguments and TearOffArguments in order for the bug to trigger a crash.
- // See https://webkit.org/b/140743.
- while (!dfgCompiled({f: foo}))
- goo();
- return arguments;
-}
-
-foo(1); // First call to get the DFG to compile foo() due to its big loop.
-foo(1); // Second call to trigger the OSR exit and verify that we don't crash.
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
