Title: [197638] trunk/Source
- Revision
- 197638
- Author
- [email protected]
- Date
- 2016-03-06 04:04:30 -0800 (Sun, 06 Mar 2016)
Log Message
Reduce page cache capacity from 3 to 2.
<https://webkit.org/b/155087>
Reviewed by Antti Koivisto.
Source/WebKit/mac:
Trim WebKit1 page cache capacities consistently with WebKit2.
* WebView/WebView.mm:
(+[WebView _setCacheModel:]):
Source/WebKit2:
It's extremely rare that users go back more than 2 pages in the page cache,
and nowadays the network cache makes even un-cached pages fast to reload.
Trimming the page cache from 3 to 2 entries has a very nice effect on heap
fragmentation. I'm seeing a ~5% progression on the iPad PLUM test locally;
average memory usage across 300 loads goes from ~121MB to ~114MB.
* Shared/CacheModel.cpp:
(WebKit::calculateCacheSizes):
Modified Paths
Diff
Modified: trunk/Source/WebKit/mac/ChangeLog (197637 => 197638)
--- trunk/Source/WebKit/mac/ChangeLog 2016-03-06 10:17:52 UTC (rev 197637)
+++ trunk/Source/WebKit/mac/ChangeLog 2016-03-06 12:04:30 UTC (rev 197638)
@@ -1,3 +1,15 @@
+2016-03-06 Andreas Kling <[email protected]>
+
+ Reduce page cache capacity from 3 to 2.
+ <https://webkit.org/b/155087>
+
+ Reviewed by Antti Koivisto.
+
+ Trim WebKit1 page cache capacities consistently with WebKit2.
+
+ * WebView/WebView.mm:
+ (+[WebView _setCacheModel:]):
+
2016-03-05 Chris Dumez <[email protected]>
Consolidate RuntimeApplicationChecks and RuntimeApplicationChecksIOS
Modified: trunk/Source/WebKit/mac/WebView/WebView.mm (197637 => 197638)
--- trunk/Source/WebKit/mac/WebView/WebView.mm 2016-03-06 10:17:52 UTC (rev 197637)
+++ trunk/Source/WebKit/mac/WebView/WebView.mm 2016-03-06 12:04:30 UTC (rev 197638)
@@ -7879,9 +7879,7 @@
}
case WebCacheModelDocumentBrowser: {
// Page cache capacity (in pages)
- if (memSize >= 1024)
- pageCacheSize = 3;
- else if (memSize >= 512)
+ if (memSize >= 512)
pageCacheSize = 2;
else if (memSize >= 256)
pageCacheSize = 1;
@@ -7932,10 +7930,7 @@
}
case WebCacheModelPrimaryWebBrowser: {
// Page cache capacity (in pages)
- // Research indicates that value / page drops substantially after 3 pages.
- if (memSize >= 1024)
- pageCacheSize = 3;
- else if (memSize >= 512)
+ if (memSize >= 512)
pageCacheSize = 2;
else if (memSize >= 256)
pageCacheSize = 1;
Modified: trunk/Source/WebKit2/ChangeLog (197637 => 197638)
--- trunk/Source/WebKit2/ChangeLog 2016-03-06 10:17:52 UTC (rev 197637)
+++ trunk/Source/WebKit2/ChangeLog 2016-03-06 12:04:30 UTC (rev 197638)
@@ -1,3 +1,20 @@
+2016-03-06 Andreas Kling <[email protected]>
+
+ Reduce page cache capacity from 3 to 2.
+ <https://webkit.org/b/155087>
+
+ Reviewed by Antti Koivisto.
+
+ It's extremely rare that users go back more than 2 pages in the page cache,
+ and nowadays the network cache makes even un-cached pages fast to reload.
+
+ Trimming the page cache from 3 to 2 entries has a very nice effect on heap
+ fragmentation. I'm seeing a ~5% progression on the iPad PLUM test locally;
+ average memory usage across 300 loads goes from ~121MB to ~114MB.
+
+ * Shared/CacheModel.cpp:
+ (WebKit::calculateCacheSizes):
+
2016-03-05 Sam Weinig <[email protected]>
Revert usage of autofill field name for use with UITextInputTraits
Modified: trunk/Source/WebKit2/Shared/CacheModel.cpp (197637 => 197638)
--- trunk/Source/WebKit2/Shared/CacheModel.cpp 2016-03-06 10:17:52 UTC (rev 197637)
+++ trunk/Source/WebKit2/Shared/CacheModel.cpp 2016-03-06 12:04:30 UTC (rev 197638)
@@ -62,9 +62,7 @@
}
case CacheModelDocumentBrowser: {
// Page cache capacity (in pages)
- if (memorySize >= 1024)
- pageCacheCapacity = 3;
- else if (memorySize >= 512)
+ if (memorySize >= 512)
pageCacheCapacity = 2;
else if (memorySize >= 256)
pageCacheCapacity = 1;
@@ -108,9 +106,7 @@
}
case CacheModelPrimaryWebBrowser: {
// Page cache capacity (in pages)
- if (memorySize >= 1024)
- pageCacheCapacity = 3;
- else if (memorySize >= 512)
+ if (memorySize >= 512)
pageCacheCapacity = 2;
else if (memorySize >= 256)
pageCacheCapacity = 1;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
