Title: [197806] trunk/Source/WebInspectorUI
- Revision
- 197806
- Author
- [email protected]
- Date
- 2016-03-08 15:02:55 -0800 (Tue, 08 Mar 2016)
Log Message
Web Inspector: Miscellaneous inspector fixes for typos / stale code
https://bugs.webkit.org/show_bug.cgi?id=155193
Patch by Joseph Pecoraro <[email protected]> on 2016-03-08
Reviewed by Timothy Hatcher.
* UserInterface/Models/SourceCodeLocation.js:
(WebInspector.SourceCodeLocation.prototype._locationString):
Fix whitespace.
* UserInterface/Views/ApplicationCacheFrameContentView.js:
(WebInspector.ApplicationCacheFrameContentView):
Remove unused class name.
* UserInterface/Views/SourceCodeTextEditor.js:
(WebInspector.SourceCodeTextEditor.prototype._showPopoverForFunction.didGetDetails):
Remove inferredName, as that was never sent by our backend and is getting removed.
* UserInterface/Views/TimelineRuler.js:
(WebInspector.TimelineRuler.prototype._handleMouseUp):
Fix variable name typo.
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (197805 => 197806)
--- trunk/Source/WebInspectorUI/ChangeLog 2016-03-08 22:29:50 UTC (rev 197805)
+++ trunk/Source/WebInspectorUI/ChangeLog 2016-03-08 23:02:55 UTC (rev 197806)
@@ -1,5 +1,28 @@
2016-03-08 Joseph Pecoraro <[email protected]>
+ Web Inspector: Miscellaneous inspector fixes for typos / stale code
+ https://bugs.webkit.org/show_bug.cgi?id=155193
+
+ Reviewed by Timothy Hatcher.
+
+ * UserInterface/Models/SourceCodeLocation.js:
+ (WebInspector.SourceCodeLocation.prototype._locationString):
+ Fix whitespace.
+
+ * UserInterface/Views/ApplicationCacheFrameContentView.js:
+ (WebInspector.ApplicationCacheFrameContentView):
+ Remove unused class name.
+
+ * UserInterface/Views/SourceCodeTextEditor.js:
+ (WebInspector.SourceCodeTextEditor.prototype._showPopoverForFunction.didGetDetails):
+ Remove inferredName, as that was never sent by our backend and is getting removed.
+
+ * UserInterface/Views/TimelineRuler.js:
+ (WebInspector.TimelineRuler.prototype._handleMouseUp):
+ Fix variable name typo.
+
+2016-03-08 Joseph Pecoraro <[email protected]>
+
Web Inspector: Images being blocked by CSP 2.0
https://bugs.webkit.org/show_bug.cgi?id=155182
<rdar://problem/25040640>
Modified: trunk/Source/WebInspectorUI/UserInterface/Models/SourceCodeLocation.js (197805 => 197806)
--- trunk/Source/WebInspectorUI/UserInterface/Models/SourceCodeLocation.js 2016-03-08 22:29:50 UTC (rev 197805)
+++ trunk/Source/WebInspectorUI/UserInterface/Models/SourceCodeLocation.js 2016-03-08 23:02:55 UTC (rev 197806)
@@ -340,7 +340,7 @@
if (columnStyle === WebInspector.SourceCodeLocation.ColumnStyle.Hidden)
return prefix + name;
let lineSuffix = displayURL ? ":" + lineString : WebInspector.UIString(" (line %s)").format(lineString);
- return prefix + name + lineSuffix;
+ return prefix + name + lineSuffix;
default:
console.error("Unknown nameStyle: " + nameStyle);
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ApplicationCacheFrameContentView.js (197805 => 197806)
--- trunk/Source/WebInspectorUI/UserInterface/Views/ApplicationCacheFrameContentView.js 2016-03-08 22:29:50 UTC (rev 197805)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ApplicationCacheFrameContentView.js 2016-03-08 23:02:55 UTC (rev 197806)
@@ -31,7 +31,7 @@
super(representedObject);
- this.element.classList.add("application-cache-frame", "table");
+ this.element.classList.add("application-cache-frame");
this._frame = representedObject.frame;
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/SourceCodeTextEditor.js (197805 => 197806)
--- trunk/Source/WebInspectorUI/UserInterface/Views/SourceCodeTextEditor.js 2016-03-08 22:29:50 UTC (rev 197805)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/SourceCodeTextEditor.js 2016-03-08 23:02:55 UTC (rev 197806)
@@ -1475,7 +1475,7 @@
let title = content.appendChild(document.createElement("div"));
title.classList.add("title");
- title.textContent = response.name || response.inferredName || response.displayName || WebInspector.UIString("(anonymous function)");
+ title.textContent = response.name || response.displayName || WebInspector.UIString("(anonymous function)");
title.appendChild(functionSourceCodeLink);
content.appendChild(wrapper);
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/TimelineRuler.js (197805 => 197806)
--- trunk/Source/WebInspectorUI/UserInterface/Views/TimelineRuler.js 2016-03-08 22:29:50 UTC (rev 197805)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/TimelineRuler.js 2016-03-08 23:02:55 UTC (rev 197806)
@@ -799,7 +799,7 @@
document.removeEventListener("mousemove", this._mouseMoveEventListener);
document.removeEventListener("mouseup", this._mouseUpEventListener);
- delete this._mouseMovedEventListener;
+ delete this._mouseMoveEventListener;
delete this._mouseUpEventListener;
delete this._mouseDownPosition;
delete this._lastMousePosition;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
