Title: [197911] trunk/Source/WebCore
Revision
197911
Author
[email protected]
Date
2016-03-09 17:46:40 -0800 (Wed, 09 Mar 2016)

Log Message

Fix the Windows build after <https://trac.webkit.org/changeset/197905>
(https://bugs.webkit.org/show_bug.cgi?id=155247)

We need to call the std::unique_ptr<CryptoDigest>() constructor directly
instead of using the convenience function std::make_unique<CryptoDigest>()
because std::make_unique<CryptoDigest>() cannot access the private constructor
CryptoDigest().

* platform/crypto/win/CryptoDigestWin.cpp:
(WebCore::CryptoDigest::create):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (197910 => 197911)


--- trunk/Source/WebCore/ChangeLog	2016-03-10 01:38:50 UTC (rev 197910)
+++ trunk/Source/WebCore/ChangeLog	2016-03-10 01:46:40 UTC (rev 197911)
@@ -1,5 +1,18 @@
 2016-03-09  Daniel Bates  <[email protected]>
 
+        Fix the Windows build after <https://trac.webkit.org/changeset/197905>
+        (https://bugs.webkit.org/show_bug.cgi?id=155247)
+
+        We need to call the std::unique_ptr<CryptoDigest>() constructor directly
+        instead of using the convenience function std::make_unique<CryptoDigest>()
+        because std::make_unique<CryptoDigest>() cannot access the private constructor
+        CryptoDigest().
+
+        * platform/crypto/win/CryptoDigestWin.cpp:
+        (WebCore::CryptoDigest::create):
+
+2016-03-09  Daniel Bates  <[email protected]>
+
         [Win] Implement CryptoDigest
         https://bugs.webkit.org/show_bug.cgi?id=155247
         <rdar://problem/25065843>

Modified: trunk/Source/WebCore/platform/crypto/win/CryptoDigestWin.cpp (197910 => 197911)


--- trunk/Source/WebCore/platform/crypto/win/CryptoDigestWin.cpp	2016-03-10 01:38:50 UTC (rev 197910)
+++ trunk/Source/WebCore/platform/crypto/win/CryptoDigestWin.cpp	2016-03-10 01:46:40 UTC (rev 197911)
@@ -51,11 +51,10 @@
 
 std::unique_ptr<CryptoDigest> CryptoDigest::create(Algorithm algorithm)
 {
-    auto digest = std::make_unique<CryptoDigest>();
+    std::unique_ptr<CryptoDigest> digest(new CryptoDigest);
     digest->m_context->algorithm = algorithm;
     if (!CryptAcquireContext(&digest->m_context->hContext, nullptr, nullptr /* use default provider */, PROV_RSA_AES, CRYPT_VERIFYCONTEXT))
         return nullptr;
-
     bool succeeded = false;
     switch (algorithm) {
     case CryptoDigest::Algorithm::SHA_1: {
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to