Title: [198202] trunk/Source/WebKit2
- Revision
- 198202
- Author
- [email protected]
- Date
- 2016-03-15 00:37:34 -0700 (Tue, 15 Mar 2016)
Log Message
Regression(r197939): ASSERTION FAILED: url.containsOnlyASCII() in URL.cpp
https://bugs.webkit.org/show_bug.cgi?id=155449
<rdar://problem/25134826>
Reviewed by Carlos Garcia Campos.
Bump WK2 Network Disk Cache version after r197939 as the new cache format
is not compatible with the old one and leads to assertions being hit when
browsing in Debug builds.
SubresourceInfo used to only contain a boolean and would therefore be
serialized as "0" / "1". However, after r197939, a URL field was added
and when trying to decode old cache entries with the new format, we
would try to construct a URL from the String "0" or "1". This would
assert because these are not valid URLs.
* NetworkProcess/cache/NetworkCacheStorage.h:
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (198201 => 198202)
--- trunk/Source/WebKit2/ChangeLog 2016-03-15 07:01:44 UTC (rev 198201)
+++ trunk/Source/WebKit2/ChangeLog 2016-03-15 07:37:34 UTC (rev 198202)
@@ -1,3 +1,23 @@
+2016-03-15 Chris Dumez <[email protected]>
+
+ Regression(r197939): ASSERTION FAILED: url.containsOnlyASCII() in URL.cpp
+ https://bugs.webkit.org/show_bug.cgi?id=155449
+ <rdar://problem/25134826>
+
+ Reviewed by Carlos Garcia Campos.
+
+ Bump WK2 Network Disk Cache version after r197939 as the new cache format
+ is not compatible with the old one and leads to assertions being hit when
+ browsing in Debug builds.
+
+ SubresourceInfo used to only contain a boolean and would therefore be
+ serialized as "0" / "1". However, after r197939, a URL field was added
+ and when trying to decode old cache entries with the new format, we
+ would try to construct a URL from the String "0" or "1". This would
+ assert because these are not valid URLs.
+
+ * NetworkProcess/cache/NetworkCacheStorage.h:
+
2016-03-14 Chris Dumez <[email protected]>
Unreviewed, rolling out r197981.
Modified: trunk/Source/WebKit2/NetworkProcess/cache/NetworkCacheStorage.h (198201 => 198202)
--- trunk/Source/WebKit2/NetworkProcess/cache/NetworkCacheStorage.h 2016-03-15 07:01:44 UTC (rev 198201)
+++ trunk/Source/WebKit2/NetworkProcess/cache/NetworkCacheStorage.h 2016-03-15 07:37:34 UTC (rev 198202)
@@ -86,7 +86,7 @@
size_t capacity() const { return m_capacity; }
size_t approximateSize() const;
- static const unsigned version = 5;
+ static const unsigned version = 6;
String basePath() const;
String versionPath() const;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
