Title: [198223] trunk/Source/WebCore
- Revision
- 198223
- Author
- [email protected]
- Date
- 2016-03-15 12:45:00 -0700 (Tue, 15 Mar 2016)
Log Message
<attachment> on iOS isn't quite vertically centered
https://bugs.webkit.org/show_bug.cgi?id=155502
<rdar://problem/24805991>
Reviewed by Beth Dakin.
No new tests; there are existing tests that will be enabled shortly.
* rendering/RenderThemeIOS.mm:
(WebCore::AttachmentInfo::AttachmentInfo):
We were overcounting the total height of the attachment content by one margin, because each item
would add in its margin, including the last one. Remove one margin.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (198222 => 198223)
--- trunk/Source/WebCore/ChangeLog 2016-03-15 19:43:40 UTC (rev 198222)
+++ trunk/Source/WebCore/ChangeLog 2016-03-15 19:45:00 UTC (rev 198223)
@@ -1,3 +1,18 @@
+2016-03-15 Tim Horton <[email protected]>
+
+ <attachment> on iOS isn't quite vertically centered
+ https://bugs.webkit.org/show_bug.cgi?id=155502
+ <rdar://problem/24805991>
+
+ Reviewed by Beth Dakin.
+
+ No new tests; there are existing tests that will be enabled shortly.
+
+ * rendering/RenderThemeIOS.mm:
+ (WebCore::AttachmentInfo::AttachmentInfo):
+ We were overcounting the total height of the attachment content by one margin, because each item
+ would add in its margin, including the last one. Remove one margin.
+
2016-03-15 Chris Fleizach <[email protected]>
AX: certain elements not included in accessibility tree
Modified: trunk/Source/WebCore/rendering/RenderThemeIOS.mm (198222 => 198223)
--- trunk/Source/WebCore/rendering/RenderThemeIOS.mm 2016-03-15 19:43:40 UTC (rev 198222)
+++ trunk/Source/WebCore/rendering/RenderThemeIOS.mm 2016-03-15 19:45:00 UTC (rev 198223)
@@ -1572,6 +1572,8 @@
}
}
+ yOffset -= attachmentItemMargin;
+
contentYOrigin = (attachmentRect.height() / 2) - (yOffset / 2);
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
