Title: [198231] trunk/Tools
- Revision
- 198231
- Author
- [email protected]
- Date
- 2016-03-15 15:04:36 -0700 (Tue, 15 Mar 2016)
Log Message
run-api-tests doesn't print test name when the test crashes
https://bugs.webkit.org/show_bug.cgi?id=155476
Reviewed by Daniel Bates.
* Scripts/run-api-tests: Print "UNEXPECTEDLY EXITED" with a test name when output
doesn't contain the test name yet. Changed test name output to always be before raw
stdout for clarity.
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (198230 => 198231)
--- trunk/Tools/ChangeLog 2016-03-15 21:55:49 UTC (rev 198230)
+++ trunk/Tools/ChangeLog 2016-03-15 22:04:36 UTC (rev 198231)
@@ -1,3 +1,14 @@
+2016-03-15 Alexey Proskuryakov <[email protected]>
+
+ run-api-tests doesn't print test name when the test crashes
+ https://bugs.webkit.org/show_bug.cgi?id=155476
+
+ Reviewed by Daniel Bates.
+
+ * Scripts/run-api-tests: Print "UNEXPECTEDLY EXITED" with a test name when output
+ doesn't contain the test name yet. Changed test name output to always be before raw
+ stdout for clarity.
+
2016-03-15 Chris Dumez <[email protected]>
Unreviewed, rolling out r198203.
Modified: trunk/Tools/Scripts/run-api-tests (198230 => 198231)
--- trunk/Tools/Scripts/run-api-tests 2016-03-15 21:55:49 UTC (rev 198230)
+++ trunk/Tools/Scripts/run-api-tests 2016-03-15 22:04:36 UTC (rev 198231)
@@ -229,6 +229,17 @@
@testOutput = grep { !/^LEAK:/ } @testOutput unless $showLeaks;
map { s/\*\*PASS\*\*/possiblyColored("bold green", "PASS")/eg } @testOutput;
map { s/\*\*FAIL\*\*/possiblyColored("bold red", "FAIL")/eg } @testOutput;
+
+ if ($result) {
+ push @testsFailed, $test;
+ if (!$timedOut && index("@testOutput", $test) == -1) {
+ print STDOUT possiblyColored("bold red", "UNEXPECTEDLY EXITED"), " $test\n";
+ }
+ } elsif ($timedOut) {
+ push @testsTimedOut, $test;
+ print STDOUT possiblyColored("bold yellow", "TIMEOUT"), " $test\n";
+ }
+
print STDOUT @testOutput;
close($childIn);
@@ -236,13 +247,6 @@
close($childErr) unless ($verbose || $showLeaks);
close(DEVNULL) unless ($verbose || $showLeaks);
- if ($result) {
- push @testsFailed, $test;
- }
- if ($timedOut) {
- push @testsTimedOut, $test;
- print possiblyColored("bold yellow", "TIMEOUT"), " $test\n";
- }
if ($timedOut || $result) {
return $timedOut || $result;
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
