Title: [198459] trunk/Source/WebInspectorUI
- Revision
- 198459
- Author
- [email protected]
- Date
- 2016-03-18 17:55:57 -0700 (Fri, 18 Mar 2016)
Log Message
Uncaught Exception: TypeError: undefined is not an object (evaluating 'this._treeOutlineDataGridSynchronizer.treeElementForDataGridNode')
https://bugs.webkit.org/show_bug.cgi?id=155671
<rdar://problem/25249401>
Patch by Joseph Pecoraro <[email protected]> on 2016-03-18
Reviewed by Timothy Hatcher.
* UserInterface/Views/TimelineDataGrid.js:
(WebInspector.TimelineDataGrid.prototype._sort):
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (198458 => 198459)
--- trunk/Source/WebInspectorUI/ChangeLog 2016-03-19 00:42:05 UTC (rev 198458)
+++ trunk/Source/WebInspectorUI/ChangeLog 2016-03-19 00:55:57 UTC (rev 198459)
@@ -1,5 +1,16 @@
2016-03-18 Joseph Pecoraro <[email protected]>
+ Uncaught Exception: TypeError: undefined is not an object (evaluating 'this._treeOutlineDataGridSynchronizer.treeElementForDataGridNode')
+ https://bugs.webkit.org/show_bug.cgi?id=155671
+ <rdar://problem/25249401>
+
+ Reviewed by Timothy Hatcher.
+
+ * UserInterface/Views/TimelineDataGrid.js:
+ (WebInspector.TimelineDataGrid.prototype._sort):
+
+2016-03-18 Joseph Pecoraro <[email protected]>
+
Web Inspector: Fix ObjectTree Map styling, key/value look cramped
https://bugs.webkit.org/show_bug.cgi?id=155668
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/TimelineDataGrid.js (198458 => 198459)
--- trunk/Source/WebInspectorUI/UserInterface/Views/TimelineDataGrid.js 2016-03-19 00:42:05 UTC (rev 198458)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/TimelineDataGrid.js 2016-03-19 00:55:57 UTC (rev 198459)
@@ -315,17 +315,19 @@
childDataGridNodes.sort(this._sortComparator.bind(this));
for (let dataGridNode of childDataGridNodes) {
- let treeElement = this._treeOutlineDataGridSynchronizer.treeElementForDataGridNode(dataGridNode);
- console.assert(treeElement);
+ if (this._treeOutlineDataGridSynchronizer) {
+ let treeElement = this._treeOutlineDataGridSynchronizer.treeElementForDataGridNode(dataGridNode);
+ console.assert(treeElement);
- if (parentTreeElement)
- parentTreeElement.appendChild(treeElement);
+ if (parentTreeElement)
+ parentTreeElement.appendChild(treeElement);
+ // Adding the tree element back to the tree outline subjects it to filters.
+ // Make sure we keep the hidden state in-sync while the synchronizer is disabled.
+ dataGridNode.element.classList.toggle("hidden", treeElement.hidden);
+ }
+
parentDataGridNode.appendChild(dataGridNode);
-
- // Adding the tree element back to the tree outline subjects it to filters.
- // Make sure we keep the hidden state in-sync while the synchronizer is disabled.
- dataGridNode.element.classList.toggle("hidden", treeElement.hidden);
}
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
