- Revision
- 198304
- Author
- [email protected]
- Date
- 2016-03-16 15:06:41 -0700 (Wed, 16 Mar 2016)
Log Message
check-webkit-style: should warn about blank lines after #include "config.h" in TestWebKitAPI
<http://webkit.org/b/155445>
Reviewed by Darin Adler.
* Scripts/webkitpy/style/checker.py:
(_PATH_RULES_SPECIFIER): Do not ignore "build/include*" checks
on TestWebKitAPI since this project uses a config.h header as of
r95188. Also remove references to WebKitAPITest, which ceased
to exist in r95944.
* Scripts/webkitpy/style/checker_unittest.py:
(GlobalVariablesTest.test_path_rules_specifier): Add tests.
Remove reference to WebKitAPITest project.
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (198303 => 198304)
--- trunk/Tools/ChangeLog 2016-03-16 21:49:26 UTC (rev 198303)
+++ trunk/Tools/ChangeLog 2016-03-16 22:06:41 UTC (rev 198304)
@@ -1,3 +1,20 @@
+2016-03-16 David Kilzer <[email protected]>
+
+ check-webkit-style: should warn about blank lines after #include "config.h" in TestWebKitAPI
+ <http://webkit.org/b/155445>
+
+ Reviewed by Darin Adler.
+
+ * Scripts/webkitpy/style/checker.py:
+ (_PATH_RULES_SPECIFIER): Do not ignore "build/include*" checks
+ on TestWebKitAPI since this project uses a config.h header as of
+ r95188. Also remove references to WebKitAPITest, which ceased
+ to exist in r95944.
+
+ * Scripts/webkitpy/style/checker_unittest.py:
+ (GlobalVariablesTest.test_path_rules_specifier): Add tests.
+ Remove reference to WebKitAPITest project.
+
2016-03-16 Tim Horton <[email protected]>
[mac] Printing test snapshots are upside-down after r198242
Modified: trunk/Tools/Scripts/webkitpy/style/checker.py (198303 => 198304)
--- trunk/Tools/Scripts/webkitpy/style/checker.py 2016-03-16 21:49:26 UTC (rev 198303)
+++ trunk/Tools/Scripts/webkitpy/style/checker.py 2016-03-16 22:06:41 UTC (rev 198304)
@@ -136,15 +136,13 @@
([# TestNetscapePlugIn has no config.h and uses funny names like
# NPP_SetWindow.
- os.path.join('Tools', 'DumpRenderTree', 'TestNetscapePlugIn'),
- # The API test harnesses have no config.h and use funny macros like
- # TEST_CLASS_NAME.
- os.path.join('Tools', 'WebKitAPITest'),
- os.path.join('Tools', 'TestWebKitAPI')],
+ os.path.join('Tools', 'DumpRenderTree', 'TestNetscapePlugIn')],
["-build/include",
"-readability/naming"]),
([# There is no clean way to avoid "yy_*" names used by flex.
- os.path.join('Source', 'WebCore', 'css', 'CSSParser.cpp')],
+ os.path.join('Source', 'WebCore', 'css', 'CSSParser.cpp'),
+ # TestWebKitAPI uses funny macros like EXPECT_WK_STREQ.
+ os.path.join('Tools', 'TestWebKitAPI')],
["-readability/naming"]),
([# The GTK+ APIs use GTK+ naming style, which includes
Modified: trunk/Tools/Scripts/webkitpy/style/checker_unittest.py (198303 => 198304)
--- trunk/Tools/Scripts/webkitpy/style/checker_unittest.py 2016-03-16 21:49:26 UTC (rev 198303)
+++ trunk/Tools/Scripts/webkitpy/style/checker_unittest.py 2016-03-16 22:06:41 UTC (rev 198304)
@@ -213,8 +213,14 @@
assertCheck("random_path.cpp",
"build/include")
- assertNoCheck(os.path.join('Tools', 'WebKitAPITest', 'main.cpp'),
+ assertNoCheck(os.path.join('Tools', 'DumpRenderTree', 'TestNetscapePlugIn', 'main.cpp'),
"build/include")
+ assertNoCheck(os.path.join('Tools', 'DumpRenderTree', 'TestNetscapePlugIn', 'main.cpp'),
+ "readability/naming")
+ assertCheck(os.path.join('Tools', 'TestWebKitAPI', 'Tests', 'WTF', 'RefLogger.cpp'),
+ "build/include")
+ assertNoCheck(os.path.join('Tools', 'TestWebKitAPI', 'Tests', 'mac', 'WillSendSubmitEvent.mm'),
+ "readability/naming")
assertCheck("random_path.cpp",
"readability/naming")
assertNoCheck(os.path.join('Source', 'WebKit', 'gtk', 'webkit', 'webkit.h'),
