Title: [198351] trunk/Websites/perf.webkit.org
- Revision
- 198351
- Author
- [email protected]
- Date
- 2016-03-17 13:48:28 -0700 (Thu, 17 Mar 2016)
Log Message
An analysis task should be closed if a progression cause is identified
https://bugs.webkit.org/show_bug.cgi?id=155549
Reviewed by Chris Dumez.
Since a progression is desirable, we should close an analysis task once its cause is identified.
Also fix some typos.
* init-database.sql: Fixed a typo.
* public/api/analysis-tasks.php:
* public/v3/models/analysis-task.js:
(AnalysisTask.prototype.dissociateBug): Renamed from dissociateBug.
* public/v3/pages/analysis-task-page.js:
(AnalysisTaskPage.prototype.render):
(AnalysisTaskPage.prototype._dissociateBug): Renamed from _dissociateBug.
(AnalysisTaskPage.prototype._dissociateCommit): Fixed the typo in the alert.
Modified Paths
Diff
Modified: trunk/Websites/perf.webkit.org/ChangeLog (198350 => 198351)
--- trunk/Websites/perf.webkit.org/ChangeLog 2016-03-17 20:46:57 UTC (rev 198350)
+++ trunk/Websites/perf.webkit.org/ChangeLog 2016-03-17 20:48:28 UTC (rev 198351)
@@ -1,3 +1,23 @@
+2016-03-17 Ryosuke Niwa <[email protected]>
+
+ An analysis task should be closed if a progression cause is identified
+ https://bugs.webkit.org/show_bug.cgi?id=155549
+
+ Reviewed by Chris Dumez.
+
+ Since a progression is desirable, we should close an analysis task once its cause is identified.
+
+ Also fix some typos.
+
+ * init-database.sql: Fixed a typo.
+ * public/api/analysis-tasks.php:
+ * public/v3/models/analysis-task.js:
+ (AnalysisTask.prototype.dissociateBug): Renamed from dissociateBug.
+ * public/v3/pages/analysis-task-page.js:
+ (AnalysisTaskPage.prototype.render):
+ (AnalysisTaskPage.prototype._dissociateBug): Renamed from _dissociateBug.
+ (AnalysisTaskPage.prototype._dissociateCommit): Fixed the typo in the alert.
+
2016-03-16 Ryosuke Niwa <[email protected]>
Analysis task page should allow specifying commits that caused or fixed a regression or a progression
Modified: trunk/Websites/perf.webkit.org/init-database.sql (198350 => 198351)
--- trunk/Websites/perf.webkit.org/init-database.sql 2016-03-17 20:46:57 UTC (rev 198350)
+++ trunk/Websites/perf.webkit.org/init-database.sql 2016-03-17 20:48:28 UTC (rev 198351)
@@ -206,7 +206,7 @@
CREATE TABLE task_commits (
taskcommit_task integer NOT NULL REFERENCES analysis_tasks ON DELETE CASCADE,
taskcommit_commit integer NOT NULL REFERENCES commits ON DELETE CASCADE,
- taskcommit_is_fix boolean NOT NULL
+ taskcommit_is_fix boolean NOT NULL,
CONSTRAINT task_commit_must_be_unique UNIQUE(taskcommit_task, taskcommit_commit));
CREATE TABLE bugs (
Modified: trunk/Websites/perf.webkit.org/public/api/analysis-tasks.php (198350 => 198351)
--- trunk/Websites/perf.webkit.org/public/api/analysis-tasks.php 2016-03-17 20:46:57 UTC (rev 198350)
+++ trunk/Websites/perf.webkit.org/public/api/analysis-tasks.php 2016-03-17 20:48:28 UTC (rev 198351)
@@ -116,7 +116,7 @@
$category = 'unconfirmed';
$result = $task['result'];
- if ($result == 'unchanged' || $result == 'inconclusive' || $task['fixes'])
+ if ($result == 'unchanged' || $result == 'inconclusive' || $task['fixes'] || ($result == 'progression' && $task['causes']))
$category = 'closed';
else if ($task['causes'])
$category = 'identified';
Modified: trunk/Websites/perf.webkit.org/public/v3/models/analysis-task.js (198350 => 198351)
--- trunk/Websites/perf.webkit.org/public/v3/models/analysis-task.js 2016-03-17 20:46:57 UTC (rev 198350)
+++ trunk/Websites/perf.webkit.org/public/v3/models/analysis-task.js 2016-03-17 20:48:28 UTC (rev 198351)
@@ -100,7 +100,7 @@
});
}
- disassociateBug(bug)
+ dissociateBug(bug)
{
console.assert(bug instanceof Bug);
console.assert(this.bugs().includes(bug));
Modified: trunk/Websites/perf.webkit.org/public/v3/pages/analysis-task-page.js (198350 => 198351)
--- trunk/Websites/perf.webkit.org/public/v3/pages/analysis-task-page.js 2016-03-17 20:46:57 UTC (rev 198350)
+++ trunk/Websites/perf.webkit.org/public/v3/pages/analysis-task-page.js 2016-03-17 20:48:28 UTC (rev 198351)
@@ -238,7 +238,7 @@
var self = this;
this._bugList.setList(this._task.bugs().map(function (bug) {
return new MutableListItem(bug.bugTracker(), bug.label(), bug.title(), bug.url(),
- 'Disassociate this bug', self._disassociateBug.bind(self, bug));
+ 'Disassociate this bug', self._dissociateBug.bind(self, bug));
}));
this._causeList.setList(this._task.causes().map(this._makeCommitListItem.bind(this)));
@@ -478,12 +478,12 @@
});
}
- _disassociateBug(bug)
+ _dissociateBug(bug)
{
var render = this.render.bind(this);
- return this._task.disassociateBug(bug).then(render, function (error) {
+ return this._task.dissociateBug(bug).then(render, function (error) {
render();
- alert('Failed to disassociate the bug: ' + error);
+ alert('Failed to dissociate the bug: ' + error);
});
}
@@ -501,7 +501,7 @@
var render = this.render.bind(this);
return this._task.dissociateCommit(commit).then(render, function (error) {
render();
- alert('Failed to disassociate the commit: ' + error);
+ alert('Failed to dissociate the commit: ' + error);
});
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
