Title: [198441] trunk/Source/WebInspectorUI
- Revision
- 198441
- Author
- [email protected]
- Date
- 2016-03-18 13:23:10 -0700 (Fri, 18 Mar 2016)
Log Message
Web Inspector: Timeline reset issues after Navigation Sidebar removal
https://bugs.webkit.org/show_bug.cgi?id=155658
<rdar://problem/25245292>
Patch by Joseph Pecoraro <[email protected]> on 2016-03-18
Reviewed by Timothy Hatcher.
* UserInterface/Views/CircleChart.js:
(WebInspector.CircleChart.prototype.set values):
If the segments have never been set the values list will be empty.
Allow clearing to set empty values again.
* UserInterface/Views/ScriptClusterTimelineView.js:
(WebInspector.ScriptClusterTimelineView.prototype._scriptClusterViewCurrentContentViewDidChange):
(WebInspector.ScriptClusterTimelineView):
Timeline sidebar no longer exists. Replace with the common
FIXME added to the other TimelineViews.
* UserInterface/Views/TimelineView.js:
(WebInspector.TimelineView.prototype.reset):
Timeline sidebar and content tree outline no longer exist.
Replace with the common comment indicating this method
is intended for subclasses.
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (198440 => 198441)
--- trunk/Source/WebInspectorUI/ChangeLog 2016-03-18 19:58:28 UTC (rev 198440)
+++ trunk/Source/WebInspectorUI/ChangeLog 2016-03-18 20:23:10 UTC (rev 198441)
@@ -1,3 +1,28 @@
+2016-03-18 Joseph Pecoraro <[email protected]>
+
+ Web Inspector: Timeline reset issues after Navigation Sidebar removal
+ https://bugs.webkit.org/show_bug.cgi?id=155658
+ <rdar://problem/25245292>
+
+ Reviewed by Timothy Hatcher.
+
+ * UserInterface/Views/CircleChart.js:
+ (WebInspector.CircleChart.prototype.set values):
+ If the segments have never been set the values list will be empty.
+ Allow clearing to set empty values again.
+
+ * UserInterface/Views/ScriptClusterTimelineView.js:
+ (WebInspector.ScriptClusterTimelineView.prototype._scriptClusterViewCurrentContentViewDidChange):
+ (WebInspector.ScriptClusterTimelineView):
+ Timeline sidebar no longer exists. Replace with the common
+ FIXME added to the other TimelineViews.
+
+ * UserInterface/Views/TimelineView.js:
+ (WebInspector.TimelineView.prototype.reset):
+ Timeline sidebar and content tree outline no longer exist.
+ Replace with the common comment indicating this method
+ is intended for subclasses.
+
2016-03-17 Carlos Garcia Campos <[email protected]>
REGRESSION (r197724): [GTK] Web Inspector: Images being blocked by CSP 2.0
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/CircleChart.js (198440 => 198441)
--- trunk/Source/WebInspectorUI/UserInterface/Views/CircleChart.js 2016-03-18 19:58:28 UTC (rev 198440)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/CircleChart.js 2016-03-18 20:23:10 UTC (rev 198441)
@@ -116,7 +116,7 @@
set values(values)
{
- console.assert(values.length === this._pathElements.length, "Should have the same number of values as segments");
+ console.assert(!values.length || values.length === this._pathElements.length, "Should have the same number of values as segments");
this._values = values;
this._total = 0;
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ScriptClusterTimelineView.js (198440 => 198441)
--- trunk/Source/WebInspectorUI/UserInterface/Views/ScriptClusterTimelineView.js 2016-03-18 19:58:28 UTC (rev 198440)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ScriptClusterTimelineView.js 2016-03-18 20:23:10 UTC (rev 198441)
@@ -194,7 +194,7 @@
currentContentView.endTime = previousContentView.endTime;
currentContentView.currentTime = previousContentView.currentTime;
- currentContentView.timelineSidebarPanel.updateFilter();
+ // FIXME: <https://webkit.org/b/154924> Web Inspector: hook up grid row filtering in the new Timelines UI
}
};
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/TimelineView.js (198440 => 198441)
--- trunk/Source/WebInspectorUI/UserInterface/Views/TimelineView.js 2016-03-18 19:58:28 UTC (rev 198440)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/TimelineView.js 2016-03-18 20:23:10 UTC (rev 198441)
@@ -134,8 +134,7 @@
reset()
{
- this._contentTreeOutline.removeChildren();
- this._timelineSidebarPanel.hideEmptyContentPlaceholder();
+ // Implemented by sub-classes if needed.
}
filterDidChange()
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
