Title: [198298] trunk/Source/WebKit2
- Revision
- 198298
- Author
- [email protected]
- Date
- 2016-03-16 13:17:00 -0700 (Wed, 16 Mar 2016)
Log Message
REGRESSION (r192184): CleanMyDrive 2's tutorial window is blank
https://bugs.webkit.org/show_bug.cgi?id=155550
<rdar://problem/24250689>
Reviewed by Dan Bernstein.
* UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _setDrawsTransparentBackground:]):
The app is using this SPI via key-value coding, so just keeping the implementation
is sufficient to make AppKit stop throwing an undefined key exception.
Log once that this is deprecated (... it's also SPI) and then forward to setDrawsBackground.
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (198297 => 198298)
--- trunk/Source/WebKit2/ChangeLog 2016-03-16 20:13:38 UTC (rev 198297)
+++ trunk/Source/WebKit2/ChangeLog 2016-03-16 20:17:00 UTC (rev 198298)
@@ -1,3 +1,17 @@
+2016-03-16 Tim Horton <[email protected]>
+
+ REGRESSION (r192184): CleanMyDrive 2's tutorial window is blank
+ https://bugs.webkit.org/show_bug.cgi?id=155550
+ <rdar://problem/24250689>
+
+ Reviewed by Dan Bernstein.
+
+ * UIProcess/API/Cocoa/WKWebView.mm:
+ (-[WKWebView _setDrawsTransparentBackground:]):
+ The app is using this SPI via key-value coding, so just keeping the implementation
+ is sufficient to make AppKit stop throwing an undefined key exception.
+ Log once that this is deprecated (... it's also SPI) and then forward to setDrawsBackground.
+
2016-03-16 Daniel Bates <[email protected]>
<video> and <audio> elements do not obey Content Security Policy on redirect
Modified: trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm (198297 => 198298)
--- trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm 2016-03-16 20:13:38 UTC (rev 198297)
+++ trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm 2016-03-16 20:17:00 UTC (rev 198298)
@@ -4183,6 +4183,17 @@
_impl->setDrawsBackground(drawsBackground);
}
+- (void)_setDrawsTransparentBackground:(BOOL)drawsTransparentBackground
+{
+ static BOOL hasLoggedDeprecationWarning;
+ if (!hasLoggedDeprecationWarning) {
+ // See bug 155550 for details.
+ NSLog(@"-[WKWebView _setDrawsTransparentBackground:] is deprecated and should not be used.");
+ hasLoggedDeprecationWarning = YES;
+ }
+ [self _setDrawsBackground:!drawsTransparentBackground];
+}
+
#if WK_API_ENABLED
- (NSView *)_inspectorAttachmentView
{
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
