Title: [198548] trunk/Source/WebInspectorUI
- Revision
- 198548
- Author
- [email protected]
- Date
- 2016-03-22 13:29:40 -0700 (Tue, 22 Mar 2016)
Log Message
Web Inspector: remove the remaining TimelineSidebarPanel references
https://bugs.webkit.org/show_bug.cgi?id=155765
<rdar://problem/25296980>
Reviewed by Timothy Hatcher.
Remove dead code from TimelineView and TimelineTabContentView.
* UserInterface/Views/OverviewTimelineView.js:
(WebInspector.OverviewTimelineView.prototype.canShowContentViewForTreeElement): Deleted.
(WebInspector.OverviewTimelineView.prototype.showContentViewForTreeElement): Deleted.
* UserInterface/Views/RenderingFrameTimelineView.js:
(WebInspector.RenderingFrameTimelineView.prototype.canShowContentViewForTreeElement): Deleted.
(WebInspector.RenderingFrameTimelineView.prototype.showContentViewForTreeElement): Deleted.
* UserInterface/Views/ScriptDetailsTimelineView.js:
(WebInspector.ScriptDetailsTimelineView.prototype.canShowContentViewForTreeElement): Deleted.
(WebInspector.ScriptDetailsTimelineView.prototype.showContentViewForTreeElement): Deleted.
* UserInterface/Views/TimelineTabContentView.js:
(WebInspector.TimelineTabContentView):
* UserInterface/Views/TimelineView.js:
(WebInspector.TimelineView.prototype.canShowContentViewForTreeElement): Deleted.
(WebInspector.TimelineView.prototype.showContentViewForTreeElement): Deleted.
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (198547 => 198548)
--- trunk/Source/WebInspectorUI/ChangeLog 2016-03-22 20:21:28 UTC (rev 198547)
+++ trunk/Source/WebInspectorUI/ChangeLog 2016-03-22 20:29:40 UTC (rev 198548)
@@ -1,5 +1,34 @@
2016-03-22 Matt Baker <[email protected]>
+ Web Inspector: remove the remaining TimelineSidebarPanel references
+ https://bugs.webkit.org/show_bug.cgi?id=155765
+ <rdar://problem/25296980>
+
+ Reviewed by Timothy Hatcher.
+
+ Remove dead code from TimelineView and TimelineTabContentView.
+
+ * UserInterface/Views/OverviewTimelineView.js:
+ (WebInspector.OverviewTimelineView.prototype.canShowContentViewForTreeElement): Deleted.
+ (WebInspector.OverviewTimelineView.prototype.showContentViewForTreeElement): Deleted.
+
+ * UserInterface/Views/RenderingFrameTimelineView.js:
+ (WebInspector.RenderingFrameTimelineView.prototype.canShowContentViewForTreeElement): Deleted.
+ (WebInspector.RenderingFrameTimelineView.prototype.showContentViewForTreeElement): Deleted.
+
+ * UserInterface/Views/ScriptDetailsTimelineView.js:
+ (WebInspector.ScriptDetailsTimelineView.prototype.canShowContentViewForTreeElement): Deleted.
+ (WebInspector.ScriptDetailsTimelineView.prototype.showContentViewForTreeElement): Deleted.
+
+ * UserInterface/Views/TimelineTabContentView.js:
+ (WebInspector.TimelineTabContentView):
+
+ * UserInterface/Views/TimelineView.js:
+ (WebInspector.TimelineView.prototype.canShowContentViewForTreeElement): Deleted.
+ (WebInspector.TimelineView.prototype.showContentViewForTreeElement): Deleted.
+
+2016-03-22 Matt Baker <[email protected]>
+
Web Inspector: Timelines UI redesign: Provide a way to configure which instruments to use
https://bugs.webkit.org/show_bug.cgi?id=153672
<rdar://problem/24417575>
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/OverviewTimelineView.js (198547 => 198548)
--- trunk/Source/WebInspectorUI/UserInterface/Views/OverviewTimelineView.js 2016-03-22 20:21:28 UTC (rev 198547)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/OverviewTimelineView.js 2016-03-22 20:29:40 UTC (rev 198548)
@@ -128,33 +128,6 @@
dataGridNode.revealAndSelect();
}
- canShowContentViewForTreeElement(treeElement)
- {
- if (treeElement instanceof WebInspector.ResourceTreeElement || treeElement instanceof WebInspector.ScriptTreeElement)
- return true;
- return super.canShowContentViewForTreeElement(treeElement);
- }
-
- showContentViewForTreeElement(treeElement)
- {
- if (treeElement instanceof WebInspector.ResourceTreeElement || treeElement instanceof WebInspector.ScriptTreeElement) {
- WebInspector.showSourceCode(treeElement.representedObject);
- return;
- }
-
- if (!(treeElement instanceof WebInspector.SourceCodeTimelineTreeElement)) {
- console.error("Unknown tree element selected.");
- return;
- }
-
- if (!treeElement.sourceCodeTimeline.sourceCodeLocation) {
- this.timelineSidebarPanel.showTimelineOverview();
- return;
- }
-
- WebInspector.showOriginalOrFormattedSourceCodeLocation(treeElement.sourceCodeTimeline.sourceCodeLocation);
- }
-
layout()
{
let oldZeroTime = this._timelineRuler.zeroTime;
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/RenderingFrameTimelineView.js (198547 => 198548)
--- trunk/Source/WebInspectorUI/UserInterface/Views/RenderingFrameTimelineView.js 2016-03-22 20:21:28 UTC (rev 198547)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/RenderingFrameTimelineView.js 2016-03-22 20:29:40 UTC (rev 198548)
@@ -180,24 +180,6 @@
// Protected
- canShowContentViewForTreeElement(treeElement)
- {
- if (treeElement instanceof WebInspector.ProfileNodeTreeElement)
- return !!treeElement.profileNode.sourceCodeLocation;
- return super.canShowContentViewForTreeElement(treeElement);
- }
-
- showContentViewForTreeElement(treeElement)
- {
- if (treeElement instanceof WebInspector.ProfileNodeTreeElement) {
- if (treeElement.profileNode.sourceCodeLocation)
- WebInspector.showOriginalOrFormattedSourceCodeLocation(treeElement.profileNode.sourceCodeLocation);
- return;
- }
-
- super.showContentViewForTreeElement(treeElement);
- }
-
dataGridNodePathComponentSelected(event)
{
let dataGridNode = event.data.pathComponent.timelineDataGridNode;
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ScriptDetailsTimelineView.js (198547 => 198548)
--- trunk/Source/WebInspectorUI/UserInterface/Views/ScriptDetailsTimelineView.js 2016-03-22 20:21:28 UTC (rev 198547)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ScriptDetailsTimelineView.js 2016-03-22 20:29:40 UTC (rev 198548)
@@ -147,24 +147,6 @@
// Protected
- canShowContentViewForTreeElement(treeElement)
- {
- if (treeElement instanceof WebInspector.ProfileNodeTreeElement)
- return !!treeElement.profileNode.sourceCodeLocation;
- return super.canShowContentViewForTreeElement(treeElement);
- }
-
- showContentViewForTreeElement(treeElement)
- {
- if (treeElement instanceof WebInspector.ProfileNodeTreeElement) {
- if (treeElement.profileNode.sourceCodeLocation)
- WebInspector.showOriginalOrFormattedSourceCodeLocation(treeElement.profileNode.sourceCodeLocation);
- return;
- }
-
- super.showContentViewForTreeElement(treeElement);
- }
-
dataGridNodePathComponentSelected(event)
{
let dataGridNode = event.data.pathComponent.timelineDataGridNode;
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/TimelineTabContentView.js (198547 => 198548)
--- trunk/Source/WebInspectorUI/UserInterface/Views/TimelineTabContentView.js 2016-03-22 20:21:28 UTC (rev 198547)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/TimelineTabContentView.js 2016-03-22 20:29:40 UTC (rev 198548)
@@ -31,7 +31,7 @@
let tabBarItem = new WebInspector.TabBarItem(image, title);
let detailsSidebarPanels = [WebInspector.resourceDetailsSidebarPanel, WebInspector.probeDetailsSidebarPanel];
- super(identifier || "timeline", "timeline", tabBarItem, WebInspector.TimelineSidebarPanel, detailsSidebarPanels);
+ super(identifier || "timeline", "timeline", tabBarItem, null, detailsSidebarPanels);
// Maintain an invisible tree outline containing tree elements for all recordings.
// The visible recording's tree element is selected when the content view changes.
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/TimelineView.js (198547 => 198548)
--- trunk/Source/WebInspectorUI/UserInterface/Views/TimelineView.js 2016-03-22 20:21:28 UTC (rev 198547)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/TimelineView.js 2016-03-22 20:29:40 UTC (rev 198548)
@@ -164,33 +164,6 @@
// Protected
- canShowContentViewForTreeElement(treeElement)
- {
- // Implemented by sub-classes if needed.
-
- if (treeElement instanceof WebInspector.TimelineRecordTreeElement)
- return !!treeElement.sourceCodeLocation;
- return false;
- }
-
- showContentViewForTreeElement(treeElement)
- {
- // Implemented by sub-classes if needed.
-
- if (!(treeElement instanceof WebInspector.TimelineRecordTreeElement)) {
- console.error("Unknown tree element selected.", treeElement);
- return;
- }
-
- var sourceCodeLocation = treeElement.sourceCodeLocation;
- if (!sourceCodeLocation) {
- this._timelineSidebarPanel.showTimelineViewForTimeline(this.representedObject);
- return;
- }
-
- WebInspector.showOriginalOrFormattedSourceCodeLocation(sourceCodeLocation);
- }
-
userSelectedRecordFromOverview(timelineRecord)
{
// Implemented by sub-classes if needed.
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
