Title: [198552] trunk/Source/WebInspectorUI
- Revision
- 198552
- Author
- [email protected]
- Date
- 2016-03-22 14:28:43 -0700 (Tue, 22 Mar 2016)
Log Message
Web Inspector: REGRESSION: Shift + Click on record button should create a new recording
https://bugs.webkit.org/show_bug.cgi?id=155763
Patch by Joseph Pecoraro <[email protected]> on 2016-03-22
Reviewed by Timothy Hatcher.
* UserInterface/Views/TimelineTabContentView.js:
(WebInspector.TimelineTabContentView.prototype._recordButtonClicked):
Use the shiftKey from the DOM Event.
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (198551 => 198552)
--- trunk/Source/WebInspectorUI/ChangeLog 2016-03-22 21:27:07 UTC (rev 198551)
+++ trunk/Source/WebInspectorUI/ChangeLog 2016-03-22 21:28:43 UTC (rev 198552)
@@ -1,5 +1,16 @@
2016-03-22 Joseph Pecoraro <[email protected]>
+ Web Inspector: REGRESSION: Shift + Click on record button should create a new recording
+ https://bugs.webkit.org/show_bug.cgi?id=155763
+
+ Reviewed by Timothy Hatcher.
+
+ * UserInterface/Views/TimelineTabContentView.js:
+ (WebInspector.TimelineTabContentView.prototype._recordButtonClicked):
+ Use the shiftKey from the DOM Event.
+
+2016-03-22 Joseph Pecoraro <[email protected]>
+
Web Inspector: Switching Away and Back to Timelines Tab may select a different Timeline
https://bugs.webkit.org/show_bug.cgi?id=155742
<rdar://problem/25284330>
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/TimelineTabContentView.js (198551 => 198552)
--- trunk/Source/WebInspectorUI/UserInterface/Views/TimelineTabContentView.js 2016-03-22 21:27:07 UTC (rev 198551)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/TimelineTabContentView.js 2016-03-22 21:28:43 UTC (rev 198552)
@@ -393,8 +393,9 @@
_recordButtonClicked(event)
{
+ let shouldCreateNewRecording = window.event ? window.event.shiftKey : false;
this._recordButton.toggled = !WebInspector.timelineManager.isCapturing();
- this._toggleRecording(event.shiftKey);
+ this._toggleRecording(shouldCreateNewRecording);
}
_recordingsTreeSelectionDidChange(event)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
