Title: [198602] trunk/Source/WebInspectorUI
- Revision
- 198602
- Author
- [email protected]
- Date
- 2016-03-23 15:45:55 -0700 (Wed, 23 Mar 2016)
Log Message
Web Inspector: REGRESSION: Timeline Reset does not clear datagrids
https://bugs.webkit.org/show_bug.cgi?id=155804
Patch by Joseph Pecoraro <[email protected]> on 2016-03-23
Reviewed by Timothy Hatcher.
* UserInterface/Views/HeapAllocationsTimelineView.js:
(WebInspector.HeapAllocationsTimelineView.prototype.shown):
(WebInspector.HeapAllocationsTimelineView.prototype.hidden):
(WebInspector.HeapAllocationsTimelineView.prototype.closed):
(WebInspector.HeapAllocationsTimelineView.prototype.reset):
Although we don't use the popover features of TimelineDataGrid,
be a good citizen and call methods on the datagrid.
* UserInterface/Views/OverviewTimelineView.js:
(WebInspector.OverviewTimelineView.prototype.reset):
Clear the datagrid on reset.
* UserInterface/Views/TimelineDataGrid.js:
(WebInspector.TimelineDataGrid.prototype.reset):
Clear the datagrid on reset.
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (198601 => 198602)
--- trunk/Source/WebInspectorUI/ChangeLog 2016-03-23 22:45:15 UTC (rev 198601)
+++ trunk/Source/WebInspectorUI/ChangeLog 2016-03-23 22:45:55 UTC (rev 198602)
@@ -1,5 +1,28 @@
2016-03-23 Joseph Pecoraro <[email protected]>
+ Web Inspector: REGRESSION: Timeline Reset does not clear datagrids
+ https://bugs.webkit.org/show_bug.cgi?id=155804
+
+ Reviewed by Timothy Hatcher.
+
+ * UserInterface/Views/HeapAllocationsTimelineView.js:
+ (WebInspector.HeapAllocationsTimelineView.prototype.shown):
+ (WebInspector.HeapAllocationsTimelineView.prototype.hidden):
+ (WebInspector.HeapAllocationsTimelineView.prototype.closed):
+ (WebInspector.HeapAllocationsTimelineView.prototype.reset):
+ Although we don't use the popover features of TimelineDataGrid,
+ be a good citizen and call methods on the datagrid.
+
+ * UserInterface/Views/OverviewTimelineView.js:
+ (WebInspector.OverviewTimelineView.prototype.reset):
+ Clear the datagrid on reset.
+
+ * UserInterface/Views/TimelineDataGrid.js:
+ (WebInspector.TimelineDataGrid.prototype.reset):
+ Clear the datagrid on reset.
+
+2016-03-23 Joseph Pecoraro <[email protected]>
+
Web Inspector: Uncaught exceptions closing Timeline tab
https://bugs.webkit.org/show_bug.cgi?id=155805
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/HeapAllocationsTimelineView.js (198601 => 198602)
--- trunk/Source/WebInspectorUI/UserInterface/Views/HeapAllocationsTimelineView.js 2016-03-23 22:45:15 UTC (rev 198601)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/HeapAllocationsTimelineView.js 2016-03-23 22:45:55 UTC (rev 198602)
@@ -196,6 +196,8 @@
{
super.shown();
+ this._dataGrid.shown();
+
if (!this._showingSnapshotList)
this._contentViewContainer.shown();
}
@@ -204,6 +206,8 @@
{
super.hidden();
+ this._dataGrid.hidden();
+
if (!this._showingSnapshotList)
this._contentViewContainer.hidden();
}
@@ -213,6 +217,8 @@
console.assert(this.representedObject instanceof WebInspector.Timeline);
this.representedObject.removeEventListener(null, null, this);
+ this._dataGrid.closed();
+
this._contentViewContainer.closeAllContentViews();
}
@@ -234,6 +240,8 @@
{
super.reset();
+ this._dataGrid.reset();
+
this.showHeapSnapshotList();
this._pendingRecords = [];
this._updateCompareHeapSnapshotButton();
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/OverviewTimelineView.js (198601 => 198602)
--- trunk/Source/WebInspectorUI/UserInterface/Views/OverviewTimelineView.js 2016-03-23 22:45:15 UTC (rev 198601)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/OverviewTimelineView.js 2016-03-23 22:45:55 UTC (rev 198602)
@@ -115,6 +115,8 @@
{
super.reset();
+ this._dataGrid.removeChildren();
+
this._pendingRepresentedObjects = [];
}
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/TimelineDataGrid.js (198601 => 198602)
--- trunk/Source/WebInspectorUI/UserInterface/Views/TimelineDataGrid.js 2016-03-23 22:45:15 UTC (rev 198601)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/TimelineDataGrid.js 2016-03-23 22:45:55 UTC (rev 198602)
@@ -83,6 +83,9 @@
{
// May be overridden by subclasses. If so, they should call the superclass.
+ if (!this._treeOutlineDataGridSynchronizer)
+ this.removeChildren();
+
this._hidePopover();
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
