Title: [198607] trunk
- Revision
- 198607
- Author
- [email protected]
- Date
- 2016-03-23 17:13:24 -0700 (Wed, 23 Mar 2016)
Log Message
Unreviewed, rolling out r198538.
https://bugs.webkit.org/show_bug.cgi?id=155819
Broke two API tests on iOS simulator (Requested by ap on
#webkit).
Reverted changeset:
"Media elements allowed to play without a user gesture, but
requiring fullscreen playback, should not be allowed to
autoplay."
https://bugs.webkit.org/show_bug.cgi?id=155599
http://trac.webkit.org/changeset/198538
Modified Paths
Removed Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (198606 => 198607)
--- trunk/LayoutTests/ChangeLog 2016-03-24 00:12:05 UTC (rev 198606)
+++ trunk/LayoutTests/ChangeLog 2016-03-24 00:13:24 UTC (rev 198607)
@@ -1,5 +1,21 @@
2016-03-23 Commit Queue <[email protected]>
+ Unreviewed, rolling out r198538.
+ https://bugs.webkit.org/show_bug.cgi?id=155819
+
+ Broke two API tests on iOS simulator (Requested by ap on
+ #webkit).
+
+ Reverted changeset:
+
+ "Media elements allowed to play without a user gesture, but
+ requiring fullscreen playback, should not be allowed to
+ autoplay."
+ https://bugs.webkit.org/show_bug.cgi?id=155599
+ http://trac.webkit.org/changeset/198538
+
+2016-03-23 Commit Queue <[email protected]>
+
Unreviewed, rolling out r198582.
https://bugs.webkit.org/show_bug.cgi?id=155812
Deleted: trunk/LayoutTests/media/video-autoplay-allowed-but-fullscreen-required-expected.txt (198606 => 198607)
--- trunk/LayoutTests/media/video-autoplay-allowed-but-fullscreen-required-expected.txt 2016-03-24 00:12:05 UTC (rev 198606)
+++ trunk/LayoutTests/media/video-autoplay-allowed-but-fullscreen-required-expected.txt 2016-03-24 00:13:24 UTC (rev 198607)
@@ -1,5 +0,0 @@
-RUN(internals.settings.setAllowsInlineMediaPlayback(false))
-EVENT(canplaythrough)
-Video did not begin playing OK
-END OF TEST
-
Deleted: trunk/LayoutTests/media/video-autoplay-allowed-but-fullscreen-required.html (198606 => 198607)
--- trunk/LayoutTests/media/video-autoplay-allowed-but-fullscreen-required.html 2016-03-24 00:12:05 UTC (rev 198606)
+++ trunk/LayoutTests/media/video-autoplay-allowed-but-fullscreen-required.html 2016-03-24 00:13:24 UTC (rev 198607)
@@ -1,31 +0,0 @@
-<!DOCTYPE html>
-<html>
-<head>
- <title>video-main-content-allow</title>
- <script src=""
- <script src=""
- <script>
- function go() {
- run('internals.settings.setAllowsInlineMediaPlayback(false)');
- video = document.createElement('video');
- document.body.appendChild(video);
-
- video.src = "" 'content/test');
- waitForEvent('canplaythrough', canPlayThrough);
- }
-
- function canPlayThrough() {
- video.play();
- waitForEventAndFail('playing');
- setTimeout(didNotPlay, 100);
- }
-
- function didNotPlay() {
- logResult(true, "Video did not begin playing");
- endTest();
- }
- </script>
-</head>
-<body _onload_="go()">
-</body>
-</html>
\ No newline at end of file
Modified: trunk/Source/WebCore/ChangeLog (198606 => 198607)
--- trunk/Source/WebCore/ChangeLog 2016-03-24 00:12:05 UTC (rev 198606)
+++ trunk/Source/WebCore/ChangeLog 2016-03-24 00:13:24 UTC (rev 198607)
@@ -1,3 +1,19 @@
+2016-03-23 Commit Queue <[email protected]>
+
+ Unreviewed, rolling out r198538.
+ https://bugs.webkit.org/show_bug.cgi?id=155819
+
+ Broke two API tests on iOS simulator (Requested by ap on
+ #webkit).
+
+ Reverted changeset:
+
+ "Media elements allowed to play without a user gesture, but
+ requiring fullscreen playback, should not be allowed to
+ autoplay."
+ https://bugs.webkit.org/show_bug.cgi?id=155599
+ http://trac.webkit.org/changeset/198538
+
2016-03-23 Simon Fraser <[email protected]>
Change the paint count indicator to indicate whether a layer is opaque
Modified: trunk/Source/WebCore/html/MediaElementSession.cpp (198606 => 198607)
--- trunk/Source/WebCore/html/MediaElementSession.cpp 2016-03-24 00:12:05 UTC (rev 198606)
+++ trunk/Source/WebCore/html/MediaElementSession.cpp 2016-03-24 00:13:24 UTC (rev 198607)
@@ -146,11 +146,6 @@
if (pageExplicitlyAllowsElementToAutoplayInline(element))
return true;
- if (requiresFullscreenForVideoPlayback(element) && !ScriptController::processingUserGestureForMedia()) {
- LOG(Media, "MediaElementSession::playbackPermitted - returning FALSE");
- return false;
- }
-
if (m_restrictions & OverrideUserGestureRequirementForMainContent && updateIsMainContent())
return true;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
