Title: [198618] trunk/Source/WebInspectorUI
- Revision
- 198618
- Author
- [email protected]
- Date
- 2016-03-23 23:32:27 -0700 (Wed, 23 Mar 2016)
Log Message
Web Inspector: Timeline range selection changes with ProfileView should not cause navigation bar items to flicker
https://bugs.webkit.org/show_bug.cgi?id=155834
Patch by Joseph Pecoraro <[email protected]> on 2016-03-23
Reviewed by Timothy Hatcher.
* UserInterface/Views/ProfileView.js:
(WebInspector.ProfileView.prototype._recreate):
The only reason our selection path components would change is if we
had focus nodes before and do not anymore.
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (198617 => 198618)
--- trunk/Source/WebInspectorUI/ChangeLog 2016-03-24 05:16:56 UTC (rev 198617)
+++ trunk/Source/WebInspectorUI/ChangeLog 2016-03-24 06:32:27 UTC (rev 198618)
@@ -1,5 +1,17 @@
2016-03-23 Joseph Pecoraro <[email protected]>
+ Web Inspector: Timeline range selection changes with ProfileView should not cause navigation bar items to flicker
+ https://bugs.webkit.org/show_bug.cgi?id=155834
+
+ Reviewed by Timothy Hatcher.
+
+ * UserInterface/Views/ProfileView.js:
+ (WebInspector.ProfileView.prototype._recreate):
+ The only reason our selection path components would change is if we
+ had focus nodes before and do not anymore.
+
+2016-03-23 Joseph Pecoraro <[email protected]>
+
Web Inspector: Allow clicking the Timeline in Editing Mode to toggle the checkbox
https://bugs.webkit.org/show_bug.cgi?id=155815
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ProfileView.js (198617 => 198618)
--- trunk/Source/WebInspectorUI/UserInterface/Views/ProfileView.js 2016-03-24 05:16:56 UTC (rev 198617)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ProfileView.js 2016-03-24 06:32:27 UTC (rev 198618)
@@ -129,13 +129,16 @@
_recreate()
{
+ let hadFocusNodes = this.hasFocusNodes();
+
let sortComparator = WebInspector.ProfileDataGridTree.buildSortComparator(this._dataGrid.sortColumnIdentifier, this._dataGrid.sortOrder);
this._profileDataGridTree = new WebInspector.ProfileDataGridTree(this._callingContextTree, this._startTime, this._endTime, sortComparator);
this._profileDataGridTree.addEventListener(WebInspector.ProfileDataGridTree.Event.FocusChanged, this._dataGridTreeFocusChanged, this);
this._profileDataGridTree.addEventListener(WebInspector.ProfileDataGridTree.Event.ModifiersChanged, this._dataGridTreeModifiersChanged, this);
this._repopulateDataGridFromTree();
- this.dispatchEventToListeners(WebInspector.ContentView.Event.SelectionPathComponentsDidChange);
+ if (hadFocusNodes)
+ this.dispatchEventToListeners(WebInspector.ContentView.Event.SelectionPathComponentsDidChange);
}
_repopulateDataGridFromTree(skipRefresh)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
