Title: [198629] trunk/Source/WebKit2
- Revision
- 198629
- Author
- [email protected]
- Date
- 2016-03-24 10:07:54 -0700 (Thu, 24 Mar 2016)
Log Message
Fix null dereferencing in NetworkLoad::continueCanAuthenticateAgainstProtectionSpace
https://bugs.webkit.org/show_bug.cgi?id=155799
rdar://25289012
Reviewed by Tim Horton.
* NetworkProcess/NetworkLoad.cpp:
(WebKit::NetworkLoad::continueCanAuthenticateAgainstProtectionSpace):
Null-check all the things!
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (198628 => 198629)
--- trunk/Source/WebKit2/ChangeLog 2016-03-24 17:01:10 UTC (rev 198628)
+++ trunk/Source/WebKit2/ChangeLog 2016-03-24 17:07:54 UTC (rev 198629)
@@ -1,3 +1,15 @@
+2016-03-24 Alex Christensen <[email protected]>
+
+ Fix null dereferencing in NetworkLoad::continueCanAuthenticateAgainstProtectionSpace
+ https://bugs.webkit.org/show_bug.cgi?id=155799
+ rdar://25289012
+
+ Reviewed by Tim Horton.
+
+ * NetworkProcess/NetworkLoad.cpp:
+ (WebKit::NetworkLoad::continueCanAuthenticateAgainstProtectionSpace):
+ Null-check all the things!
+
2016-03-23 Tim Horton <[email protected]>
MiniBrowser doesn't use accelerated drawing in WebKit2 windows if a WebKit1 window was opened first
Modified: trunk/Source/WebKit2/NetworkProcess/NetworkLoad.cpp (198628 => 198629)
--- trunk/Source/WebKit2/NetworkProcess/NetworkLoad.cpp 2016-03-24 17:01:10 UTC (rev 198628)
+++ trunk/Source/WebKit2/NetworkProcess/NetworkLoad.cpp 2016-03-24 17:07:54 UTC (rev 198629)
@@ -364,13 +364,15 @@
return;
}
- if (auto* pendingDownload = m_task->pendingDownload())
- NetworkProcess::singleton().authenticationManager().didReceiveAuthenticationChallenge(*pendingDownload, m_challenge, completionHandler);
- else
- NetworkProcess::singleton().authenticationManager().didReceiveAuthenticationChallenge(m_parameters.webPageID, m_parameters.webFrameID, m_challenge, completionHandler);
-#else
- m_handle->continueCanAuthenticateAgainstProtectionSpace(result);
+ if (m_task) {
+ if (auto* pendingDownload = m_task->pendingDownload())
+ NetworkProcess::singleton().authenticationManager().didReceiveAuthenticationChallenge(*pendingDownload, m_challenge, completionHandler);
+ else
+ NetworkProcess::singleton().authenticationManager().didReceiveAuthenticationChallenge(m_parameters.webPageID, m_parameters.webFrameID, m_challenge, completionHandler);
+ }
#endif
+ if (m_handle)
+ m_handle->continueCanAuthenticateAgainstProtectionSpace(result);
}
#endif
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
