Title: [198637] trunk/Source/WebCore
- Revision
- 198637
- Author
- [email protected]
- Date
- 2016-03-24 11:42:04 -0700 (Thu, 24 Mar 2016)
Log Message
REGRESSION(r189129): <audio> elements do not have playback controls on iOS.
https://bugs.webkit.org/show_bug.cgi?id=155808
<rdar://problem/23822457>
Reviewed by Eric Carlson.
Audio elements should never require fullscreen for playback.
* html/MediaElementSession.cpp:
(WebCore::MediaElementSession::requiresFullscreenForVideoPlayback):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (198636 => 198637)
--- trunk/Source/WebCore/ChangeLog 2016-03-24 18:14:54 UTC (rev 198636)
+++ trunk/Source/WebCore/ChangeLog 2016-03-24 18:42:04 UTC (rev 198637)
@@ -1,3 +1,16 @@
+2016-03-24 Jer Noble <[email protected]>
+
+ REGRESSION(r189129): <audio> elements do not have playback controls on iOS.
+ https://bugs.webkit.org/show_bug.cgi?id=155808
+ <rdar://problem/23822457>
+
+ Reviewed by Eric Carlson.
+
+ Audio elements should never require fullscreen for playback.
+
+ * html/MediaElementSession.cpp:
+ (WebCore::MediaElementSession::requiresFullscreenForVideoPlayback):
+
2016-03-24 Alex Christensen <[email protected]>
Clean up cookie jar after r198195
Modified: trunk/Source/WebCore/html/MediaElementSession.cpp (198636 => 198637)
--- trunk/Source/WebCore/html/MediaElementSession.cpp 2016-03-24 18:14:54 UTC (rev 198636)
+++ trunk/Source/WebCore/html/MediaElementSession.cpp 2016-03-24 18:42:04 UTC (rev 198637)
@@ -34,6 +34,7 @@
#include "Document.h"
#include "Frame.h"
#include "FrameView.h"
+#include "HTMLAudioElement.h"
#include "HTMLMediaElement.h"
#include "HTMLMediaElementEnums.h"
#include "HTMLNames.h"
@@ -393,6 +394,9 @@
if (pageExplicitlyAllowsElementToAutoplayInline(element))
return false;
+ if (is<HTMLAudioElement>(element))
+ return false;
+
Settings* settings = element.document().settings();
if (!settings || !settings->allowsInlineMediaPlayback())
return true;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes