Title: [198785] trunk/Source/WebCore
- Revision
- 198785
- Author
- [email protected]
- Date
- 2016-03-29 11:33:35 -0700 (Tue, 29 Mar 2016)
Log Message
REGRESSION (r196813): Missing plug-in placeholder is missing
https://bugs.webkit.org/show_bug.cgi?id=155973
<rdar://problem/25068392>
Reviewed by Andy Estes.
Show unavailable plugin indicator when UnavailablePluginIndicatorState (uninitialized, hidden, visible) is not set to hidden explicitly.
It matches pre-196813 behaviour.
Unable to test.
* rendering/RenderEmbeddedObject.h:
(WebCore::RenderEmbeddedObject::showsUnavailablePluginIndicator):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (198784 => 198785)
--- trunk/Source/WebCore/ChangeLog 2016-03-29 17:16:25 UTC (rev 198784)
+++ trunk/Source/WebCore/ChangeLog 2016-03-29 18:33:35 UTC (rev 198785)
@@ -1,3 +1,19 @@
+2016-03-29 Zalan Bujtas <[email protected]>
+
+ REGRESSION (r196813): Missing plug-in placeholder is missing
+ https://bugs.webkit.org/show_bug.cgi?id=155973
+ <rdar://problem/25068392>
+
+ Reviewed by Andy Estes.
+
+ Show unavailable plugin indicator when UnavailablePluginIndicatorState (uninitialized, hidden, visible) is not set to hidden explicitly.
+ It matches pre-196813 behaviour.
+
+ Unable to test.
+
+ * rendering/RenderEmbeddedObject.h:
+ (WebCore::RenderEmbeddedObject::showsUnavailablePluginIndicator):
+
2016-03-29 Myles C. Maxfield <[email protected]>
[OS X] [RTL Scrollbars] Overlay RTL scrollbars animate in from the wrong side
Modified: trunk/Source/WebCore/rendering/RenderEmbeddedObject.h (198784 => 198785)
--- trunk/Source/WebCore/rendering/RenderEmbeddedObject.h 2016-03-29 17:16:25 UTC (rev 198784)
+++ trunk/Source/WebCore/rendering/RenderEmbeddedObject.h 2016-03-29 18:33:35 UTC (rev 198785)
@@ -50,7 +50,6 @@
WEBCORE_EXPORT void setPluginUnavailabilityReasonWithDescription(PluginUnavailabilityReason, const String& description);
bool isPluginUnavailable() const { return m_isPluginUnavailable; }
- bool showsUnavailablePluginIndicator() const { return isPluginUnavailable() && m_isUnavailablePluginIndicatorState == UnavailablePluginIndicatorState::Visible; }
WEBCORE_EXPORT void setUnavailablePluginIndicatorIsHidden(bool);
@@ -73,6 +72,7 @@
const char* renderName() const override { return "RenderEmbeddedObject"; }
bool isEmbeddedObject() const final { return true; }
+ bool showsUnavailablePluginIndicator() const { return isPluginUnavailable() && m_isUnavailablePluginIndicatorState != UnavailablePluginIndicatorState::Hidden; }
void paintSnapshotImage(PaintInfo&, const LayoutPoint&, Image&);
void paintContents(PaintInfo&, const LayoutPoint&) final;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
