Title: [198791] trunk/Source/_javascript_Core
Revision
198791
Author
[email protected]
Date
2016-03-29 13:12:18 -0700 (Tue, 29 Mar 2016)

Log Message

JSC::Debugger cleanup after recent changes
https://bugs.webkit.org/show_bug.cgi?id=155982

Patch by Joseph Pecoraro <[email protected]> on 2016-03-29
Reviewed by Mark Lam.

* debugger/Debugger.cpp:
(JSC::Debugger::Debugger):
Initialize with breakpoints disabled. Web Inspector always informs
the backend if it should enable or disable breakpoints on startup.

(JSC::Debugger::setProfilingClient):
When using the Sampling profiler we do not need to recompile.

Modified Paths

Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (198790 => 198791)


--- trunk/Source/_javascript_Core/ChangeLog	2016-03-29 20:10:20 UTC (rev 198790)
+++ trunk/Source/_javascript_Core/ChangeLog	2016-03-29 20:12:18 UTC (rev 198791)
@@ -1,3 +1,18 @@
+2016-03-29  Joseph Pecoraro  <[email protected]>
+
+        JSC::Debugger cleanup after recent changes
+        https://bugs.webkit.org/show_bug.cgi?id=155982
+
+        Reviewed by Mark Lam.
+
+        * debugger/Debugger.cpp:
+        (JSC::Debugger::Debugger):
+        Initialize with breakpoints disabled. Web Inspector always informs
+        the backend if it should enable or disable breakpoints on startup.
+
+        (JSC::Debugger::setProfilingClient):
+        When using the Sampling profiler we do not need to recompile.
+
 2016-03-29  Saam barati  <[email protected]>
 
         "Can not" => "cannot" in String.prototype error messages

Modified: trunk/Source/_javascript_Core/debugger/Debugger.cpp (198790 => 198791)


--- trunk/Source/_javascript_Core/debugger/Debugger.cpp	2016-03-29 20:10:20 UTC (rev 198790)
+++ trunk/Source/_javascript_Core/debugger/Debugger.cpp	2016-03-29 20:12:18 UTC (rev 198791)
@@ -118,7 +118,7 @@
     , m_pauseOnExceptionsState(DontPauseOnExceptions)
     , m_pauseOnNextStatement(false)
     , m_isPaused(false)
-    , m_breakpointsActivated(true)
+    , m_breakpointsActivated(false)
     , m_hasHandlerForExceptionCallback(false)
     , m_suppressAllPauses(false)
     , m_steppingMode(SteppingModeDisabled)
@@ -232,8 +232,6 @@
 {
     ASSERT(!!m_profilingClient != !!client);
     m_profilingClient = client;
-
-    recompileAllJSFunctions();
 }
 
 double Debugger::willEvaluateScript()
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to