Diff
Modified: trunk/LayoutTests/ChangeLog (198916 => 198917)
--- trunk/LayoutTests/ChangeLog 2016-03-31 21:05:39 UTC (rev 198916)
+++ trunk/LayoutTests/ChangeLog 2016-03-31 21:12:55 UTC (rev 198917)
@@ -1,3 +1,17 @@
+2016-03-31 Chris Dumez <[email protected]>
+
+ REGRESSION (r191180): Safari does not send Referer Header to iframe src in certain situations
+ https://bugs.webkit.org/show_bug.cgi?id=155754
+ <rdar://problem/25296445>
+
+ Unreviewed, roll out r191180 as it breaks sites and needs to be reworked.
+
+ * fast/preloader/frame-src-expected.txt: Removed.
+ * fast/preloader/frame-src.html: Removed.
+ * fast/preloader/resources/testFrame.html: Removed.
+ * http/tests/loading/preload-no-store-frame-src-expected: Removed.
+ * http/tests/loading/preload-no-store-frame-src.html: Removed.
+
2016-03-31 Eric Carlson <[email protected]>
Rebaseline media control tests when new media control appearances are finalized
Deleted: trunk/LayoutTests/fast/preloader/frame-src-expected.txt (198916 => 198917)
--- trunk/LayoutTests/fast/preloader/frame-src-expected.txt 2016-03-31 21:05:39 UTC (rev 198916)
+++ trunk/LayoutTests/fast/preloader/frame-src-expected.txt 2016-03-31 21:12:55 UTC (rev 198917)
@@ -1,6 +0,0 @@
-js-test-pre.js has MIME type text/_javascript_
-testFrame.html has MIME type text/html
-PASS internals.isPreloaded("resources/testFrame.html"); is true
-Tests that iframes are preloaded.
-
-
Deleted: trunk/LayoutTests/fast/preloader/frame-src.html (198916 => 198917)
--- trunk/LayoutTests/fast/preloader/frame-src.html 2016-03-31 21:05:39 UTC (rev 198916)
+++ trunk/LayoutTests/fast/preloader/frame-src.html 2016-03-31 21:12:55 UTC (rev 198917)
@@ -1,18 +0,0 @@
-<html>
-<head>
-<script>
-if (window.testRunner)
- testRunner.dumpResourceResponseMIMETypes();
-</script>
-<script src=""
-<script src=""
-<script>
- shouldBeTrue('internals.isPreloaded("resources/testFrame.html");');
-</script>
-</head>
-<body>
-<p>Tests that iframes are preloaded.</p>
-<iframe src=""
-</body>
-</html>
-
Deleted: trunk/LayoutTests/fast/preloader/resources/testFrame.html (198916 => 198917)
--- trunk/LayoutTests/fast/preloader/resources/testFrame.html 2016-03-31 21:05:39 UTC (rev 198916)
+++ trunk/LayoutTests/fast/preloader/resources/testFrame.html 2016-03-31 21:12:55 UTC (rev 198917)
@@ -1,4 +0,0 @@
-<!DOCTYPE html>
-<body>
-<p>Test frame</p>
-</body>
Deleted: trunk/LayoutTests/http/tests/loading/preload-no-store-frame-src-expected.txt (198916 => 198917)
--- trunk/LayoutTests/http/tests/loading/preload-no-store-frame-src-expected.txt 2016-03-31 21:05:39 UTC (rev 198916)
+++ trunk/LayoutTests/http/tests/loading/preload-no-store-frame-src-expected.txt 2016-03-31 21:12:55 UTC (rev 198917)
@@ -1,17 +0,0 @@
-main frame - didStartProvisionalLoadForFrame
-main frame - didCommitLoadForFrame
-js-test-pre.js has MIME type application/x-_javascript_
-slow-script.pl has MIME type application/_javascript_
-frame "<!--framePath //<!--frame0-->-->" - didStartProvisionalLoadForFrame
-main frame - didFinishDocumentLoadForFrame
-no-store-frame.php has MIME type text/html
-frame "<!--framePath //<!--frame0-->-->" - didCommitLoadForFrame
-frame "<!--framePath //<!--frame0-->-->" - didFinishDocumentLoadForFrame
-frame "<!--framePath //<!--frame0-->-->" - didHandleOnloadEventsForFrame
-main frame - didHandleOnloadEventsForFrame
-frame "<!--framePath //<!--frame0-->-->" - didFinishLoadForFrame
-main frame - didFinishLoadForFrame
-PASS internals.isPreloaded("/navigation/resources/no-store-frame.php"); is true
-Tests that 'no-store' iframes are preloaded.
-
-
Deleted: trunk/LayoutTests/http/tests/loading/preload-no-store-frame-src.html (198916 => 198917)
--- trunk/LayoutTests/http/tests/loading/preload-no-store-frame-src.html 2016-03-31 21:05:39 UTC (rev 198916)
+++ trunk/LayoutTests/http/tests/loading/preload-no-store-frame-src.html 2016-03-31 21:12:55 UTC (rev 198917)
@@ -1,18 +0,0 @@
-<html>
-<head>
-<script>
-if (window.testRunner)
- testRunner.dumpResourceResponseMIMETypes();
-</script>
-<script src=""
-<script src=""
-<script>
- shouldBeTrue('internals.isPreloaded("/navigation/resources/no-store-frame.php");');
-</script>
-</head>
-<body>
-<p>Tests that 'no-store' iframes are preloaded.</p>
-<iframe src=""
-</body>
-</html>
-
Modified: trunk/Source/WebCore/ChangeLog (198916 => 198917)
--- trunk/Source/WebCore/ChangeLog 2016-03-31 21:05:39 UTC (rev 198916)
+++ trunk/Source/WebCore/ChangeLog 2016-03-31 21:12:55 UTC (rev 198917)
@@ -1,3 +1,18 @@
+2016-03-31 Chris Dumez <[email protected]>
+
+ REGRESSION (r191180): Safari does not send Referer Header to iframe src in certain situations
+ https://bugs.webkit.org/show_bug.cgi?id=155754
+ <rdar://problem/25296445>
+
+ Unreviewed, roll out r191180 as it breaks sites and needs to be reworked.
+
+ * html/parser/HTMLPreloadScanner.cpp:
+ (WebCore::TokenPreloadScanner::tagIdFor): Deleted.
+ (WebCore::TokenPreloadScanner::initiatorFor): Deleted.
+ (WebCore::TokenPreloadScanner::StartTagScanner::processAttribute): Deleted.
+ (WebCore::TokenPreloadScanner::StartTagScanner::resourceType): Deleted.
+ * html/parser/HTMLPreloadScanner.h:
+
2016-03-31 Jiewen Tan <[email protected]>
WebKit should set Original URL of a download request correctly
Modified: trunk/Source/WebCore/html/parser/HTMLPreloadScanner.cpp (198916 => 198917)
--- trunk/Source/WebCore/html/parser/HTMLPreloadScanner.cpp 2016-03-31 21:05:39 UTC (rev 198916)
+++ trunk/Source/WebCore/html/parser/HTMLPreloadScanner.cpp 2016-03-31 21:12:55 UTC (rev 198917)
@@ -46,8 +46,6 @@
TokenPreloadScanner::TagId TokenPreloadScanner::tagIdFor(const HTMLToken::DataVector& data)
{
AtomicString tagName(data);
- if (tagName == iframeTag)
- return TagId::Iframe;
if (tagName == imgTag)
return TagId::Img;
if (tagName == inputTag)
@@ -74,8 +72,6 @@
String TokenPreloadScanner::initiatorFor(TagId tagId)
{
switch (tagId) {
- case TagId::Iframe:
- return "iframe";
case TagId::Source:
case TagId::Img:
return "img";
@@ -176,10 +172,6 @@
bool alreadyMatchedSource = inPicture && pictureState.last();
switch (m_tagId) {
- case TagId::Iframe:
- if (match(attributeName, srcAttr))
- setUrlToLoad(attributeValue);
- break;
case TagId::Img:
if (inPicture && alreadyMatchedSource)
break;
@@ -272,8 +264,6 @@
CachedResource::Type resourceType() const
{
switch (m_tagId) {
- case TagId::Iframe:
- return CachedResource::MainResource;
case TagId::Script:
return CachedResource::Script;
case TagId::Img:
Modified: trunk/Source/WebCore/html/parser/HTMLPreloadScanner.h (198916 => 198917)
--- trunk/Source/WebCore/html/parser/HTMLPreloadScanner.h 2016-03-31 21:05:39 UTC (rev 198916)
+++ trunk/Source/WebCore/html/parser/HTMLPreloadScanner.h 2016-03-31 21:12:55 UTC (rev 198917)
@@ -47,7 +47,6 @@
private:
enum class TagId {
// These tags are scanned by the StartTagScanner.
- Iframe,
Img,
Input,
Link,
