Title: [199016] trunk/Source/_javascript_Core
- Revision
- 199016
- Author
- [email protected]
- Date
- 2016-04-04 12:41:34 -0700 (Mon, 04 Apr 2016)
Log Message
CopiedBlock should be 16kB
https://bugs.webkit.org/show_bug.cgi?id=156168
Reviewed by Mark Lam.
MarkedBlock is 16kB, and bmalloc's largest fast-path allocation is 16kB,
and the largest page size on Apple devices is 16kB -- so this change
should improve sharing and recycling and keep us on the fast path more.
32kB is also super aggro. At 16kB, we support allocations up to 8kB,
which covers 99.3% of allocations on facebook.com. The 32kB block size
only covered an additional 0.2% of allocations.
* heap/CopiedBlock.h:
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (199015 => 199016)
--- trunk/Source/_javascript_Core/ChangeLog 2016-04-04 19:41:29 UTC (rev 199015)
+++ trunk/Source/_javascript_Core/ChangeLog 2016-04-04 19:41:34 UTC (rev 199016)
@@ -1,3 +1,20 @@
+2016-04-04 Geoffrey Garen <[email protected]>
+
+ CopiedBlock should be 16kB
+ https://bugs.webkit.org/show_bug.cgi?id=156168
+
+ Reviewed by Mark Lam.
+
+ MarkedBlock is 16kB, and bmalloc's largest fast-path allocation is 16kB,
+ and the largest page size on Apple devices is 16kB -- so this change
+ should improve sharing and recycling and keep us on the fast path more.
+
+ 32kB is also super aggro. At 16kB, we support allocations up to 8kB,
+ which covers 99.3% of allocations on facebook.com. The 32kB block size
+ only covered an additional 0.2% of allocations.
+
+ * heap/CopiedBlock.h:
+
2016-04-04 Carlos Garcia Campos <[email protected]>
REGRESSION(r198792): [GTK] Inspector crashes in Inspector::Protocol::getEnumConstantValue since r198792
Modified: trunk/Source/_javascript_Core/heap/CopiedBlock.h (199015 => 199016)
--- trunk/Source/_javascript_Core/heap/CopiedBlock.h 2016-04-04 19:41:29 UTC (rev 199015)
+++ trunk/Source/_javascript_Core/heap/CopiedBlock.h 2016-04-04 19:41:34 UTC (rev 199016)
@@ -79,7 +79,7 @@
size_t size();
size_t capacity();
- static const size_t blockSize = 32 * KB;
+ static const size_t blockSize = 16 * KB;
bool hasWorkList();
CopyWorkList& workList();
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
