Title: [199021] trunk/Source/WebKit2
- Revision
- 199021
- Author
- [email protected]
- Date
- 2016-04-04 14:09:35 -0700 (Mon, 04 Apr 2016)
Log Message
REGRESSION(r198955): com.apple.WebKit.Networking.Development crashed in WebKit::NetworkLoad::setPendingDownloadID + 11
https://bugs.webkit.org/show_bug.cgi?id=156177
<rdar://problem/25508037>
Reviewed by Alex Christensen.
We do not currently create a NetworkDataTask when we encounter a BLOB URL when building with
NETWORK_SESSION enabled. This causes us to crash when the download system attempts to work
with a BLOB URL.
* NetworkProcess/NetworkLoad.cpp:
(WebKit::NetworkLoad::setPendingDownloadID): Add null check for m_task.
(WebKit::NetworkLoad::setPendingDownload): Ditto.
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (199020 => 199021)
--- trunk/Source/WebKit2/ChangeLog 2016-04-04 21:03:28 UTC (rev 199020)
+++ trunk/Source/WebKit2/ChangeLog 2016-04-04 21:09:35 UTC (rev 199021)
@@ -1,3 +1,19 @@
+2016-04-04 Brent Fulgham <[email protected]>
+
+ REGRESSION(r198955): com.apple.WebKit.Networking.Development crashed in WebKit::NetworkLoad::setPendingDownloadID + 11
+ https://bugs.webkit.org/show_bug.cgi?id=156177
+ <rdar://problem/25508037>
+
+ Reviewed by Alex Christensen.
+
+ We do not currently create a NetworkDataTask when we encounter a BLOB URL when building with
+ NETWORK_SESSION enabled. This causes us to crash when the download system attempts to work
+ with a BLOB URL.
+
+ * NetworkProcess/NetworkLoad.cpp:
+ (WebKit::NetworkLoad::setPendingDownloadID): Add null check for m_task.
+ (WebKit::NetworkLoad::setPendingDownload): Ditto.
+
2016-04-03 Sam Weinig <[email protected]>
Add SPI to allow install script message handlers in isolated worlds
Modified: trunk/Source/WebKit2/NetworkProcess/NetworkLoad.cpp (199020 => 199021)
--- trunk/Source/WebKit2/NetworkProcess/NetworkLoad.cpp 2016-04-04 21:03:28 UTC (rev 199020)
+++ trunk/Source/WebKit2/NetworkProcess/NetworkLoad.cpp 2016-04-04 21:09:35 UTC (rev 199021)
@@ -183,11 +183,17 @@
void NetworkLoad::setPendingDownloadID(DownloadID downloadID)
{
+ if (!m_task)
+ return;
+
m_task->setPendingDownloadID(downloadID);
}
void NetworkLoad::setPendingDownload(PendingDownload& pendingDownload)
{
+ if (!m_task)
+ return;
+
m_task->setPendingDownload(pendingDownload);
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
