Title: [199041] trunk/Source/WebInspectorUI
- Revision
- 199041
- Author
- [email protected]
- Date
- 2016-04-04 22:20:33 -0700 (Mon, 04 Apr 2016)
Log Message
Uncaught Exception: Error: Can't make a ContentView for an unknown representedObject (ApplicationCacheManifest)
https://bugs.webkit.org/show_bug.cgi?id=156139
<rdar://problem/25511926>
Patch by Joseph Pecoraro <[email protected]> on 2016-04-04
Reviewed by Timothy Hatcher.
* UserInterface/Views/ContentView.js:
(WebInspector.ContentView.createFromRepresentedObject):
Improve the error message to get the name of the represented object.
* UserInterface/Views/NavigationSidebarPanel.js:
(WebInspector.NavigationSidebarPanel.prototype._isTreeElementWithoutRepresentedObject):
Treat ApplicationCacheManifestTreeElement like other Host elements. Nothing to save/show.
* UserInterface/Views/ApplicationCacheManifestTreeElement.js:
(WebInspector.ApplicationCacheManifestTreeElement):
* UserInterface/Views/DatabaseHostTreeElement.js:
(WebInspector.DatabaseHostTreeElement):
* UserInterface/Views/IndexedDatabaseHostTreeElement.js:
(WebInspector.IndexedDatabaseHostTreeElement):
Auto-expand these folders, as they are not useful when collapsed.
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (199040 => 199041)
--- trunk/Source/WebInspectorUI/ChangeLog 2016-04-05 04:22:54 UTC (rev 199040)
+++ trunk/Source/WebInspectorUI/ChangeLog 2016-04-05 05:20:33 UTC (rev 199041)
@@ -1,5 +1,29 @@
2016-04-04 Joseph Pecoraro <[email protected]>
+ Uncaught Exception: Error: Can't make a ContentView for an unknown representedObject (ApplicationCacheManifest)
+ https://bugs.webkit.org/show_bug.cgi?id=156139
+ <rdar://problem/25511926>
+
+ Reviewed by Timothy Hatcher.
+
+ * UserInterface/Views/ContentView.js:
+ (WebInspector.ContentView.createFromRepresentedObject):
+ Improve the error message to get the name of the represented object.
+
+ * UserInterface/Views/NavigationSidebarPanel.js:
+ (WebInspector.NavigationSidebarPanel.prototype._isTreeElementWithoutRepresentedObject):
+ Treat ApplicationCacheManifestTreeElement like other Host elements. Nothing to save/show.
+
+ * UserInterface/Views/ApplicationCacheManifestTreeElement.js:
+ (WebInspector.ApplicationCacheManifestTreeElement):
+ * UserInterface/Views/DatabaseHostTreeElement.js:
+ (WebInspector.DatabaseHostTreeElement):
+ * UserInterface/Views/IndexedDatabaseHostTreeElement.js:
+ (WebInspector.IndexedDatabaseHostTreeElement):
+ Auto-expand these folders, as they are not useful when collapsed.
+
+2016-04-04 Joseph Pecoraro <[email protected]>
+
Web Inspector: Uncaught exception in CSS with string "constructor" (WebInspector.Color.fromString())
https://bugs.webkit.org/show_bug.cgi?id=156183
<rdar://problem/25539279>
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ApplicationCacheManifestTreeElement.js (199040 => 199041)
--- trunk/Source/WebInspectorUI/UserInterface/Views/ApplicationCacheManifestTreeElement.js 2016-04-05 04:22:54 UTC (rev 199040)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ApplicationCacheManifestTreeElement.js 2016-04-05 05:20:33 UTC (rev 199041)
@@ -30,6 +30,9 @@
console.assert(representedObject instanceof WebInspector.ApplicationCacheManifest);
super("application-cache-manifest", "", representedObject);
+
+ this.hasChildren = true;
+ this.expanded = true;
}
// Public
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ContentView.js (199040 => 199041)
--- trunk/Source/WebInspectorUI/UserInterface/Views/ContentView.js 2016-04-05 04:22:54 UTC (rev 199040)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ContentView.js 2016-04-05 05:20:33 UTC (rev 199041)
@@ -146,7 +146,7 @@
console.assert(!WebInspector.ContentView.isViewable(representedObject));
- throw new Error("Can't make a ContentView for an unknown representedObject.");
+ throw new Error("Can't make a ContentView for an unknown representedObject of type: " + representedObject.constructor.name);
}
static contentViewForRepresentedObject(representedObject, onlyExisting, extraArguments)
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/DatabaseHostTreeElement.js (199040 => 199041)
--- trunk/Source/WebInspectorUI/UserInterface/Views/DatabaseHostTreeElement.js 2016-04-05 04:22:54 UTC (rev 199040)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/DatabaseHostTreeElement.js 2016-04-05 05:20:33 UTC (rev 199041)
@@ -32,6 +32,7 @@
this._host = host;
this.hasChildren = true;
+ this.expanded = true;
}
// Public
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/IndexedDatabaseHostTreeElement.js (199040 => 199041)
--- trunk/Source/WebInspectorUI/UserInterface/Views/IndexedDatabaseHostTreeElement.js 2016-04-05 04:22:54 UTC (rev 199040)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/IndexedDatabaseHostTreeElement.js 2016-04-05 05:20:33 UTC (rev 199041)
@@ -32,6 +32,7 @@
this._host = host;
this.hasChildren = true;
+ this.expanded = true;
}
// Public
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/NavigationSidebarPanel.js (199040 => 199041)
--- trunk/Source/WebInspectorUI/UserInterface/Views/NavigationSidebarPanel.js 2016-04-05 04:22:54 UTC (rev 199040)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/NavigationSidebarPanel.js 2016-04-05 05:20:33 UTC (rev 199041)
@@ -674,6 +674,7 @@
return treeElement instanceof WebInspector.FolderTreeElement
|| treeElement instanceof WebInspector.DatabaseHostTreeElement
|| treeElement instanceof WebInspector.IndexedDatabaseHostTreeElement
+ || treeElement instanceof WebInspector.ApplicationCacheManifestTreeElement
|| typeof treeElement.representedObject === "string"
|| treeElement.representedObject instanceof String;
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
