Title: [199119] trunk/Source/WebCore
Revision
199119
Author
[email protected]
Date
2016-04-06 15:22:02 -0700 (Wed, 06 Apr 2016)

Log Message

Avoid using an unengaged Optional<FloatRect> when positioning the tiled scrolling indicator
https://bugs.webkit.org/show_bug.cgi?id=156313

Reviewed by Tim Horton.

Fixes an assertion seen when running the WebKit2.AutoLayoutIntegration API test.

* page/FrameView.cpp:
(WebCore::FrameView::setViewExposedRect):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (199118 => 199119)


--- trunk/Source/WebCore/ChangeLog	2016-04-06 21:51:56 UTC (rev 199118)
+++ trunk/Source/WebCore/ChangeLog	2016-04-06 22:22:02 UTC (rev 199119)
@@ -1,3 +1,15 @@
+2016-04-06  Simon Fraser  <[email protected]>
+
+        Avoid using an unengaged Optional<FloatRect> when positioning the tiled scrolling indicator
+        https://bugs.webkit.org/show_bug.cgi?id=156313
+
+        Reviewed by Tim Horton.
+
+        Fixes an assertion seen when running the WebKit2.AutoLayoutIntegration API test.
+
+        * page/FrameView.cpp:
+        (WebCore::FrameView::setViewExposedRect):
+
 2016-04-06  Sam Weinig  <[email protected]>
 
         Fix windows build.

Modified: trunk/Source/WebCore/page/FrameView.cpp (199118 => 199119)


--- trunk/Source/WebCore/page/FrameView.cpp	2016-04-06 21:51:56 UTC (rev 199118)
+++ trunk/Source/WebCore/page/FrameView.cpp	2016-04-06 22:22:02 UTC (rev 199119)
@@ -4917,9 +4917,10 @@
     // FIXME: We should support clipping to the exposed rect for subframes as well.
     if (!frame().isMainFrame())
         return;
+
     if (TiledBacking* tiledBacking = this->tiledBacking()) {
         adjustTiledBackingCoverage();
-        tiledBacking->setTiledScrollingIndicatorPosition(m_viewExposedRect.value().location());
+        tiledBacking->setTiledScrollingIndicatorPosition(m_viewExposedRect ? m_viewExposedRect.value().location() : FloatPoint());
     }
 
     if (auto* view = renderView())
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to