Title: [199129] trunk/Source/_javascript_Core
- Revision
- 199129
- Author
- [email protected]
- Date
- 2016-04-06 18:11:47 -0700 (Wed, 06 Apr 2016)
Log Message
JSC test stress/arrowfunction-lexical-bind-superproperty.js failing
https://bugs.webkit.org/show_bug.cgi?id=156309
Reviewed by Saam Barati.
Just be honest about the fact that the ArgumentCount and Callee parts of inline callframe runtime
meta-data can be read at any time.
We only have to say this for the inline callframe forms of ArgumentCount and Callee because we don't
sink any part of the machine prologue. This change just prevents us from sinking the pseudoprologue
of inlined varargs or closure calls.
Shockingly, this is not a regression on anything.
* dfg/DFGClobberize.h:
(JSC::DFG::clobberize):
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (199128 => 199129)
--- trunk/Source/_javascript_Core/ChangeLog 2016-04-07 00:50:44 UTC (rev 199128)
+++ trunk/Source/_javascript_Core/ChangeLog 2016-04-07 01:11:47 UTC (rev 199129)
@@ -1,3 +1,22 @@
+2016-04-06 Filip Pizlo <[email protected]>
+
+ JSC test stress/arrowfunction-lexical-bind-superproperty.js failing
+ https://bugs.webkit.org/show_bug.cgi?id=156309
+
+ Reviewed by Saam Barati.
+
+ Just be honest about the fact that the ArgumentCount and Callee parts of inline callframe runtime
+ meta-data can be read at any time.
+
+ We only have to say this for the inline callframe forms of ArgumentCount and Callee because we don't
+ sink any part of the machine prologue. This change just prevents us from sinking the pseudoprologue
+ of inlined varargs or closure calls.
+
+ Shockingly, this is not a regression on anything.
+
+ * dfg/DFGClobberize.h:
+ (JSC::DFG::clobberize):
+
2016-03-29 Keith Miller <[email protected]>
[ES6] Add support for Symbol.isConcatSpreadable.
Modified: trunk/Source/_javascript_Core/dfg/DFGClobberize.h (199128 => 199129)
--- trunk/Source/_javascript_Core/dfg/DFGClobberize.h 2016-04-07 00:50:44 UTC (rev 199128)
+++ trunk/Source/_javascript_Core/dfg/DFGClobberize.h 2016-04-07 01:11:47 UTC (rev 199129)
@@ -107,6 +107,17 @@
if (edgesUseStructure(graph, node))
read(JSCell_structureID);
+ // We allow the runtime to perform a stack scan at any time. We don't model which nodes get implemented
+ // by calls into the runtime. For debugging we might replace the implementation of any node with a call
+ // to the runtime, and that call may walk stack. Therefore, each node must read() anything that a stack
+ // scan would read. That's what this does.
+ for (InlineCallFrame* inlineCallFrame = node->origin.semantic.inlineCallFrame; inlineCallFrame; inlineCallFrame = inlineCallFrame->directCaller.inlineCallFrame) {
+ if (inlineCallFrame->isClosureCall)
+ read(AbstractHeap(Stack, inlineCallFrame->stackOffset + JSStack::Callee));
+ if (inlineCallFrame->isVarargs())
+ read(AbstractHeap(Stack, inlineCallFrame->stackOffset + JSStack::ArgumentCount));
+ }
+
switch (node->op()) {
case JSConstant:
case DoubleConstant:
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
