Title: [199148] trunk/Source/_javascript_Core
- Revision
- 199148
- Author
- [email protected]
- Date
- 2016-04-06 21:33:32 -0700 (Wed, 06 Apr 2016)
Log Message
[JSC] UInt32ToNumber should be NodeMustGenerate
https://bugs.webkit.org/show_bug.cgi?id=156329
Patch by Benjamin Poulain <[email protected]> on 2016-04-06
Reviewed by Filip Pizlo.
It exits on negative numbers on the integer path.
* dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
* dfg/DFGNodeType.h:
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (199147 => 199148)
--- trunk/Source/_javascript_Core/ChangeLog 2016-04-07 04:11:55 UTC (rev 199147)
+++ trunk/Source/_javascript_Core/ChangeLog 2016-04-07 04:33:32 UTC (rev 199148)
@@ -1,3 +1,16 @@
+2016-04-06 Benjamin Poulain <[email protected]>
+
+ [JSC] UInt32ToNumber should be NodeMustGenerate
+ https://bugs.webkit.org/show_bug.cgi?id=156329
+
+ Reviewed by Filip Pizlo.
+
+ It exits on negative numbers on the integer path.
+
+ * dfg/DFGFixupPhase.cpp:
+ (JSC::DFG::FixupPhase::fixupNode):
+ * dfg/DFGNodeType.h:
+
2016-04-04 Geoffrey Garen <[email protected]>
Unreviewed, rolling out r199016.
Modified: trunk/Source/_javascript_Core/dfg/DFGFixupPhase.cpp (199147 => 199148)
--- trunk/Source/_javascript_Core/dfg/DFGFixupPhase.cpp 2016-04-07 04:11:55 UTC (rev 199147)
+++ trunk/Source/_javascript_Core/dfg/DFGFixupPhase.cpp 2016-04-07 04:33:32 UTC (rev 199148)
@@ -141,6 +141,7 @@
else {
node->setArithMode(Arith::DoOverflow);
node->setResult(NodeResultDouble);
+ node->clearFlags(NodeMustGenerate);
}
break;
}
Modified: trunk/Source/_javascript_Core/dfg/DFGNodeType.h (199147 => 199148)
--- trunk/Source/_javascript_Core/dfg/DFGNodeType.h 2016-04-07 04:11:55 UTC (rev 199147)
+++ trunk/Source/_javascript_Core/dfg/DFGNodeType.h 2016-04-07 04:33:32 UTC (rev 199148)
@@ -119,7 +119,7 @@
/* Bitwise operators call ToInt32 on their operands. */\
macro(ValueToInt32, NodeResultInt32) \
/* Used to box the result of URShift nodes (result has range 0..2^32-1). */\
- macro(UInt32ToNumber, NodeResultNumber) \
+ macro(UInt32ToNumber, NodeResultNumber | NodeMustGenerate) \
/* Converts booleans to numbers but passes everything else through. */\
macro(BooleanToNumber, NodeResultJS) \
\
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes