Title: [199155] trunk/Source/WebCore
- Revision
- 199155
- Author
- [email protected]
- Date
- 2016-04-07 07:22:11 -0700 (Thu, 07 Apr 2016)
Log Message
FrameView::qualifiesAsVisuallyNonEmpty() returns false when loading a Google search results page before search results are loaded, even though the header is visible
https://bugs.webkit.org/show_bug.cgi?id=156339
<rdar://problem/24491381>
Reviewed by Andreas Kling.
Jeff's testing indicates lowering the document height threshold improves things visually during page loading.
* page/FrameView.cpp:
(WebCore::FrameView::qualifiesAsVisuallyNonEmpty):
Lower document height threshold to from 200 to 48 pixels.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (199154 => 199155)
--- trunk/Source/WebCore/ChangeLog 2016-04-07 10:29:15 UTC (rev 199154)
+++ trunk/Source/WebCore/ChangeLog 2016-04-07 14:22:11 UTC (rev 199155)
@@ -1,5 +1,22 @@
2016-04-07 Antti Koivisto <[email protected]>
+ FrameView::qualifiesAsVisuallyNonEmpty() returns false when loading a Google search results page before search results are loaded, even though the header is visible
+ https://bugs.webkit.org/show_bug.cgi?id=156339
+ <rdar://problem/24491381>
+
+ Reviewed by Andreas Kling.
+
+ Patch by Jeff Miller.
+
+ Jeff's testing indicates lowering the document height threshold improves things visually during page loading.
+
+ * page/FrameView.cpp:
+ (WebCore::FrameView::qualifiesAsVisuallyNonEmpty):
+
+ Lower document height threshold to from 200 to 48 pixels.
+
+2016-04-07 Antti Koivisto <[email protected]>
+
Shadow DOM: Implement display: contents for slots
https://bugs.webkit.org/show_bug.cgi?id=149439
<rdar://problem/22731922>
Modified: trunk/Source/WebCore/page/FrameView.cpp (199154 => 199155)
--- trunk/Source/WebCore/page/FrameView.cpp 2016-04-07 10:29:15 UTC (rev 199154)
+++ trunk/Source/WebCore/page/FrameView.cpp 2016-04-07 14:22:11 UTC (rev 199155)
@@ -4257,7 +4257,8 @@
return true;
// Require the document to grow a bit.
- static const int documentHeightThreshold = 200;
+ // Using a value of 48 allows the header on Google's search page to render immediately before search results populate later.
+ static const int documentHeightThreshold = 48;
LayoutRect overflowRect = documentElement->renderBox()->layoutOverflowRect();
if (snappedIntRect(overflowRect).height() < documentHeightThreshold)
return false;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
