Title: [199178] trunk/Source/WebInspectorUI
- Revision
- 199178
- Author
- [email protected]
- Date
- 2016-04-07 14:00:40 -0700 (Thu, 07 Apr 2016)
Log Message
Web Inspector: Uncaught Exception: No resource with given URL found
https://bugs.webkit.org/show_bug.cgi?id=156259
<rdar://problem/25564749>
Patch by Joseph Pecoraro <[email protected]> on 2016-04-07
Reviewed by Timothy Hatcher.
* UserInterface/Views/SourceCodeTextEditor.js:
(WebInspector.SourceCodeTextEditor):
SourceCode.prototype.requestContent will reject if it cannot load
content for the given resource. In that case, we already have an
earlier catch handler that displays an error message in the
ContentView, so we shouldn't show an Uncaught Exception page.
Really, we should not reject the original promise here, and
instead resolve it with an object describing the error, but
short term we should remove the uncaught exception handler for
this case.
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (199177 => 199178)
--- trunk/Source/WebInspectorUI/ChangeLog 2016-04-07 20:59:27 UTC (rev 199177)
+++ trunk/Source/WebInspectorUI/ChangeLog 2016-04-07 21:00:40 UTC (rev 199178)
@@ -1,5 +1,24 @@
2016-04-07 Joseph Pecoraro <[email protected]>
+ Web Inspector: Uncaught Exception: No resource with given URL found
+ https://bugs.webkit.org/show_bug.cgi?id=156259
+ <rdar://problem/25564749>
+
+ Reviewed by Timothy Hatcher.
+
+ * UserInterface/Views/SourceCodeTextEditor.js:
+ (WebInspector.SourceCodeTextEditor):
+ SourceCode.prototype.requestContent will reject if it cannot load
+ content for the given resource. In that case, we already have an
+ earlier catch handler that displays an error message in the
+ ContentView, so we shouldn't show an Uncaught Exception page.
+ Really, we should not reject the original promise here, and
+ instead resolve it with an object describing the error, but
+ short term we should remove the uncaught exception handler for
+ this case.
+
+2016-04-07 Joseph Pecoraro <[email protected]>
+
Web Inspector: Take snapshot navigation button should match navigation button styles
https://bugs.webkit.org/show_bug.cgi?id=156355
<rdar://problem/25325172>
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/SourceCodeTextEditor.js (199177 => 199178)
--- trunk/Source/WebInspectorUI/UserInterface/Views/SourceCodeTextEditor.js 2016-04-07 20:59:27 UTC (rev 199177)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/SourceCodeTextEditor.js 2016-04-07 21:00:40 UTC (rev 199178)
@@ -80,7 +80,7 @@
else
this._sourceCode.addEventListener(WebInspector.SourceCode.Event.SourceMapAdded, this._sourceCodeSourceMapAdded, this);
- sourceCode.requestContent().then(this._contentAvailable.bind(this)).catch(handlePromiseException);
+ sourceCode.requestContent().then(this._contentAvailable.bind(this));
// FIXME: Cmd+L shortcut doesn't actually work.
new WebInspector.KeyboardShortcut(WebInspector.KeyboardShortcut.Modifier.Command, "L", this.showGoToLineDialog.bind(this), this.element);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
