Title: [199203] trunk/Source/_javascript_Core
- Revision
- 199203
- Author
- [email protected]
- Date
- 2016-04-07 17:10:20 -0700 (Thu, 07 Apr 2016)
Log Message
Rename ArrayMode::supportsLength to supportsSelfLength
https://bugs.webkit.org/show_bug.cgi?id=156374
Reviewed by Filip Pizlo.
The name supportsLength is confusing because TypedArray have a
length function however it is on the prototype and not on the
instance. supportsSelfLength makes more sense since we use the
function during fixup to tell if we can intrinsic the length
property lookup on self accesses.
* dfg/DFGArrayMode.h:
(JSC::DFG::ArrayMode::supportsSelfLength):
(JSC::DFG::ArrayMode::supportsLength): Deleted.
* dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::attemptToMakeGetArrayLength):
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (199202 => 199203)
--- trunk/Source/_javascript_Core/ChangeLog 2016-04-07 23:38:32 UTC (rev 199202)
+++ trunk/Source/_javascript_Core/ChangeLog 2016-04-08 00:10:20 UTC (rev 199203)
@@ -1,3 +1,22 @@
+2016-04-07 Keith Miller <[email protected]>
+
+ Rename ArrayMode::supportsLength to supportsSelfLength
+ https://bugs.webkit.org/show_bug.cgi?id=156374
+
+ Reviewed by Filip Pizlo.
+
+ The name supportsLength is confusing because TypedArray have a
+ length function however it is on the prototype and not on the
+ instance. supportsSelfLength makes more sense since we use the
+ function during fixup to tell if we can intrinsic the length
+ property lookup on self accesses.
+
+ * dfg/DFGArrayMode.h:
+ (JSC::DFG::ArrayMode::supportsSelfLength):
+ (JSC::DFG::ArrayMode::supportsLength): Deleted.
+ * dfg/DFGFixupPhase.cpp:
+ (JSC::DFG::FixupPhase::attemptToMakeGetArrayLength):
+
2016-04-07 Joseph Pecoraro <[email protected]>
Web Inspector: ProfileView source links are off by 1 line, worse in pretty printed code
Modified: trunk/Source/_javascript_Core/dfg/DFGArrayMode.h (199202 => 199203)
--- trunk/Source/_javascript_Core/dfg/DFGArrayMode.h 2016-04-07 23:38:32 UTC (rev 199202)
+++ trunk/Source/_javascript_Core/dfg/DFGArrayMode.h 2016-04-08 00:10:20 UTC (rev 199203)
@@ -349,7 +349,7 @@
}
}
- bool supportsLength() const
+ bool supportsSelfLength() const
{
switch (type()) {
case Array::SelectUsingPredictions:
Modified: trunk/Source/_javascript_Core/dfg/DFGFixupPhase.cpp (199202 => 199203)
--- trunk/Source/_javascript_Core/dfg/DFGFixupPhase.cpp 2016-04-07 23:38:32 UTC (rev 199202)
+++ trunk/Source/_javascript_Core/dfg/DFGFixupPhase.cpp 2016-04-08 00:10:20 UTC (rev 199203)
@@ -2214,7 +2214,7 @@
attemptToForceStringArrayModeByToStringConversion<StringOrStringObjectUse>(arrayMode, node);
}
- if (!arrayMode.supportsLength())
+ if (!arrayMode.supportsSelfLength())
return false;
convertToGetArrayLength(node, arrayMode);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
