[webkit-changes] [199237] trunk/Source/WebCore

[commit-queue]

Title: [199237] trunk/Source/WebCore

Revision

199237

Author

commit-qu...@webkit.org

Date

2016-04-08 11:28:27 -0700 (Fri, 08 Apr 2016)

Log Message

Touching any IDL files rebuilds all bindings in CMake Ninja build
https://bugs.webkit.org/show_bug.cgi?id=156400

Patch by Fujii Hironori <hironori.fu...@jp.sony.com> on 2016-04-08
Reviewed by Brent Fulgham.

* bindings/scripts/preprocess-idls.pl:
(GenerateConstructorAttribute):
WriteFileIfChanged does not work due to flaky results of 'keys'.
Sort results of 'keys'.

Modified Paths

• trunk/Source/WebCore/ChangeLog
• trunk/Source/WebCore/bindings/scripts/preprocess-idls.pl

Diff

Modified: trunk/Source/WebCore/ChangeLog (199236 => 199237)

--- trunk/Source/WebCore/ChangeLog	2016-04-08 18:18:19 UTC (rev 199236)
+++ trunk/Source/WebCore/ChangeLog	2016-04-08 18:28:27 UTC (rev 199237)
@@ -1,3 +1,15 @@
+2016-04-08  Fujii Hironori  <hironori.fu...@jp.sony.com>
+
+        Touching any IDL files rebuilds all bindings in CMake Ninja build
+        https://bugs.webkit.org/show_bug.cgi?id=156400
+
+        Reviewed by Brent Fulgham.
+
+        * bindings/scripts/preprocess-idls.pl:
+        (GenerateConstructorAttribute):
+        WriteFileIfChanged does not work due to flaky results of 'keys'.
+        Sort results of 'keys'.
+
 2016-04-07  Simon Fraser  <simon.fra...@apple.com>
 
         [iOS WK2] Stop using exposedContentRect for history scroll state restoration

Modified: trunk/Source/WebCore/bindings/scripts/preprocess-idls.pl (199236 => 199237)

--- trunk/Source/WebCore/bindings/scripts/preprocess-idls.pl	2016-04-08 18:18:19 UTC (rev 199236)
+++ trunk/Source/WebCore/bindings/scripts/preprocess-idls.pl	2016-04-08 18:28:27 UTC (rev 199237)
@@ -77,7 +77,7 @@
 my %idlFileHash = map { $_, 1 } @idlFiles;
 
 # Populate $idlFileToInterfaceName and $interfaceNameToIdlFile.
-foreach my $idlFile (keys %idlFileHash) {
+foreach my $idlFile (sort keys %idlFileHash) {
     my $fullPath = Cwd::realpath($idlFile);
     my $interfaceName = fileparse(basename($idlFile), ".idl");
     $idlFileToInterfaceName{$fullPath} = $interfaceName;
@@ -131,7 +131,7 @@
 GeneratePartialInterface("DedicatedWorkerGlobalScope", $dedicatedWorkerGlobalScopeConstructorsCode, $dedicatedWorkerGlobalScopeConstructorsFile);
 
 # Resolves partial interfaces and implements dependencies.
-foreach my $idlFile (keys %supplementalDependencies) {
+foreach my $idlFile (sort keys %supplementalDependencies) {
     my $baseFiles = $supplementalDependencies{$idlFile};
     foreach my $baseFile (@{$baseFiles}) {
         my $targetIdlFile = $interfaceNameToIdlFile{$baseFile};
@@ -227,7 +227,7 @@
 
     my $code = "    ";
     my @extendedAttributesList;
-    foreach my $attributeName (keys %{$extendedAttributes}) {
+    foreach my $attributeName (sort keys %{$extendedAttributes}) {
       next unless ($attributeName eq "Conditional" || $attributeName eq "EnabledAtRuntime" || $attributeName eq "EnabledBySetting");
       my $extendedAttribute = $attributeName;
       $extendedAttribute .= "=" . $extendedAttributes->{$attributeName} unless $extendedAttributes->{$attributeName} eq "VALUE_IS_MISSING";

_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes