Title: [199301] trunk/Source/WebKit2
- Revision
- 199301
- Author
- [email protected]
- Date
- 2016-04-11 12:06:20 -0700 (Mon, 11 Apr 2016)
Log Message
REGRESSION (r198933): Unable to login to Google account from Internet Accounts preference pane
https://bugs.webkit.org/show_bug.cgi?id=156447
<rdar://problem/25628133>
Reviewed by Anders Carlsson.
Temporarily perform code signing verification only for Mac App Store- and Apple Developer- signed apps.
* Shared/mac/ChildProcessMac.mm:
(WebKit::codeSigningIdentifierForProcess):
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (199300 => 199301)
--- trunk/Source/WebKit2/ChangeLog 2016-04-11 19:04:33 UTC (rev 199300)
+++ trunk/Source/WebKit2/ChangeLog 2016-04-11 19:06:20 UTC (rev 199301)
@@ -1,3 +1,16 @@
+2016-04-11 Daniel Bates <[email protected]>
+
+ REGRESSION (r198933): Unable to login to Google account from Internet Accounts preference pane
+ https://bugs.webkit.org/show_bug.cgi?id=156447
+ <rdar://problem/25628133>
+
+ Reviewed by Anders Carlsson.
+
+ Temporarily perform code signing verification only for Mac App Store- and Apple Developer- signed apps.
+
+ * Shared/mac/ChildProcessMac.mm:
+ (WebKit::codeSigningIdentifierForProcess):
+
2016-04-05 Oliver Hunt <[email protected]>
Remove compile time define for SEPARATED_HEAP
Modified: trunk/Source/WebKit2/Shared/mac/ChildProcessMac.mm (199300 => 199301)
--- trunk/Source/WebKit2/Shared/mac/ChildProcessMac.mm 2016-04-11 19:04:33 UTC (rev 199300)
+++ trunk/Source/WebKit2/Shared/mac/ChildProcessMac.mm 2016-04-11 19:06:20 UTC (rev 199301)
@@ -90,13 +90,13 @@
RetainPtr<SecCodeRef> codePtr = adoptCF(code);
RELEASE_ASSERT(codePtr);
- CFStringRef appleSignedOrMacAppStoreSignedOrAppleDeveloperSignedRequirement = CFSTR("(anchor apple) or (anchor apple generic and certificate leaf[field.1.2.840.113635.100.6.1.9]) or (anchor apple generic and certificate 1[field.1.2.840.113635.100.6.2.6] and certificate leaf[field.1.2.840.113635.100.6.1.13])");
+ CFStringRef macAppStoreSignedOrAppleDeveloperSignedRequirement = CFSTR("(anchor apple generic and certificate leaf[field.1.2.840.113635.100.6.1.9]) or (anchor apple generic and certificate 1[field.1.2.840.113635.100.6.2.6] and certificate leaf[field.1.2.840.113635.100.6.1.13])");
SecRequirementRef signingRequirement = nullptr;
- RELEASE_ASSERT(!SecRequirementCreateWithString(appleSignedOrMacAppStoreSignedOrAppleDeveloperSignedRequirement, kSecCSDefaultFlags, &signingRequirement));
+ RELEASE_ASSERT(!SecRequirementCreateWithString(macAppStoreSignedOrAppleDeveloperSignedRequirement, kSecCSDefaultFlags, &signingRequirement));
RetainPtr<SecRequirementRef> signingRequirementPtr = adoptCF(signingRequirement);
errorCode = SecCodeCheckValidity(codePtr.get(), kSecCSDefaultFlags, signingRequirementPtr.get());
if (errorCode == errSecCSUnsigned || errorCode == errSecCSReqFailed)
- return String(); // Unsigned or signed by a third-party
+ return String(); // Unsigned, signed by Apple, or signed by a third-party
if (errorCode != errSecSuccess)
return emptyString(); // e.g. invalid/malformed signature
String codeSigningIdentifier;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
