Title: [199373] trunk/Source/_javascript_Core
Revision
199373
Author
[email protected]
Date
2016-04-12 10:40:27 -0700 (Tue, 12 Apr 2016)

Log Message

Unreviewed, rolling out r199339.
https://bugs.webkit.org/show_bug.cgi?id=156505

memset_s is indeed necessary (Requested by alexchristensen_ on
#webkit).

Reverted changeset:

"Build fix after r199299."
https://bugs.webkit.org/show_bug.cgi?id=155508
http://trac.webkit.org/changeset/199339

Modified Paths

Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (199372 => 199373)


--- trunk/Source/_javascript_Core/ChangeLog	2016-04-12 17:27:07 UTC (rev 199372)
+++ trunk/Source/_javascript_Core/ChangeLog	2016-04-12 17:40:27 UTC (rev 199373)
@@ -1,3 +1,17 @@
+2016-04-12  Commit Queue  <[email protected]>
+
+        Unreviewed, rolling out r199339.
+        https://bugs.webkit.org/show_bug.cgi?id=156505
+
+        memset_s is indeed necessary (Requested by alexchristensen_ on
+        #webkit).
+
+        Reverted changeset:
+
+        "Build fix after r199299."
+        https://bugs.webkit.org/show_bug.cgi?id=155508
+        http://trac.webkit.org/changeset/199339
+
 2016-04-12  Guillaume Emont  <[email protected]>
 
         MIPS: add MacroAssemblerMIPS::store8(TrustedImm32,ImplicitAddress)

Modified: trunk/Source/_javascript_Core/jit/ExecutableAllocatorFixedVMPool.cpp (199372 => 199373)


--- trunk/Source/_javascript_Core/jit/ExecutableAllocatorFixedVMPool.cpp	2016-04-12 17:27:07 UTC (rev 199372)
+++ trunk/Source/_javascript_Core/jit/ExecutableAllocatorFixedVMPool.cpp	2016-04-12 17:40:27 UTC (rev 199373)
@@ -210,7 +210,7 @@
         RELEASE_ASSERT(!result);
 
         // Zero out writableAddr to avoid leaking the address of the writable mapping.
-        memset(&writableAddr, 0, sizeof(writableAddr));
+        memset_s(&writableAddr, sizeof(writableAddr), 0, sizeof(writableAddr));
 
         jitWriteFunction = reinterpret_cast<JITWriteFunction>(writeThunk.code().executableAddress());
     }
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to