Title: [199381] trunk/Source/WebCore
Revision
199381
Author
[email protected]
Date
2016-04-12 12:37:37 -0700 (Tue, 12 Apr 2016)

Log Message

WebKit should adopt journal_mode=wal for all SQLite databases.
https://bugs.webkit.org/show_bug.cgi?id=133496

Rubber stamped by Chris Dumez.

Temporarily disable on iOS - this broke a test.
(storage/websql/alter-to-info-table.html)

* platform/sql/SQLiteDatabase.cpp:
(WebCore::SQLiteDatabase::open):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (199380 => 199381)


--- trunk/Source/WebCore/ChangeLog	2016-04-12 19:35:22 UTC (rev 199380)
+++ trunk/Source/WebCore/ChangeLog	2016-04-12 19:37:37 UTC (rev 199381)
@@ -1,3 +1,16 @@
+2016-04-12  Gavin Barraclough  <[email protected]>
+
+        WebKit should adopt journal_mode=wal for all SQLite databases.
+        https://bugs.webkit.org/show_bug.cgi?id=133496
+
+        Rubber stamped by Chris Dumez.
+
+        Temporarily disable on iOS - this broke a test.
+        (storage/websql/alter-to-info-table.html)
+
+        * platform/sql/SQLiteDatabase.cpp:
+        (WebCore::SQLiteDatabase::open):
+
 2016-04-12  Joseph Pecoraro  <[email protected]>
 
         Web Inspector: Keyboard shortcut for "Inspect Element" only works when Web Inspector is open.

Modified: trunk/Source/WebCore/platform/sql/SQLiteDatabase.cpp (199380 => 199381)


--- trunk/Source/WebCore/platform/sql/SQLiteDatabase.cpp	2016-04-12 19:35:22 UTC (rev 199380)
+++ trunk/Source/WebCore/platform/sql/SQLiteDatabase.cpp	2016-04-12 19:37:37 UTC (rev 199381)
@@ -115,6 +115,7 @@
     if (!SQLiteStatement(*this, ASCIILiteral("PRAGMA temp_store = MEMORY;")).executeCommand())
         LOG_ERROR("SQLite database could not set temp_store to memory");
 
+#if !PLATFORM(IOS)
     SQLiteStatement walStatement(*this, ASCIILiteral("PRAGMA journal_mode=WAL;"));
     if (walStatement.prepareAndStep() == SQLITE_ROW) {
 #ifndef NDEBUG
@@ -124,6 +125,7 @@
 #endif
     } else
         LOG_ERROR("SQLite database failed to set journal_mode to WAL, error: %s", lastErrorMsg());
+#endif
 
     return isOpen();
 }
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to