Title: [199385] trunk/Source/WebCore
Revision
199385
Author
[email protected]
Date
2016-04-12 13:47:42 -0700 (Tue, 12 Apr 2016)

Log Message

Fixed uninitialization of Node::DataUnion with GCC 4.8.
https://bugs.webkit.org/show_bug.cgi?id=156507

Patch by Konstantin Tokarev <[email protected]> on 2016-04-12
Reviewed by Michael Catanzaro.

This change fixes run time crashes caused by access to uninitialized
memory in Node::renderer().

No new tests needed.

* dom/Node.h:

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (199384 => 199385)


--- trunk/Source/WebCore/ChangeLog	2016-04-12 20:47:24 UTC (rev 199384)
+++ trunk/Source/WebCore/ChangeLog	2016-04-12 20:47:42 UTC (rev 199385)
@@ -1,3 +1,17 @@
+2016-04-12  Konstantin Tokarev  <[email protected]>
+
+        Fixed uninitialization of Node::DataUnion with GCC 4.8.
+        https://bugs.webkit.org/show_bug.cgi?id=156507
+
+        Reviewed by Michael Catanzaro.
+
+        This change fixes run time crashes caused by access to uninitialized
+        memory in Node::renderer().
+
+        No new tests needed.
+
+        * dom/Node.h:
+
 2016-04-12  Eric Carlson  <[email protected]>
 
         [iOS] do not exit AirPlay when the screen locks

Modified: trunk/Source/WebCore/dom/Node.h (199384 => 199385)


--- trunk/Source/WebCore/dom/Node.h	2016-04-12 20:47:24 UTC (rev 199384)
+++ trunk/Source/WebCore/dom/Node.h	2016-04-12 20:47:42 UTC (rev 199385)
@@ -691,9 +691,9 @@
     Node* m_next { nullptr };
     // When a node has rare data we move the renderer into the rare data.
     union DataUnion {
-        RenderObject* m_renderer { nullptr };
+        RenderObject* m_renderer;
         NodeRareDataBase* m_rareData;
-    } m_data;
+    } m_data { nullptr };
 
 protected:
     bool isParsingChildrenFinished() const { return getFlag(IsParsingChildrenFinishedFlag); }
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to